Re: [libav-devel] [PATCH] h264: refactor NAL decoding loop.

2012-07-22 Thread Ronald S. Bultje
Hi, On Sun, Jul 22, 2012 at 8:17 AM, Måns Rullgård wrote: > "Ronald S. Bultje" writes: > >>> This manner of splitting things is incredibly weird-looking. Instead of >>> trying to unify these rather different fragments, turning the second >>> half of the loop into a macro and writing out separat

Re: [libav-devel] [PATCH] h264: refactor NAL decoding loop.

2012-07-22 Thread Måns Rullgård
"Ronald S. Bultje" writes: >> This manner of splitting things is incredibly weird-looking. Instead of >> trying to unify these rather different fragments, turning the second >> half of the loop into a macro and writing out separate loops, each >> calling the macro for the common part, would prob

Re: [libav-devel] [PATCH] h264: refactor NAL decoding loop.

2012-07-22 Thread Ronald S. Bultje
Hi, On Sat, Jul 21, 2012 at 5:19 PM, Måns Rullgård wrote: > "Ronald S. Bultje" writes: > >> From: "Ronald S. Bultje" >> >> This removes some code duplication between the 3 different versions, >> and aligns brackets in such a way that it is now possible to pull >> this code through a naive pre-p

Re: [libav-devel] [PATCH] h264: refactor NAL decoding loop.

2012-07-21 Thread Måns Rullgård
"Ronald S. Bultje" writes: > From: "Ronald S. Bultje" > > This removes some code duplication between the 3 different versions, > and aligns brackets in such a way that it is now possible to pull > this code through a naive pre-processor that doesn't necessarily have > to be aware of compiler-mac

[libav-devel] [PATCH] h264: refactor NAL decoding loop.

2012-07-21 Thread Ronald S. Bultje
From: "Ronald S. Bultje" This removes some code duplication between the 3 different versions, and aligns brackets in such a way that it is now possible to pull this code through a naive pre-processor that doesn't necessarily have to be aware of compiler-macros. --- libavcodec/h264.c | 36 +