Re: [libav-devel] [PATCH] hevc: Split the struct setup from the pps parsing

2015-07-15 Thread Luca Barbato
On 14/07/15 12:36, Luca Barbato wrote: --- Properly rebased version Ping. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] hevc: Split the struct setup from the pps parsing

2015-07-15 Thread Luca Barbato
On 15/07/15 19:26, James Almer wrote: Function call overhead. ff_hevc_decode_nal_pps() is not an init function, it may or may not be called for every decoded frame. Actually the function is a tad big and will get bigger so probably won't hurt leaving to the compiler the task to decide if

Re: [libav-devel] [PATCH] hevc: Split the struct setup from the pps parsing

2015-07-15 Thread James Almer
On 15/07/15 1:46 PM, Luca Barbato wrote: On 15/07/15 18:26, James Almer wrote: If this is done only for readability's sake and not because this function will be used somewhere else, then making sure the compiler always inlines this function may be a good idea. Good idea, the idea itself

Re: [libav-devel] [PATCH] hevc: Split the struct setup from the pps parsing

2015-07-15 Thread Anton Khirnov
Quoting James Almer (2015-07-15 19:26:08) On 15/07/15 2:06 PM, Anton Khirnov wrote: Quoting James Almer (2015-07-15 18:26:28) On 14/07/15 7:36 AM, Luca Barbato wrote: --- Properly rebased version libavcodec/hevc_ps.c | 258 ++- 1

Re: [libav-devel] [PATCH] hevc: Split the struct setup from the pps parsing

2015-07-15 Thread Anton Khirnov
Quoting James Almer (2015-07-15 18:26:28) On 14/07/15 7:36 AM, Luca Barbato wrote: --- Properly rebased version libavcodec/hevc_ps.c | 258 ++- 1 file changed, 131 insertions(+), 127 deletions(-) diff --git

Re: [libav-devel] [PATCH] hevc: Split the struct setup from the pps parsing

2015-07-15 Thread James Almer
On 15/07/15 2:06 PM, Anton Khirnov wrote: Quoting James Almer (2015-07-15 18:26:28) On 14/07/15 7:36 AM, Luca Barbato wrote: --- Properly rebased version libavcodec/hevc_ps.c | 258 ++- 1 file changed, 131 insertions(+), 127 deletions(-)

Re: [libav-devel] [PATCH] hevc: Split the struct setup from the pps parsing

2015-07-15 Thread Luca Barbato
On 15/07/15 18:26, James Almer wrote: If this is done only for readability's sake and not because this function will be used somewhere else, then making sure the compiler always inlines this function may be a good idea. Good idea, the idea itself is fine? lu

Re: [libav-devel] [PATCH] hevc: Split the struct setup from the pps parsing

2015-07-15 Thread James Almer
On 14/07/15 7:36 AM, Luca Barbato wrote: --- Properly rebased version libavcodec/hevc_ps.c | 258 ++- 1 file changed, 131 insertions(+), 127 deletions(-) diff --git a/libavcodec/hevc_ps.c b/libavcodec/hevc_ps.c index a5a2ace..2112265

[libav-devel] [PATCH] hevc: Split the struct setup from the pps parsing

2015-07-14 Thread Luca Barbato
--- Properly rebased version libavcodec/hevc_ps.c | 258 ++- 1 file changed, 131 insertions(+), 127 deletions(-) diff --git a/libavcodec/hevc_ps.c b/libavcodec/hevc_ps.c index a5a2ace..2112265 100644 --- a/libavcodec/hevc_ps.c +++