Re: [libav-devel] [PATCH] matroskaenc: Don't set language to empty string, use "und"

2016-03-19 Thread Vittorio Giovara
On Wed, Jul 23, 2014 at 7:03 AM, Anton Khirnov wrote: > > On Tue, 22 Jul 2014 09:38:42 +0200, j...@v2v.cc wrote: >> On 07/21/2014 09:35 PM, Anton Khirnov wrote: >> > >> > On Sun, 20 Jul 2014 15:28:36 +0200, j...@v2v.cc wrote: >> >> On 07/20/2014 03:13 PM, Anton Khirnov wrote:

Re: [libav-devel] [PATCH] matroskaenc: Don't set language to empty string, use und

2014-07-23 Thread Anton Khirnov
On Tue, 22 Jul 2014 09:38:42 +0200, j...@v2v.cc wrote: On 07/21/2014 09:35 PM, Anton Khirnov wrote: On Sun, 20 Jul 2014 15:28:36 +0200, j...@v2v.cc wrote: On 07/20/2014 03:13 PM, Anton Khirnov wrote: Could you share the sample? This really sounds like a bug elsewhere that should be

Re: [libav-devel] [PATCH] matroskaenc: Don't set language to empty string, use und

2014-07-21 Thread Jan Gerber
On 07/20/2014 03:28 PM, j...@v2v.cc wrote: On 07/20/2014 03:13 PM, Anton Khirnov wrote: Could you share the sample? This really sounds like a bug elsewhere that should be fixed. Here a short clip http://v2v.cc/~j/samples/emtpy_language.mpg Found the issue for this sample in mpegts.c,

Re: [libav-devel] [PATCH] matroskaenc: Don't set language to empty string, use und

2014-07-21 Thread Luca Barbato
On 21/07/14 10:24, Jan Gerber wrote: On 07/20/2014 03:28 PM, j...@v2v.cc wrote: On 07/20/2014 03:13 PM, Anton Khirnov wrote: Could you share the sample? This really sounds like a bug elsewhere that should be fixed. Here a short clip http://v2v.cc/~j/samples/emtpy_language.mpg Found the

[libav-devel] [PATCH] matroskaenc: Don't set language to empty string, use und

2014-07-20 Thread Jan Gerber
--- libavformat/matroskaenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index b55ad35..aa30b9b 100644 --- a/libavformat/matroskaenc.c +++ b/libavformat/matroskaenc.c @@ -681,7 +681,7 @@ static int

Re: [libav-devel] [PATCH] matroskaenc: Don't set language to empty string, use und

2014-07-20 Thread Luca Barbato
On 20/07/14 10:36, Jan Gerber wrote: --- libavformat/matroskaenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Probably ok, whoever pushes, please put spaces around : lu ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] matroskaenc: Don't set language to empty string, use und

2014-07-20 Thread Anton Khirnov
On Sun, 20 Jul 2014 10:36:35 +0200, Jan Gerber j...@v2v.cc wrote: --- libavformat/matroskaenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index b55ad35..aa30b9b 100644 --- a/libavformat/matroskaenc.c +++

Re: [libav-devel] [PATCH] matroskaenc: Don't set language to empty string, use und

2014-07-20 Thread j
On 07/20/2014 01:41 PM, Anton Khirnov wrote: @@ -681,7 +681,7 @@ static int mkv_write_track(AVFormatContext *s, MatroskaMuxContext *mkv, if ((tag = av_dict_get(st-metadata, title, NULL, 0))) put_ebml_string(pb, MATROSKA_ID_TRACKNAME, tag-value); tag =

Re: [libav-devel] [PATCH] matroskaenc: Don't set language to empty string, use und

2014-07-20 Thread Anton Khirnov
On Sun, 20 Jul 2014 14:49:05 +0200, j...@v2v.cc wrote: On 07/20/2014 01:41 PM, Anton Khirnov wrote: @@ -681,7 +681,7 @@ static int mkv_write_track(AVFormatContext *s, MatroskaMuxContext *mkv, if ((tag = av_dict_get(st-metadata, title, NULL, 0))) put_ebml_string(pb,

Re: [libav-devel] [PATCH] matroskaenc: Don't set language to empty string, use und

2014-07-20 Thread j
On 07/20/2014 03:13 PM, Anton Khirnov wrote: Could you share the sample? This really sounds like a bug elsewhere that should be fixed. Here a short clip http://v2v.cc/~j/samples/emtpy_language.mpg ___ libav-devel mailing list libav-devel@libav.org