Re: [libav-devel] [PATCH] mp3: Properly use AVCodecContext API

2015-03-10 Thread Vittorio Giovara
On Tue, Mar 10, 2015 at 1:24 AM, Timothy Gu wrote: > On Mon, Mar 9, 2015 at 4:02 PM Vittorio Giovara > wrote: > >> >> Subject: [libav-devel] [PATCH] mp3: Properly use AVCodecContext API > > > Can you make this a little more specific: > > mp3: Properly alloc

Re: [libav-devel] [PATCH] mp3: Properly use AVCodecContext API

2015-03-10 Thread Vittorio Giovara
On Tue, Mar 10, 2015 at 6:46 AM, Anton Khirnov wrote: > Quoting Vittorio Giovara (2015-03-10 00:02:00) >> Rather than having an unitialized context on the stack, allocate it with >> defaults and free it when unneeded. >> >> CC: libav-sta...@libav.org > > The patch looks fine, but why should it go

Re: [libav-devel] [PATCH] mp3: Properly use AVCodecContext API

2015-03-09 Thread Anton Khirnov
Quoting Vittorio Giovara (2015-03-10 00:02:00) > Rather than having an unitialized context on the stack, allocate it with > defaults and free it when unneeded. > > CC: libav-sta...@libav.org The patch looks fine, but why should it go into stable? -- Anton Khirnov ___

Re: [libav-devel] [PATCH] mp3: Properly use AVCodecContext API

2015-03-09 Thread Timothy Gu
On Mon, Mar 9, 2015 at 4:02 PM Vittorio Giovara wrote: > > Subject: [libav-devel] [PATCH] mp3: Properly use AVCodecContext API Can you make this a little more specific: mp3: Properly allocate AVCodecContext Can't comment on the res

[libav-devel] [PATCH] mp3: Properly use AVCodecContext API

2015-03-09 Thread Vittorio Giovara
Rather than having an unitialized context on the stack, allocate it with defaults and free it when unneeded. CC: libav-sta...@libav.org --- Big thanks to Hendrik for pointing this out. Hopefully this fixes a few of the uninitialized reports by valgrind on FATE. Vittorio libavformat/mp3dec.c | 11