Re: [libav-devel] [PATCH] opusdec: Don't run vector_fmul_scalar on zero length arrays

2015-10-28 Thread Luca Barbato
On 27/10/15 01:30, Luca Barbato wrote: > On 27/10/15 00:09, Kieran Kunhya wrote: >> On 26 October 2015 at 22:48, Hendrik Leppkes wrote: >>> On Mon, Oct 26, 2015 at 11:29 PM, Kieran Kunhya wrote: From a1314d5c9774d555718bbc0a8612144c890bbc59 Mon Sep 17

Re: [libav-devel] [PATCH] opusdec: Don't run vector_fmul_scalar on zero length arrays

2015-10-28 Thread Luca Barbato
On 28/10/15 15:16, Hendrik Leppkes wrote: > On Wed, Oct 28, 2015 at 2:35 PM, Luca Barbato wrote: >> On 27/10/15 01:30, Luca Barbato wrote: >>> On 27/10/15 00:09, Kieran Kunhya wrote: On 26 October 2015 at 22:48, Hendrik Leppkes wrote: > On Mon,

Re: [libav-devel] [PATCH] opusdec: Don't run vector_fmul_scalar on zero length arrays

2015-10-28 Thread Diego Biurrun
On Wed, Oct 28, 2015 at 03:16:34PM +0100, Hendrik Leppkes wrote: > On Wed, Oct 28, 2015 at 2:35 PM, Luca Barbato wrote: > > On 27/10/15 01:30, Luca Barbato wrote: > >> On 27/10/15 00:09, Kieran Kunhya wrote: > >>> On 26 October 2015 at 22:48, Hendrik Leppkes

Re: [libav-devel] [PATCH] opusdec: Don't run vector_fmul_scalar on zero length arrays

2015-10-28 Thread Hendrik Leppkes
On Wed, Oct 28, 2015 at 3:50 PM, Luca Barbato wrote: > On 28/10/15 15:16, Hendrik Leppkes wrote: >> On Wed, Oct 28, 2015 at 2:35 PM, Luca Barbato wrote: >>> On 27/10/15 01:30, Luca Barbato wrote: On 27/10/15 00:09, Kieran Kunhya wrote: > On 26

Re: [libav-devel] [PATCH] opusdec: Don't run vector_fmul_scalar on zero length arrays

2015-10-28 Thread Hendrik Leppkes
On Wed, Oct 28, 2015 at 2:35 PM, Luca Barbato wrote: > On 27/10/15 01:30, Luca Barbato wrote: >> On 27/10/15 00:09, Kieran Kunhya wrote: >>> On 26 October 2015 at 22:48, Hendrik Leppkes wrote: On Mon, Oct 26, 2015 at 11:29 PM, Kieran Kunhya

Re: [libav-devel] [PATCH] opusdec: Don't run vector_fmul_scalar on zero length arrays

2015-10-28 Thread Kieran Kunhya
> I can only repeat the point I made before - ASM is not about safety, > its about speed. > If you can re-write it to not be a single cycle slower and not have > this particular behavior, great. > > In the meantime, can we apply this patch and get the crash done with? > > FWIW, all other callers

Re: [libav-devel] [PATCH] opusdec: Don't run vector_fmul_scalar on zero length arrays

2015-10-28 Thread Luca Barbato
On 28/10/15 16:19, Hendrik Leppkes wrote: > On Wed, Oct 28, 2015 at 3:50 PM, Luca Barbato wrote: >> On 28/10/15 15:16, Hendrik Leppkes wrote: >>> On Wed, Oct 28, 2015 at 2:35 PM, Luca Barbato wrote: On 27/10/15 01:30, Luca Barbato wrote: > On

Re: [libav-devel] [PATCH] opusdec: Don't run vector_fmul_scalar on zero length arrays

2015-10-26 Thread Luca Barbato
On 27/10/15 00:09, Kieran Kunhya wrote: > On 26 October 2015 at 22:48, Hendrik Leppkes wrote: >> On Mon, Oct 26, 2015 at 11:29 PM, Kieran Kunhya wrote: >>> From a1314d5c9774d555718bbc0a8612144c890bbc59 Mon Sep 17 00:00:00 2001 >>> From: Kieran Kunhya

Re: [libav-devel] [PATCH] opusdec: Don't run vector_fmul_scalar on zero length arrays

2015-10-26 Thread Hendrik Leppkes
On Mon, Oct 26, 2015 at 11:29 PM, Kieran Kunhya wrote: > From a1314d5c9774d555718bbc0a8612144c890bbc59 Mon Sep 17 00:00:00 2001 > From: Kieran Kunhya > Date: Mon, 26 Oct 2015 22:26:35 + > Subject: [PATCH] opusdec: Don't run vector_fmul_scalar on zero length

Re: [libav-devel] [PATCH] opusdec: Don't run vector_fmul_scalar on zero length arrays

2015-10-26 Thread Kieran Kunhya
On 26 October 2015 at 22:48, Hendrik Leppkes wrote: > On Mon, Oct 26, 2015 at 11:29 PM, Kieran Kunhya wrote: >> From a1314d5c9774d555718bbc0a8612144c890bbc59 Mon Sep 17 00:00:00 2001 >> From: Kieran Kunhya >> Date: Mon, 26 Oct 2015 22:26:35

[libav-devel] [PATCH] opusdec: Don't run vector_fmul_scalar on zero length arrays

2015-10-26 Thread Kieran Kunhya
>From a1314d5c9774d555718bbc0a8612144c890bbc59 Mon Sep 17 00:00:00 2001 From: Kieran Kunhya Date: Mon, 26 Oct 2015 22:26:35 + Subject: [PATCH] opusdec: Don't run vector_fmul_scalar on zero length arrays Fixes crashes on fuzzed files --- libavcodec/opusdec.c |2 +- 1