On 18/12/11 16:10, Anton Khirnov wrote:
+avio_close(oc->pb);
+if (oc->oformat->priv_class)
+av_opt_free(oc->priv_data);
The indentation is off.
The rest looks good.
Fixing it and pushing then =)
--
Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero
_
On Tue, 13 Dec 2011 16:09:33 +0100, Luca Barbato wrote:
> It behaves similarly to image2 muxer
> ---
> Changelog|1 +
> doc/muxers.texi | 32 ++
> libavformat/Makefile |1 +
> libavformat/allformats.c |1 +
> libavformat/segment.c| 273
> +
On 13/12/11 16:09, Luca Barbato wrote:
It behaves similarly to image2 muxer
---
Changelog|1 +
doc/muxers.texi | 32 ++
libavformat/Makefile |1 +
libavformat/allformats.c |1 +
libavformat/segment.c| 273 ++
It behaves similarly to image2 muxer
---
Changelog|1 +
doc/muxers.texi | 32 ++
libavformat/Makefile |1 +
libavformat/allformats.c |1 +
libavformat/segment.c| 273 ++
5 files changed, 308 insertions(
It behaves similarly to image2 muxer
---
Changelog|1 +
doc/muxers.texi | 32 ++
libavformat/Makefile |1 +
libavformat/allformats.c |1 +
libavformat/segment.c| 263 ++
libavformat/version.h|2
On Sun, Dec 11, 2011 at 07:55:40PM +0100, Luca Barbato wrote:
> On 11/12/11 11:33, Diego Biurrun wrote:
> >On Sun, Dec 11, 2011 at 03:20:56AM +0100, Luca Barbato wrote:
> >> doc/muxers.texi | 32 ++
> >> libavformat/Makefile |1 +
> >> libavformat/allformats.c |1 +
> >>
On 11/12/11 18:49, Anton Khirnov wrote:
On Sun, 11 Dec 2011 18:19:11 +0100, Luca Barbato wrote:
On 11/12/11 07:29, Anton Khirnov wrote:
The segmenter is declared as AVFMT_NOFILE, the calling app would expect s->pb
to be NULL. I think you should move it to private data.
I doubt the caller wo
On 11/12/11 11:33, Diego Biurrun wrote:
On Sun, Dec 11, 2011 at 03:20:56AM +0100, Luca Barbato wrote:
It behaves similarly to image2 muxer
similar to the
Ok.
doc/muxers.texi | 32 ++
libavformat/Makefile |1 +
libavformat/allformats.c |1 +
libavformat/segme
On Sun, 11 Dec 2011 18:19:11 +0100, Luca Barbato wrote:
> On 11/12/11 07:29, Anton Khirnov wrote:
> > The segmenter is declared as AVFMT_NOFILE, the calling app would expect
> > s->pb
> > to be NULL. I think you should move it to private data.
>
> I doubt the caller would try something strange
On 11/12/11 07:29, Anton Khirnov wrote:
The segmenter is declared as AVFMT_NOFILE, the calling app would expect s->pb
to be NULL. I think you should move it to private data.
I doubt the caller would try something strange with that field I can
move it in case.
You should also discard AVFMT_N
On Sun, Dec 11, 2011 at 03:20:56AM +0100, Luca Barbato wrote:
> It behaves similarly to image2 muxer
similar to the
> doc/muxers.texi | 32 ++
> libavformat/Makefile |1 +
> libavformat/allformats.c |1 +
> libavformat/segment.c| 257
> +++
On Sun, 11 Dec 2011 03:20:56 +0100, Luca Barbato wrote:
> It behaves similarly to image2 muxer
> ---
>
> Thanks to Anton for pointing av_guess_format works as I wanted by itself
>
> doc/muxers.texi | 32 ++
> libavformat/Makefile |1 +
> libavformat/allformats.c |1 +
It behaves similarly to image2 muxer
---
Thanks to Anton for pointing av_guess_format works as I wanted by itself
doc/muxers.texi | 32 ++
libavformat/Makefile |1 +
libavformat/allformats.c |1 +
libavformat/segment.c| 257
On 07/12/11 20:20, Luca Barbato wrote:
It behaves similarly to image2 muxer
---
doc/muxers.texi | 32 ++
libavformat/Makefile |1 +
libavformat/allformats.c |1 +
libavformat/segment.c| 265 ++
4 files changed, 299
It behaves similarly to image2 muxer
---
doc/muxers.texi | 32 ++
libavformat/Makefile |1 +
libavformat/allformats.c |1 +
libavformat/segment.c| 265 ++
4 files changed, 299 insertions(+), 0 deletions(-)
create mode 100
On 07/12/11 18:30, Anton Khirnov wrote:
* avio_open -> avio_open2 please
Ok.
* You seem to (ab)use lavf internals, like calling the function
pointers in AVOutputFormat directly, messing with private data etc. I
suppose that can't be avoided easily, but you should at least document
the reaso
On Wed, 7 Dec 2011 16:47:25 +0100, Luca Barbato wrote:
> It behaves similarly to image2 muxer
> ---
> doc/muxers.texi | 32 ++
> libavformat/Makefile |1 +
> libavformat/allformats.c |1 +
> libavformat/segment.c| 256
> ++
On Wed, Dec 07, 2011 at 04:47:25PM +0100, Luca Barbato wrote:
> It behaves similarly to image2 muxer
except that image2 makes segments exactly of one frame, be it video or audio,
keyframe or not :)
> ---
> doc/muxers.texi | 32 ++
> libavformat/Makefile |1 +
> libavformat
It behaves similarly to image2 muxer
---
doc/muxers.texi | 32 ++
libavformat/Makefile |1 +
libavformat/allformats.c |1 +
libavformat/segment.c| 256 ++
4 files changed, 290 insertions(+), 0 deletions(-)
create mode 100
On 07/12/11 11:44, Diego Biurrun wrote:
On Wed, Dec 07, 2011 at 01:06:43AM +0100, Luca Barbato wrote:
It behaves similarly to image2 muxer
similar to the
But maybe you could describe it in a sentence or two instead. I don't
remember offhand what the image2 muxer did.
It is described in the
On Wed, Dec 07, 2011 at 01:06:43AM +0100, Luca Barbato wrote:
> It behaves similarly to image2 muxer
similar to the
But maybe you could describe it in a sentence or two instead. I don't
remember offhand what the image2 muxer did.
> ---
> doc/muxers.texi | 27 +
> libavformat/Mak
On Wed, Dec 07, 2011 at 01:06:43AM +0100, Luca Barbato wrote:
> It behaves similarly to image2 muxer
> ---
> doc/muxers.texi | 27 +
> libavformat/Makefile |1 +
> libavformat/allformats.c |1 +
> libavformat/segment.c| 249
> +++
It behaves similarly to image2 muxer
---
doc/muxers.texi | 27 +
libavformat/Makefile |1 +
libavformat/allformats.c |1 +
libavformat/segment.c| 249 ++
4 files changed, 278 insertions(+), 0 deletions(-)
create mode 1006
23 matches
Mail list logo
