Re: [libav-devel] [PATCH] sipr: fall back to setting mode based on bit_rate.

2012-09-23 Thread Reinhard Tartler
On Fri, Sep 21, 2012 at 4:59 PM, Justin Ruggles wrote: > On 09/21/2012 10:31 AM, Reinhard Tartler wrote: >> On Tue, Sep 4, 2012 at 7:03 PM, Reinhard Tartler wrote: >>> Not all applications (e.g. MPlayer) set block_align, and >>> when using a different demuxer it might not even be >>> easily avail

Re: [libav-devel] [PATCH] sipr: fall back to setting mode based on bit_rate.

2012-09-21 Thread Justin Ruggles
On 09/21/2012 10:31 AM, Reinhard Tartler wrote: > On Tue, Sep 4, 2012 at 7:03 PM, Reinhard Tartler wrote: >> Not all applications (e.g. MPlayer) set block_align, and >> when using a different demuxer it might not even be >> easily available. >> >> Therefore fall back to selecting mode based on bit

Re: [libav-devel] [PATCH] sipr: fall back to setting mode based on bit_rate.

2012-09-21 Thread Reinhard Tartler
On Tue, Sep 4, 2012 at 7:03 PM, Reinhard Tartler wrote: > Not all applications (e.g. MPlayer) set block_align, and > when using a different demuxer it might not even be > easily available. > > Therefore fall back to selecting mode based on bit rate as before if > block_align has not useful value.

[libav-devel] [PATCH] sipr: fall back to setting mode based on bit_rate.

2012-09-04 Thread Reinhard Tartler
Not all applications (e.g. MPlayer) set block_align, and when using a different demuxer it might not even be easily available. Therefore fall back to selecting mode based on bit rate as before if block_align has not useful value. It can't be worse than failing to decode completely. Based on a pa

Re: [libav-devel] [PATCH] sipr: fall back to setting mode based on bit_rate.

2012-09-04 Thread Derek Buitenhuis
On 03/09/2012 7:43 PM, Luca Barbato wrote: >>> av_log(avctx, AV_LOG_ERROR, "Invalid block_align: %d\n", >>> avctx->block_align); > replace error with warning in this case while you are at it. Or explode mode. - Derek ___ libav-devel mailing

Re: [libav-devel] [PATCH] sipr: fall back to setting mode based on bit_rate.

2012-09-03 Thread Luca Barbato
On 9/3/12 10:52 PM, Justin Ruggles wrote: On 09/03/2012 04:41 PM, Reinhard Tartler wrote: From: Reimar Döffinger Not all applications (e.g. MPlayer) set block_align, and when using a different demuxer it might not even be easily available. So fall back to selecting mode based on bit rate as be

Re: [libav-devel] [PATCH] sipr: fall back to setting mode based on bit_rate.

2012-09-03 Thread Justin Ruggles
On 09/03/2012 04:41 PM, Reinhard Tartler wrote: > From: Reimar Döffinger > > Not all applications (e.g. MPlayer) set block_align, and > when using a different demuxer it might not even be > easily available. > So fall back to selecting mode based on bit rate as before > if block_align has not use

[libav-devel] [PATCH] sipr: fall back to setting mode based on bit_rate.

2012-09-03 Thread Reinhard Tartler
From: Reimar Döffinger Not all applications (e.g. MPlayer) set block_align, and when using a different demuxer it might not even be easily available. So fall back to selecting mode based on bit rate as before if block_align has not useful value. It can't be worse than failing to decode completely