Re: [libav-devel] [PATCH] snow: remove a VLA.

2012-07-02 Thread Martin Storsjö
On Sat, 30 Jun 2012, Martin Storsjö wrote: From: Ronald S. Bultje rsbul...@gmail.com --- This removes the useless const declarations from the pointer parameters from the previous version, and the useless assert. When passing pointers to the full 2D array, it's not possible to add const

Re: [libav-devel] [PATCH] snow: remove a VLA.

2012-07-02 Thread Måns Rullgård
Martin Storsjö mar...@martin.st writes: On Sat, 30 Jun 2012, Martin Storsjö wrote: From: Ronald S. Bultje rsbul...@gmail.com --- This removes the useless const declarations from the pointer parameters from the previous version, and the useless assert. When passing pointers to the full 2D

Re: [libav-devel] [PATCH] snow: remove a VLA used for edge emulation.

2012-07-02 Thread Ronald S. Bultje
Hi, On Sun, Jul 1, 2012 at 9:46 AM, Martin Storsjö mar...@martin.st wrote: On Sat, 30 Jun 2012, Ronald S. Bultje wrote: From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/snow.c    |    4 libavcodec/snow.h    |    3 ++- libavcodec/snowenc.c |    2 +- 3 files changed, 7

Re: [libav-devel] [PATCH] snow: remove a VLA used for edge emulation.

2012-07-01 Thread Martin Storsjö
On Sat, 30 Jun 2012, Ronald S. Bultje wrote: From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/snow.c|4 libavcodec/snow.h|3 ++- libavcodec/snowenc.c |2 +- 3 files changed, 7 insertions(+), 2 deletions(-) This one seems to break fate for me // Martin

Re: [libav-devel] [PATCH] snow: remove a VLA used for edge emulation.

2012-07-01 Thread Martin Storsjö
On Sat, 30 Jun 2012, Ronald S. Bultje wrote: From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/snow.c|4 libavcodec/snow.h|3 ++- libavcodec/snowenc.c |2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/libavcodec/snow.c b/libavcodec/snow.c index

Re: [libav-devel] [PATCH] snow: remove a VLA used for edge emulation.

2012-07-01 Thread Måns Rullgård
Martin Storsjö mar...@martin.st writes: On Sat, 30 Jun 2012, Ronald S. Bultje wrote: From: Ronald S. Bultje rsbul...@gmail.com [...] @@ -284,7 +285,7 @@ static av_always_inline void add_yblock(SnowContext *s, int sliced, slice_buffer BlockNode *rb= lb+1; uint8_t *block[4];

[libav-devel] [PATCH] snow: remove a VLA used for edge emulation.

2012-06-30 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/snow.c|4 libavcodec/snow.h|3 ++- libavcodec/snowenc.c |2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/libavcodec/snow.c b/libavcodec/snow.c index edd7d07..870bbef 100644 ---

[libav-devel] [PATCH] snow: remove a VLA.

2012-06-30 Thread Martin Storsjö
From: Ronald S. Bultje rsbul...@gmail.com --- This removes the useless const declarations from the pointer parameters from the previous version, and the useless assert. When passing pointers to the full 2D array, it's not possible to add const qualifiers to the second level of the array (without

Re: [libav-devel] [PATCH] snow: remove a VLA used for edge emulation.

2012-06-30 Thread Luca Barbato
On 06/30/2012 07:31 PM, Ronald S. Bultje wrote: From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/snow.c|4 libavcodec/snow.h|3 ++- libavcodec/snowenc.c |2 +- 3 files changed, 7 insertions(+), 2 deletions(-) Seems ok. lu -- Luca Barbato

Re: [libav-devel] [PATCH] snow: remove a VLA used for edge emulation.

2012-06-30 Thread Måns Rullgård
Ronald S. Bultje rsbul...@gmail.com writes: From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/snow.c|4 libavcodec/snow.h|3 ++- libavcodec/snowenc.c |2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/libavcodec/snow.c

[libav-devel] [PATCH] snow: remove tmp2t VLA.

2012-06-30 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/motion_est.c | 26 +++--- libavcodec/mpegvideo.h |6 ++ libavcodec/snow.c | 37 + libavcodec/snow.h |2 ++ 4 files changed, 52 insertions(+), 19

Re: [libav-devel] [PATCH] snow: remove a VLA.

2012-06-18 Thread Måns Rullgård
Ronald S. Bultje rsbul...@gmail.com writes: From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/snowenc.c | 42 ++ 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/libavcodec/snowenc.c b/libavcodec/snowenc.c index

Re: [libav-devel] [PATCH] snow: remove a VLA.

2012-06-16 Thread Måns Rullgård
Ronald S. Bultje rsbul...@gmail.com writes: Hi, On Fri, Jun 15, 2012 at 5:37 PM, Måns Rullgård m...@mansr.com wrote: Ronald S. Bultje rsbul...@gmail.com writes: From: Ronald S. Bultje rsbul...@gmail.com ---  libavcodec/snowenc.c |   42 ++  1 file

Re: [libav-devel] [PATCH] snow: remove a VLA.

2012-06-15 Thread Luca Barbato
On 06/15/2012 01:02 AM, Ronald S. Bultje wrote: From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/snowenc.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/snowenc.c b/libavcodec/snowenc.c index 7b010e1..3c06f8e 100644 ---

Re: [libav-devel] [PATCH] snow: remove a VLA.

2012-06-15 Thread Måns Rullgård
Ronald S. Bultje rsbul...@gmail.com writes: From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/snowenc.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/snowenc.c b/libavcodec/snowenc.c index 7b010e1..3c06f8e 100644 --- a/libavcodec/snowenc.c

[libav-devel] [PATCH] snow: remove a VLA.

2012-06-15 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/snowenc.c | 42 ++ 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/libavcodec/snowenc.c b/libavcodec/snowenc.c index 7b010e1..ac276f9 100644 --- a/libavcodec/snowenc.c +++

Re: [libav-devel] [PATCH] snow: remove a VLA.

2012-06-15 Thread Måns Rullgård
Ronald S. Bultje rsbul...@gmail.com writes: From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/snowenc.c | 42 ++ 1 file changed, 22 insertions(+), 20 deletions(-) Have you verified that this fails some test with the old patch and passes with

Re: [libav-devel] [PATCH] snow: remove a VLA.

2012-06-15 Thread Ronald S. Bultje
Hi, On Fri, Jun 15, 2012 at 5:37 PM, Måns Rullgård m...@mansr.com wrote: Ronald S. Bultje rsbul...@gmail.com writes: From: Ronald S. Bultje rsbul...@gmail.com ---  libavcodec/snowenc.c |   42 ++  1 file changed, 22 insertions(+), 20 deletions(-)

[libav-devel] [PATCH] snow: remove a VLA.

2012-06-14 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/snowenc.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/snowenc.c b/libavcodec/snowenc.c index 7b010e1..3c06f8e 100644 --- a/libavcodec/snowenc.c +++ b/libavcodec/snowenc.c @@ -1074,8 +1074,9 @@ static