Re: [libav-devel] [PATCH] svq1dec: Call av_fast_malloc() correctly

2014-12-08 Thread Vittorio Giovara
On Sun, Dec 7, 2014 at 9:58 AM, Anton Khirnov wrote: > Hi, > Quoting Nicolas Dufresne (2014-12-04 21:00:06) >> av_fast_malloc() signature is void*, but this is just a convenience >> not to have to cast. In fact it expect a pointer to pointer. This >> fixes a crash on NULL pointer when playing back

Re: [libav-devel] [PATCH] svq1dec: Call av_fast_malloc() correctly

2014-12-07 Thread Luca Barbato
On 07/12/14 10:58, Anton Khirnov wrote: Hi, Quoting Nicolas Dufresne (2014-12-04 21:00:06) av_fast_malloc() signature is void*, but this is just a convenience not to have to cast. In fact it expect a pointer to pointer. This fixes a crash on NULL pointer when playing back H263 Sorensen. Thank

Re: [libav-devel] [PATCH] svq1dec: Call av_fast_malloc() correctly

2014-12-07 Thread Anton Khirnov
Hi, Quoting Nicolas Dufresne (2014-12-04 21:00:06) > av_fast_malloc() signature is void*, but this is just a convenience > not to have to cast. In fact it expect a pointer to pointer. This > fixes a crash on NULL pointer when playing back H263 Sorensen. > Thank you for fixing my breakage. Do you h

Re: [libav-devel] [PATCH] svq1dec: Call av_fast_malloc() correctly

2014-12-06 Thread Luca Barbato
On 05/12/14 22:26, Vittorio Giovara wrote: On Fri, Dec 5, 2014 at 5:58 PM, Timothy Gu wrote: It also uses padded malloc. Oh, I hadn't noticed thanks. I am not familiar with that function, opinions from the audience? I guess it is time to clean up at least the commit message since as usua

Re: [libav-devel] [PATCH] svq1dec: Call av_fast_malloc() correctly

2014-12-05 Thread Vittorio Giovara
On Fri, Dec 5, 2014 at 5:58 PM, Timothy Gu wrote: > It also uses padded malloc. Oh, I hadn't noticed thanks. I am not familiar with that function, opinions from the audience? -- Vittorio ___ libav-devel mailing list libav-devel@libav.org https://list

Re: [libav-devel] [PATCH] svq1dec: Call av_fast_malloc() correctly

2014-12-05 Thread Timothy Gu
On Fri, Dec 5, 2014 at 3:48 AM, Vittorio Giovara wrote: > On Fri, Dec 5, 2014 at 8:21 AM, Christophe Gisquet > wrote: >> HuiHi, >> >> 2014-12-04 21:00 GMT+01:00 Nicolas Dufresne >>: >>> av_fast_malloc() signature is void*, but this is just a convenience >>> not to have to cast. In fact it expect

Re: [libav-devel] [PATCH] svq1dec: Call av_fast_malloc() correctly

2014-12-05 Thread Vittorio Giovara
On Fri, Dec 5, 2014 at 8:21 AM, Christophe Gisquet wrote: > HuiHi, > > 2014-12-04 21:00 GMT+01:00 Nicolas Dufresne >: >> av_fast_malloc() signature is void*, but this is just a convenience >> not to have to cast. In fact it expect a pointer to pointer. This >> fixes a crash on NULL pointer when pl

Re: [libav-devel] [PATCH] svq1dec: Call av_fast_malloc() correctly

2014-12-05 Thread Christophe Gisquet
HuiHi, 2014-12-04 21:00 GMT+01:00 Nicolas Dufresne : > av_fast_malloc() signature is void*, but this is just a convenience > not to have to cast. In fact it expect a pointer to pointer. This > fixes a crash on NULL pointer when playing back H263 Sorensen. > > Signed-off-by: Nicolas Dufresne > ---

Re: [libav-devel] [PATCH] svq1dec: Call av_fast_malloc() correctly

2014-12-04 Thread Vittorio Giovara
On Thu, Dec 4, 2014 at 8:00 PM, Nicolas Dufresne wrote: > av_fast_malloc() signature is void*, but this is just a convenience > not to have to cast. In fact it expect a pointer to pointer. This > fixes a crash on NULL pointer when playing back H263 Sorensen. > > Signed-off-by: Nicolas Dufresne >

Re: [libav-devel] [PATCH] svq1dec: Call av_fast_malloc() correctly

2014-12-04 Thread Luca Barbato
On 04/12/14 21:00, Nicolas Dufresne wrote: av_fast_malloc() signature is void*, but this is just a convenience not to have to cast. In fact it expect a pointer to pointer. This fixes a crash on NULL pointer when playing back H263 Sorensen. Signed-off-by: Nicolas Dufresne --- libavcodec/svq1de

[libav-devel] [PATCH] svq1dec: Call av_fast_malloc() correctly

2014-12-04 Thread Nicolas Dufresne
av_fast_malloc() signature is void*, but this is just a convenience not to have to cast. In fact it expect a pointer to pointer. This fixes a crash on NULL pointer when playing back H263 Sorensen. Signed-off-by: Nicolas Dufresne --- libavcodec/svq1dec.c | 2 +- 1 file changed, 1 insertion(+), 1