Re: [libav-devel] [PATCH] x86: Refactor PSWAPD fallback implementations and port to cpuflags

2012-11-02 Thread Diego Biurrun
On Fri, Nov 02, 2012 at 04:08:03PM +0100, Diego Biurrun wrote: > On Wed, Aug 01, 2012 at 04:19:56PM -0700, Ronald S. Bultje wrote: > > On Wed, Aug 1, 2012 at 3:55 PM, Diego Biurrun wrote: > > > +%macro PSWAPD 2 > > > +%if cpuflag(mmxext) > > > +pshufw %1, %2, 0x4e > > > > If you change 0x4e t

Re: [libav-devel] [PATCH] x86: Refactor PSWAPD fallback implementations and port to cpuflags

2012-11-02 Thread Diego Biurrun
On Wed, Aug 01, 2012 at 04:19:56PM -0700, Ronald S. Bultje wrote: > On Wed, Aug 1, 2012 at 3:55 PM, Diego Biurrun wrote: > > +%macro PSWAPD 2 > > +%if cpuflag(mmxext) > > +pshufw %1, %2, 0x4e > > If you change 0x4e to q1032, patch is OK with me. You mean 1032q for 1032 as octal number? I'm

Re: [libav-devel] [PATCH] x86: Refactor PSWAPD fallback implementations and port to cpuflags

2012-08-01 Thread Ronald S. Bultje
Hi, On Wed, Aug 1, 2012 at 5:38 PM, Loren Merritt wrote: > On Thu, 2 Aug 2012, Diego Biurrun wrote: >> On Wed, Aug 01, 2012 at 07:41:01AM -0700, Ronald S. Bultje wrote: >>> On Wed, Aug 1, 2012 at 5:30 AM, Diego Biurrun wrote: --- a/libavcodec/x86/fft_mmx.asm +++ b/libavcodec/x86/fft_mm

Re: [libav-devel] [PATCH] x86: Refactor PSWAPD fallback implementations and port to cpuflags

2012-08-01 Thread Loren Merritt
On Thu, 2 Aug 2012, Diego Biurrun wrote: > On Wed, Aug 01, 2012 at 07:41:01AM -0700, Ronald S. Bultje wrote: >> On Wed, Aug 1, 2012 at 5:30 AM, Diego Biurrun wrote: >>> --- a/libavcodec/x86/fft_mmx.asm >>> +++ b/libavcodec/x86/fft_mmx.asm >>> @@ -105,7 +105,8 @@ SECTION_TEXT >>> pxor %3,

Re: [libav-devel] [PATCH] x86: Refactor PSWAPD fallback implementations and port to cpuflags

2012-08-01 Thread Ronald S. Bultje
Hi, On Wed, Aug 1, 2012 at 3:55 PM, Diego Biurrun wrote: > +%macro PSWAPD 2 > +%if cpuflag(mmxext) > +pshufw %1, %2, 0x4e If you change 0x4e to q1032, patch is OK with me. Ronald ___ libav-devel mailing list libav-devel@libav.org https://lists.lib

[libav-devel] [PATCH] x86: Refactor PSWAPD fallback implementations and port to cpuflags

2012-08-01 Thread Diego Biurrun
--- libavcodec/x86/fft_mmx.asm| 16 ++-- libavcodec/x86/fmtconvert.asm | 17 ++--- libavutil/x86/x86util.asm | 12 3 files changed, 16 insertions(+), 29 deletions(-) diff --git a/libavcodec/x86/fft_mmx.asm b/libavcodec/x86/fft_mmx.asm index 7746c

Re: [libav-devel] [PATCH] x86: Refactor PSWAPD fallback implementations and port to cpuflags

2012-08-01 Thread Diego Biurrun
On Wed, Aug 01, 2012 at 10:57:47AM -0700, Ronald S. Bultje wrote: > On Wed, Aug 1, 2012 at 10:53 AM, Diego Biurrun wrote: > > +%macro PSWAPD 2 > > +%if cpuflag(sse) > > +pshufw %1, %2, 0x4e > > As Loren said earlier, this is mmx2, not sse. Rebase screwup, I had this fixed at some point... D

Re: [libav-devel] [PATCH] x86: Refactor PSWAPD fallback implementations and port to cpuflags

2012-08-01 Thread Diego Biurrun
On Wed, Aug 01, 2012 at 07:41:01AM -0700, Ronald S. Bultje wrote: > On Wed, Aug 1, 2012 at 5:30 AM, Diego Biurrun wrote: > > --- a/libavcodec/x86/fft_mmx.asm > > +++ b/libavcodec/x86/fft_mmx.asm > > @@ -105,7 +105,8 @@ SECTION_TEXT > > pxor %3, [ps_m1p1] ; {t8,t7} > > mova %6, %1

Re: [libav-devel] [PATCH] x86: Refactor PSWAPD fallback implementations and port to cpuflags

2012-08-01 Thread Ronald S. Bultje
Hi, On Wed, Aug 1, 2012 at 10:53 AM, Diego Biurrun wrote: > --- a/libavcodec/x86/fft_mmx.asm [..] > -%elifidn %1, %2 > -movd [r0+12], %1 > -punpckhdq %1, [r0+8] > -%else If you remove this macro from this file, the callers with %1==%2 need to use the code directly, or call a different ma

[libav-devel] [PATCH] x86: Refactor PSWAPD fallback implementations and port to cpuflags

2012-08-01 Thread Diego Biurrun
--- libavcodec/x86/fft_mmx.asm| 13 - libavcodec/x86/fmtconvert.asm | 17 ++--- libavutil/x86/x86util.asm | 12 3 files changed, 14 insertions(+), 28 deletions(-) diff --git a/libavcodec/x86/fft_mmx.asm b/libavcodec/x86/fft_mmx.asm index 7746cdd.

Re: [libav-devel] [PATCH] x86: Refactor PSWAPD fallback implementations and port to cpuflags

2012-08-01 Thread Ronald S. Bultje
Hi, On Wed, Aug 1, 2012 at 5:30 AM, Diego Biurrun wrote: > --- > libavcodec/x86/fft_mmx.asm| 19 --- > libavcodec/x86/fmtconvert.asm | 17 ++--- > libavutil/x86/x86util.asm | 12 > 3 files changed, 18 insertions(+), 30 deletions(-) > > diff

[libav-devel] [PATCH] x86: Refactor PSWAPD fallback implementations and port to cpuflags

2012-08-01 Thread Diego Biurrun
--- libavcodec/x86/fft_mmx.asm| 19 --- libavcodec/x86/fmtconvert.asm | 17 ++--- libavutil/x86/x86util.asm | 12 3 files changed, 18 insertions(+), 30 deletions(-) diff --git a/libavcodec/x86/fft_mmx.asm b/libavcodec/x86/fft_mmx.asm index cf