Re: [libav-devel] [PATCH 01/11] aacenc: aac_encode_init() cleanup

2012-01-18 Thread Nathan Caldwell
On Wed, Jan 18, 2012 at 8:09 AM, Diego Biurrun wrote: > On Wed, Jan 18, 2012 at 01:39:48AM -0700, Nathan Caldwell wrote: >> Macroify sanity checks and check return values of allocs and other functions. >> >> --- a/libavcodec/aacenc.c >> +++ b/libavcodec/aacenc.c >> @@ -46,6 +46,12 @@ >> >> +#defin

Re: [libav-devel] [PATCH 01/11] aacenc: aac_encode_init() cleanup

2012-01-18 Thread Diego Biurrun
On Wed, Jan 18, 2012 at 01:39:48AM -0700, Nathan Caldwell wrote: > Macroify sanity checks and check return values of allocs and other functions. > > --- a/libavcodec/aacenc.c > +++ b/libavcodec/aacenc.c > @@ -46,6 +46,12 @@ > > +#define ERROR_IF(cond, ...) \ > +if (cond) { \ > +av_lo

Re: [libav-devel] [PATCH 01/11] aacenc: aac_encode_init() cleanup

2012-01-18 Thread Benjamin Larsson
Change is ok, but it might be possible to squash this with patch 2. MvH Benjamin Larsson ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH 01/11] aacenc: aac_encode_init() cleanup

2012-01-18 Thread Nathan Caldwell
Macroify sanity checks and check return values of allocs and other functions. --- libavcodec/aacenc.c | 119 --- 1 files changed, 75 insertions(+), 44 deletions(-) diff --git a/libavcodec/aacenc.c b/libavcodec/aacenc.c index b112fa8..e119585 100644