Re: [libav-devel] [PATCH 03/17] os_support: Only define lseek/stat/fstat if they are undefined

2014-08-15 Thread Timothy Gu
On Fri, Aug 15, 2014 at 1:54 PM, Timothy Gu wrote: > Just undef it first if it is defined. See https://github.com/FFmpeg/FFmpeg/commit/ef122ff5072463366c020157f0a27aad7e6610db for example. Timothy ___ libav-devel mailing list libav-devel@libav.org ht

Re: [libav-devel] [PATCH 03/17] os_support: Only define lseek/stat/fstat if they are undefined

2014-08-15 Thread Timothy Gu
On Fri, Aug 15, 2014 at 1:13 PM, Diego Biurrun wrote: > This avoids a number of redefinition warnings on MinGW64. > --- > > I'm assuming that they are not defined to anything silly, which I > hope is safe to do. It's not safe at all. > > libavformat/os_support.h | 6 ++ > 1 file changed, 6

Re: [libav-devel] [PATCH 03/17] os_support: Only define lseek/stat/fstat if they are undefined

2014-08-15 Thread Jean-Baptiste Kempf
On 15 Aug, Diego Biurrun wrote : > This avoids a number of redefinition warnings on MinGW64. > --- > > I'm assuming that they are not defined to anything silly, which I > hope is safe to do. >From experience, it's not safe. I would always undef and redef. -- Jean-Baptiste Kempf http://www.jbke

[libav-devel] [PATCH 03/17] os_support: Only define lseek/stat/fstat if they are undefined

2014-08-15 Thread Diego Biurrun
This avoids a number of redefinition warnings on MinGW64. --- I'm assuming that they are not defined to anything silly, which I hope is safe to do. libavformat/os_support.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/os_support.h b/libavformat/os_support.h index 94cb0d3