Re: [libav-devel] [PATCH 09/10] mxfdec: Only parse next partition pack if parsing forward

2012-07-10 Thread Luca Barbato
On 07/10/2012 07:33 PM, Tomas Härdin wrote: > I'll just note that I don't know that much about mxfenc. While you're at > it you might want to cherry-pick the DNxHD and DV patches from FFmpeg > (there's a couple in the works, so I'd wait a day or two). Point me what you deem useful and if I can get

Re: [libav-devel] [PATCH 09/10] mxfdec: Only parse next partition pack if parsing forward

2012-07-10 Thread Tomas Härdin
On Tue, 2012-07-10 at 17:44 +0200, Luca Barbato wrote: > On 07/10/2012 04:19 PM, Tomas Härdin wrote: > > The backward parsing is due to PartitionPack not having any offset to > > the *next* partition - only the previous one (PreviousPartition). Since > > we don't want to parse the essence and in ge

Re: [libav-devel] [PATCH 09/10] mxfdec: Only parse next partition pack if parsing forward

2012-07-10 Thread Luca Barbato
On 07/10/2012 04:19 PM, Tomas Härdin wrote: > The backward parsing is due to PartitionPack not having any offset to > the *next* partition - only the previous one (PreviousPartition). Since > we don't want to parse the essence and in general can't skip over it (if > it's frame wrapped, like OP1a),

Re: [libav-devel] [PATCH 09/10] mxfdec: Only parse next partition pack if parsing forward

2012-07-10 Thread Tomas Härdin
On Tue, 2012-07-10 at 13:03 +0200, Luca Barbato wrote: > On 07/10/2012 11:59 AM, Diego Biurrun wrote: > > On Tue, Jul 10, 2012 at 05:16:06AM +0200, Luca Barbato wrote: > >> > >> --- a/libavformat/mxfdec.c > >> +++ b/libavformat/mxfdec.c > >> @@ -1873,6 +1873,9 @@ static int mxf_read_header(AVFormat

Re: [libav-devel] [PATCH 09/10] mxfdec: Only parse next partition pack if parsing forward

2012-07-10 Thread Luca Barbato
On 07/10/2012 11:59 AM, Diego Biurrun wrote: > On Tue, Jul 10, 2012 at 05:16:06AM +0200, Luca Barbato wrote: >> >> --- a/libavformat/mxfdec.c >> +++ b/libavformat/mxfdec.c >> @@ -1873,6 +1873,9 @@ static int mxf_read_header(AVFormatContext *s) >> /* next partition pack - keep going, se

Re: [libav-devel] [PATCH 09/10] mxfdec: Only parse next partition pack if parsing forward

2012-07-10 Thread Diego Biurrun
On Tue, Jul 10, 2012 at 05:16:06AM +0200, Luca Barbato wrote: > > --- a/libavformat/mxfdec.c > +++ b/libavformat/mxfdec.c > @@ -1873,6 +1873,9 @@ static int mxf_read_header(AVFormatContext *s) > /* next partition pack - keep going, seek to previous partition > or stop */ >

Re: [libav-devel] [PATCH 09/10] mxfdec: Only parse next partition pack if parsing forward

2012-07-10 Thread Benjamin Larsson
LGTM ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH 09/10] mxfdec: Only parse next partition pack if parsing forward

2012-07-09 Thread Luca Barbato
From: Tomas Härdin Signed-off-by: Michael Niedermayer Signed-off-by: Luca Barbato --- libavformat/mxfdec.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 91015a9..3c1a47d 100644 --- a/libavformat/mxfdec.c +++ b/libav