Re: [libav-devel] [PATCH 1/1] arm: call arm-specific rv34dsp init functions under if (ARCH_ARM)

2012-10-10 Thread Måns Rullgård
Måns Rullgård writes: > Janne Grunau writes: > >> +void ff_rv40dsp_init_arm(RV34DSPContext *c, DSPContext* dsp) >> +{ >> +#if HAVE_NEON >> +int cpu_flags = av_get_cpu_flags(); >> + >> +if (have_neon(cpu_flags)) >> +ff_rv40dsp_init_neon(c); >> +#endif /* HAVE_NEON */ >> +} > > You

Re: [libav-devel] [PATCH 1/1] arm: call arm-specific rv34dsp init functions under if (ARCH_ARM)

2012-10-10 Thread Måns Rullgård
Janne Grunau writes: > +void ff_rv40dsp_init_arm(RV34DSPContext *c, DSPContext* dsp) > +{ > +#if HAVE_NEON > +int cpu_flags = av_get_cpu_flags(); > + > +if (have_neon(cpu_flags)) > +ff_rv40dsp_init_neon(c); > +#endif /* HAVE_NEON */ > +} You don't need the #if here. -- Måns Rul

[libav-devel] [PATCH 1/1] arm: call arm-specific rv34dsp init functions under if (ARCH_ARM)

2012-10-10 Thread Janne Grunau
From: Jean-Baptiste Kempf Assign NEON specific function pointers after runtime check via av_get_cpu_flags(). Signed-off-by: Janne Grunau --- libavcodec/arm/Makefile | 12 ++-- .../arm/{rv34dsp_init_neon.c => rv34dsp_init_arm.c} | 15 ++-

Re: [libav-devel] [PATCH 1/1] arm: call arm-specific rv34dsp init functions under if (ARCH_ARM)

2012-10-10 Thread Måns Rullgård
Janne Grunau writes: > On 2012-10-10 11:54:11 +0100, Måns Rullgård wrote: >> Janne Grunau writes: >> >> > -void ff_rv40dsp_init_neon(RV34DSPContext *c, DSPContext* dsp) >> > +static void ff_rv40dsp_init_neon(RV34DSPContext *c) >> > { >> > c->put_pixels_tab[0][ 1] = ff_put_rv40_qpel16_mc10

Re: [libav-devel] [PATCH 1/1] arm: call arm-specific rv34dsp init functions under if (ARCH_ARM)

2012-10-10 Thread Janne Grunau
On 2012-10-10 11:54:11 +0100, Måns Rullgård wrote: > Janne Grunau writes: > > > -void ff_rv40dsp_init_neon(RV34DSPContext *c, DSPContext* dsp) > > +static void ff_rv40dsp_init_neon(RV34DSPContext *c) > > { > > c->put_pixels_tab[0][ 1] = ff_put_rv40_qpel16_mc10_neon; > > c->put_pixels_t

Re: [libav-devel] [PATCH 1/1] arm: call arm-specific rv34dsp init functions under if (ARCH_ARM)

2012-10-10 Thread Måns Rullgård
Janne Grunau writes: > -void ff_rv40dsp_init_neon(RV34DSPContext *c, DSPContext* dsp) > +static void ff_rv40dsp_init_neon(RV34DSPContext *c) > { > c->put_pixels_tab[0][ 1] = ff_put_rv40_qpel16_mc10_neon; > c->put_pixels_tab[0][ 3] = ff_put_rv40_qpel16_mc30_neon; > @@ -136,3 +137,11 @@

[libav-devel] [PATCH 1/1] arm: call arm-specific rv34dsp init functions under if (ARCH_ARM)

2012-10-05 Thread Janne Grunau
From: Jean-Baptiste Kempf Assign NEON specific function pointers after runtime check via av_get_cpu_flags(). Signed-off-by: Janne Grunau --- rv*dsp init stuff still looks weird after this due to use of its own DSP context and the general dsputil context. It copies then function pointers from th