Re: [libav-devel] [PATCH 1/1] remove #defines to prevent use of discouraged external functions

2012-11-15 Thread Måns Rullgård
Janne Grunau writes: > On 2012-10-26 20:46:29 +0200, Janne Grunau wrote: >> Preventing the use of discouraged or 'insecure' external functions >> through defines in an internal header is not a good solution. The >> header is not guaranteed to be included universally which makes >> overlooking bad

Re: [libav-devel] [PATCH 1/1] remove #defines to prevent use of discouraged external functions

2012-11-15 Thread Janne Grunau
On 2012-10-26 20:46:29 +0200, Janne Grunau wrote: > Preventing the use of discouraged or 'insecure' external functions > through defines in an internal header is not a good solution. The > header is not guaranteed to be included universally which makes > overlooking bad use of said functions during

Re: [libav-devel] [PATCH 1/1] remove #defines to prevent use of discouraged external functions

2012-10-26 Thread Luca Barbato
On 10/26/2012 09:07 PM, Måns Rullgård wrote: > Diego Elio Pettenò writes: > >> On 26/10/2012 11:52, Luca Barbato wrote: >>> Fine for me, in case we might add some grep to find functions that could >>> be dangerous. >> >> If I'm not mistaken there should be a way to inject the warnings at link >>

Re: [libav-devel] [PATCH 1/1] remove #defines to prevent use of discouraged external functions

2012-10-26 Thread Diego Elio Pettenò
On 26/10/2012 12:07, Måns Rullgård wrote: > That would be just as wrong. There are legitimate uses for most of > these functions. I'd still prefer that to grepping the sources. For me it's fine to not keep the warnings around at all. -- Diego Elio Pettenò — Flameeyes flamee...@flameeyes.eu — h

Re: [libav-devel] [PATCH 1/1] remove #defines to prevent use of discouraged external functions

2012-10-26 Thread Måns Rullgård
Diego Elio Pettenò writes: > On 26/10/2012 11:52, Luca Barbato wrote: >> Fine for me, in case we might add some grep to find functions that could >> be dangerous. > > If I'm not mistaken there should be a way to inject the warnings at link > time. > > Although it's easier to just nm/elfgrep the f

Re: [libav-devel] [PATCH 1/1] remove #defines to prevent use of discouraged external functions

2012-10-26 Thread Diego Elio Pettenò
On 26/10/2012 11:52, Luca Barbato wrote: > Fine for me, in case we might add some grep to find functions that could > be dangerous. If I'm not mistaken there should be a way to inject the warnings at link time. Although it's easier to just nm/elfgrep the final targets. -- Diego Elio Pettenò — F

Re: [libav-devel] [PATCH 1/1] remove #defines to prevent use of discouraged external functions

2012-10-26 Thread Luca Barbato
On 10/26/2012 08:46 PM, Janne Grunau wrote: > Preventing the use of discouraged or 'insecure' external functions > through defines in an internal header is not a good solution. The > header is not guaranteed to be included universally which makes > overlooking bad use of said functions during revie

Re: [libav-devel] [PATCH 1/1] remove #defines to prevent use of discouraged external functions

2012-10-26 Thread Måns Rullgård
Janne Grunau writes: > Preventing the use of discouraged or 'insecure' external functions > through defines in an internal header is not a good solution. The > header is not guaranteed to be included universally which makes > overlooking bad use of said functions during review more likely. > > Th

[libav-devel] [PATCH 1/1] remove #defines to prevent use of discouraged external functions

2012-10-26 Thread Janne Grunau
Preventing the use of discouraged or 'insecure' external functions through defines in an internal header is not a good solution. The header is not guaranteed to be included universally which makes overlooking bad use of said functions during review more likely. There are cases were those functions