[libav-devel] [PATCH 1/2] (WIP) rtmp: Add message tracking

2012-08-02 Thread Samuel Pitoiset
--- libavformat/rtmpproto.c | 286 1 file changed, 169 insertions(+), 117 deletions(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index 4a35319..1341cd7 100644 --- a/libavformat/rtmpproto.c +++ b/libavformat/rtmpproto.c @@ -52,1

Re: [libav-devel] [PATCH 1/2] (WIP) rtmp: Add message tracking

2012-08-02 Thread Luca Barbato
On 08/01/2012 12:12 PM, Samuel Pitoiset wrote: > --- > libavformat/rtmpproto.c | 278 > > 1 file changed, 161 insertions(+), 117 deletions(-) > +free_tracked_methods(rt); It is still wrong, check what librtmp does. you cannot keep storing met

Re: [libav-devel] [PATCH 1/2] (WIP) rtmp: Add message tracking

2012-08-01 Thread Luca Barbato
On 01/08/12 12:12, Samuel Pitoiset wrote: > --- > libavformat/rtmpproto.c | 278 > > 1 file changed, 161 insertions(+), 117 deletions(-) Seems better. Let me try it. ___ libav-devel mailing list libav-de

[libav-devel] [PATCH 1/2] (WIP) rtmp: Add message tracking

2012-08-01 Thread Samuel Pitoiset
--- libavformat/rtmpproto.c | 278 1 file changed, 161 insertions(+), 117 deletions(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index 4a35319..6044425 100644 --- a/libavformat/rtmpproto.c +++ b/libavformat/rtmpproto.c @@ -52,1

Re: [libav-devel] [PATCH 1/2] (WIP) rtmp: Add message tracking

2012-08-01 Thread Samuel Pitoiset
On Tue, Jul 31, 2012 at 9:22 PM, Luca Barbato wrote: > On 07/31/2012 06:16 PM, Samuel Pitoiset wrote: >> +if ((ret = find_tracked_method(rt, pkt_id, &tracked_method)) < 0) { >> +/* Ignore this reply when the method is not tracked. */ >> +return 0; >> +} > >

Re: [libav-devel] [PATCH 1/2] (WIP) rtmp: Add message tracking

2012-07-31 Thread Luca Barbato
On 07/31/2012 06:16 PM, Samuel Pitoiset wrote: > +if ((ret = find_tracked_method(rt, pkt_id, &tracked_method)) < 0) { > +/* Ignore this reply when the method is not tracked. */ > +return 0; > +} Might be better return < 0 on error 0 on success > 0 on not pr

[libav-devel] [PATCH 1/2] (WIP) rtmp: Add message tracking

2012-07-31 Thread Samuel Pitoiset
--- libavformat/rtmpproto.c | 278 1 file changed, 161 insertions(+), 117 deletions(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index 4a35319..7a00b92 100644 --- a/libavformat/rtmpproto.c +++ b/libavformat/rtmpproto.c @@ -52,1