Re: [libav-devel] [PATCH 1/2] Add a protocol handler for AES CBC decryption with PKCS7 padding

2011-04-22 Thread Martin Storsjö
On Wed, 20 Apr 2011, Anton Khirnov wrote: > This could use more verbosity, especially if it'll be visible to users > later on. > > Otherwise looks fine to me. Since both patches had gotten ok's now - pushed. // Martin ___ libav-devel mailing list liba

[libav-devel] [PATCH 1/2] Add a protocol handler for AES CBC decryption with PKCS7 padding

2011-04-20 Thread Martin Storsjö
This can later be extended to support other AES bit sizes, encryption, other crypto algorithms, reading the key from a URL, etc. In order to use it, the key and initialization vector has to be passed via AVOptions. Since such options can't be passed to protocols from the command line, the protocol

Re: [libav-devel] [PATCH 1/2] Add a protocol handler for AES CBC decryption with PKCS7 padding

2011-04-20 Thread Anton Khirnov
On Wed, 20 Apr 2011 16:27:58 +0300, Martin Storsjö wrote: > This can later be extended to support other AES bit sizes, > encryption, other crypto algorithms, reading the key from a URL, etc. > > In order to use it, the key and initialization vector has to be > passed via AVOptions. Since such opt

[libav-devel] [PATCH 1/2] Add a protocol handler for AES CBC decryption with PKCS7 padding

2011-04-20 Thread Martin Storsjö
This can later be extended to support other AES bit sizes, encryption, other crypto algorithms, reading the key from a URL, etc. In order to use it, the key and initialization vector has to be passed via AVOptions. Since such options can't be passed to protocols from the command line, the protocol

[libav-devel] [PATCH 1/2] Add a protocol handler for AES CBC decryption with PKCS7 padding

2011-04-12 Thread Martin Storsjö
This can later be extended to support other AES bit sizes, encryption, other crypto algorithms, reading the key from a URL, etc. In order to use it, the key and initialization vector has to be passed via AVOptions. Since such options can't be passed to protocols from the command line, the protocol

Re: [libav-devel] [PATCH 1/2] Add a protocol handler for AES CBC decryption with PKCS7 padding

2011-04-12 Thread Martin Storsjö
On Tue, 12 Apr 2011, Diego Biurrun wrote: > On Tue, Apr 12, 2011 at 11:08:13AM +0300, Martin Storsjö wrote: > > This can later be extended to support other AES bit sizes, > > encryption, other crypto algorithms, reading the key from a URL, etc. > > > > --- /dev/null > > +++ b/libavformat/crypto.c

Re: [libav-devel] [PATCH 1/2] Add a protocol handler for AES CBC decryption with PKCS7 padding

2011-04-12 Thread Diego Biurrun
On Tue, Apr 12, 2011 at 11:08:13AM +0300, Martin Storsjö wrote: > This can later be extended to support other AES bit sizes, > encryption, other crypto algorithms, reading the key from a URL, etc. > > --- /dev/null > +++ b/libavformat/crypto.c > @@ -0,0 +1,170 @@ > +/* > + * Decryption protocol ha

[libav-devel] [PATCH 1/2] Add a protocol handler for AES CBC decryption with PKCS7 padding

2011-04-12 Thread Martin Storsjö
This can later be extended to support other AES bit sizes, encryption, other crypto algorithms, reading the key from a URL, etc. In order to use it, the key and initialization vector has to be passed via AVOptions. Since such options can't be passed to protocols from the command line, the protocol