Re: [libav-devel] [PATCH 1/2] Add colorspace flags to AVPixFmtDescriptor

2011-07-13 Thread Stefano Sabatini
On date Wednesday 2011-07-13 01:14:44 +0800, Fredrik Mellbin encoded: > Adding colorspace flags to AVPixFmtDescriptor will allow many similar > collections of attributes spread around the codebase to be removed. > > --- > libavutil/pixdesc.c | 55 +---

Re: [libav-devel] [PATCH 1/2] Add colorspace flags to AVPixFmtDescriptor

2011-07-13 Thread Ronald S. Bultje
Hi, On Tue, Jul 12, 2011 at 10:14 AM, Fredrik Mellbin wrote: > +#define PIX_FMT_YUV         0x00 > +#define PIX_FMT_GRAY        0x20 > +#define PIX_FMT_RGB         0x40 > +#define PIX_FMT_BGR         0x60 I don't think this will work. These are not flag values (in the 1 << x range). Ronald

[libav-devel] [PATCH 1/2] Add colorspace flags to AVPixFmtDescriptor

2011-07-13 Thread Fredrik Mellbin
Adding colorspace flags to AVPixFmtDescriptor will allow many similar collections of attributes spread around the codebase to be removed. --- libavutil/pixdesc.c | 55 +- libavutil/pixdesc.h |9 2 files changed, 45 insertions(+), 19 d