Re: [libav-devel] [PATCH 1/2] build: support non-standard replacements for -E flag

2012-07-23 Thread Måns Rullgård
"Ronald S. Bultje" writes: > Hi, > > On Sun, Jul 22, 2012 at 5:35 PM, Måns Rullgård wrote: >> Diego Biurrun writes: >> >>> On Mon, Jul 23, 2012 at 01:16:07AM +0100, Måns Rullgård wrote: Diego Biurrun writes: > On Mon, Jul 23, 2012 at 12:16:41AM +0100, Mans Rullgard wrote: >

Re: [libav-devel] [PATCH 1/2] build: support non-standard replacements for -E flag

2012-07-23 Thread Diego Biurrun
On Mon, Jul 23, 2012 at 01:35:06AM +0100, Måns Rullgård wrote: > Diego Biurrun writes: > > On Mon, Jul 23, 2012 at 01:16:07AM +0100, Måns Rullgård wrote: > >> Diego Biurrun writes: > >> > On Mon, Jul 23, 2012 at 12:16:41AM +0100, Mans Rullgard wrote: > >> >> This allows using non-standard flags f

Re: [libav-devel] [PATCH 1/2] build: support non-standard replacements for -E flag

2012-07-22 Thread Ronald S. Bultje
Hi, On Sun, Jul 22, 2012 at 5:35 PM, Måns Rullgård wrote: > Diego Biurrun writes: > >> On Mon, Jul 23, 2012 at 01:16:07AM +0100, Måns Rullgård wrote: >>> Diego Biurrun writes: >>> >>> > On Mon, Jul 23, 2012 at 12:16:41AM +0100, Mans Rullgard wrote: >>> >> This allows using non-standard flags fo

Re: [libav-devel] [PATCH 1/2] build: support non-standard replacements for -E flag

2012-07-22 Thread Måns Rullgård
Diego Biurrun writes: > On Mon, Jul 23, 2012 at 01:16:07AM +0100, Måns Rullgård wrote: >> Diego Biurrun writes: >> >> > On Mon, Jul 23, 2012 at 12:16:41AM +0100, Mans Rullgard wrote: >> >> This allows using non-standard flags for running the C preprocessor. >> >> The -o flag must be included in

Re: [libav-devel] [PATCH 1/2] build: support non-standard replacements for -E flag

2012-07-22 Thread Diego Biurrun
On Mon, Jul 23, 2012 at 01:16:07AM +0100, Måns Rullgård wrote: > Diego Biurrun writes: > > > On Mon, Jul 23, 2012 at 12:16:41AM +0100, Mans Rullgard wrote: > >> This allows using non-standard flags for running the C preprocessor. > >> The -o flag must be included in this setting due to strange sy

Re: [libav-devel] [PATCH 1/2] build: support non-standard replacements for -E flag

2012-07-22 Thread Måns Rullgård
Diego Biurrun writes: > On Mon, Jul 23, 2012 at 12:16:41AM +0100, Mans Rullgard wrote: >> This allows using non-standard flags for running the C preprocessor. >> The -o flag must be included in this setting due to strange syntax >> required by some compilers. >> >> --- a/configure >> +++ b/confi

Re: [libav-devel] [PATCH 1/2] build: support non-standard replacements for -E flag

2012-07-22 Thread Diego Biurrun
On Mon, Jul 23, 2012 at 12:16:41AM +0100, Mans Rullgard wrote: > This allows using non-standard flags for running the C preprocessor. > The -o flag must be included in this setting due to strange syntax > required by some compilers. > > --- a/configure > +++ b/configure > @@ -621,6 +621,10 @@ cc_o

Re: [libav-devel] [PATCH 1/2] build: support non-standard replacements for -E flag

2012-07-22 Thread Derek Buitenhuis
On 22/07/2012 7:54 PM, Måns Rullgård wrote: > Same reason as cc_o. For both of these variables, the value will > contain $@ which make expands to the target being built. In the shell, > $@ expands to all arguments of the script/function. Passing the > filename as argument to a function and, with

Re: [libav-devel] [PATCH 1/2] build: support non-standard replacements for -E flag

2012-07-22 Thread Måns Rullgård
Derek Buitenhuis writes: > On 22/07/2012 7:39 PM, Måns Rullgård wrote: +cc_e(){ >> +eval printf '%s\\n' $CC_E >> +} >>> > >>> > I'm probably ignorant here, but why is this needed? >> Why is what needed? > > cc_e(). Something preventing using $CC_E directly (I'm sure there is).

Re: [libav-devel] [PATCH 1/2] build: support non-standard replacements for -E flag

2012-07-22 Thread Derek Buitenhuis
On 22/07/2012 7:39 PM, Måns Rullgård wrote: >>> +cc_e(){ >>> >> +eval printf '%s\\n' $CC_E >>> >> +} >> > >> > I'm probably ignorant here, but why is this needed? > Why is what needed? cc_e(). Something preventing using $CC_E directly (I'm sure there is). - Derek _

Re: [libav-devel] [PATCH 1/2] build: support non-standard replacements for -E flag

2012-07-22 Thread Måns Rullgård
Derek Buitenhuis writes: > On 22/07/2012 7:16 PM, Mans Rullgard wrote: >> This allows using non-standard flags for running the C preprocessor. >> The -o flag must be included in this setting due to strange syntax >> required by some compilers. >> >> Set the correct flags for tms470. >> >> Signe

Re: [libav-devel] [PATCH 1/2] build: support non-standard replacements for -E flag

2012-07-22 Thread Derek Buitenhuis
On 22/07/2012 7:16 PM, Mans Rullgard wrote: > This allows using non-standard flags for running the C preprocessor. > The -o flag must be included in this setting due to strange syntax > required by some compilers. > > Set the correct flags for tms470. > > Signed-off-by: Mans Rullgard > --- > co

[libav-devel] [PATCH 1/2] build: support non-standard replacements for -E flag

2012-07-22 Thread Mans Rullgard
This allows using non-standard flags for running the C preprocessor. The -o flag must be included in this setting due to strange syntax required by some compilers. Set the correct flags for tms470. Signed-off-by: Mans Rullgard --- configure | 12 ++-- 1 file changed, 10 insertions(+), 2