On 07/05/2018 12:46, Li, Zhong wrote:
> Thanks for review. : )
No problem :)
> Do you need me to update it, or you can help to add the alias when you merge
> it?
>
+{ "on" , NULL, 0, AV_OPT_TYPE_CONST, { .i64 = MFX_MF_MANUAL },
INT_MIN, INT_MAX, VE, "mfmode" },
Folded in, I'd push
v.org
> Subject: Re: [libav-devel] [PATCH 1/2] lavc/qsvenc: add detail options for
> MFE mode
>
> The set looks fine, I would add a alias for "on" as "manual" for usability but
> beside that looks fine to me.
> _
The set looks fine, I would add a alias for "on" as "manual" for
usability but beside that looks fine to me.
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
Not convenient if using numerals to set MFE mode. It is ambiguous
and misleading (e.g: user may misunderstand setting mfmode to 1 is to
enable MFE but actually it is to disable MFE, and set it to be 5 or above is
meaningless).
Signed-off-by: Zhong Li
---
libavcodec/qsvenc_h264.c | 6 +-
1 f
