Re: [libav-devel] [PATCH 1/2] vp56: make parse_header return standard error codes

2012-12-14 Thread Luca Barbato
On 12/14/2012 02:44 PM, Diego Biurrun wrote: > On Fri, Dec 14, 2012 at 09:59:14AM +0100, Luca Barbato wrote: >> --- a/libavcodec/vp5.c >> +++ b/libavcodec/vp5.c >> @@ -49,18 +49,18 @@ static int vp5_parse_header(VP56Context *s, const >> uint8_t *buf, int buf_size, >> if (vp56_rac_get(c))

Re: [libav-devel] [PATCH 1/2] vp56: make parse_header return standard error codes

2012-12-14 Thread Diego Biurrun
On Fri, Dec 14, 2012 at 09:59:14AM +0100, Luca Barbato wrote: > --- a/libavcodec/vp5.c > +++ b/libavcodec/vp5.c > @@ -49,18 +49,18 @@ static int vp5_parse_header(VP56Context *s, const uint8_t > *buf, int buf_size, > if (vp56_rac_get(c)) { > av_log(s->avctx, AV_LOG_ERROR, "int

[libav-devel] [PATCH 1/2] vp56: make parse_header return standard error codes

2012-12-14 Thread Luca Barbato
Returning 0 for failure is misleading. CC: libav-sta...@libav.org --- libavcodec/vp5.c | 12 ++-- libavcodec/vp56.c | 8 libavcodec/vp56.h | 2 ++ libavcodec/vp6.c | 12 ++-- 4 files changed, 18 insertions(+), 16 deletions(-) diff --git a/libavcodec/vp5.c b/libavcode