Re: [libav-devel] [PATCH 1/3] avconv: expand AVRational literals.

2012-07-29 Thread Måns Rullgård
Ronald S. Bultje rsbul...@gmail.com writes: From: Ronald S. Bultje rsbul...@gmail.com This way, the code looks less like spaghetti, and is easier to parse for external preprocessors. --- avconv.c | 44 1 file changed, 28 insertions(+), 16

Re: [libav-devel] [PATCH 1/3] avconv: expand AVRational literals.

2012-07-29 Thread Måns Rullgård
Anton Khirnov an...@khirnov.net writes: On Sun, 29 Jul 2012 05:27:57 +0200, Luca Barbato lu_z...@gentoo.org wrote: On 07/29/2012 05:10 AM, Ronald S. Bultje wrote: From: Ronald S. Bultje rsbul...@gmail.com This way, the code looks less like spaghetti, and is easier to parse for external

Re: [libav-devel] [PATCH 1/3] avconv: expand AVRational literals.

2012-07-29 Thread Ronald S. Bultje
Hi, On Sun, Jul 29, 2012 at 2:29 AM, Måns Rullgård m...@mansr.com wrote: @@ -2479,11 +2480,14 @@ static int transcode_init(void) codec-height = icodec-height; codec-has_b_frames = icodec-has_b_frames; if

Re: [libav-devel] [PATCH 1/3] avconv: expand AVRational literals.

2012-07-29 Thread Måns Rullgård
Ronald S. Bultje rsbul...@gmail.com writes: Hi, On Sun, Jul 29, 2012 at 2:29 AM, Måns Rullgård m...@mansr.com wrote: @@ -2479,11 +2480,14 @@ static int transcode_init(void) codec-height = icodec-height; codec-has_b_frames =

Re: [libav-devel] [PATCH 1/3] avconv: expand AVRational literals.

2012-07-29 Thread Luca Barbato
On 07/29/2012 05:34 PM, Ronald S. Bultje wrote: My preprocessor can handle literals, although barely. Without having a fullblown compiler available, it's limited to how much special-case crap I'm adding to it. Easy things to handle: x = (AVRational){y,z}; return (AVRational){y,z};

[libav-devel] [PATCH 1/3] avconv: expand AVRational literals.

2012-07-28 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com This way, the code looks less like spaghetti, and is easier to parse for external preprocessors. --- avconv.c | 44 1 file changed, 28 insertions(+), 16 deletions(-) diff --git a/avconv.c b/avconv.c index

Re: [libav-devel] [PATCH 1/3] avconv: expand AVRational literals.

2012-07-28 Thread Luca Barbato
On 07/29/2012 05:10 AM, Ronald S. Bultje wrote: From: Ronald S. Bultje rsbul...@gmail.com This way, the code looks less like spaghetti, and is easier to parse for external preprocessors. Maybe something along the lines avconv: convert ternary statements to normal conditional blocks The

Re: [libav-devel] [PATCH 1/3] avconv: expand AVRational literals.

2012-07-28 Thread Anton Khirnov
On Sun, 29 Jul 2012 05:27:57 +0200, Luca Barbato lu_z...@gentoo.org wrote: On 07/29/2012 05:10 AM, Ronald S. Bultje wrote: From: Ronald S. Bultje rsbul...@gmail.com This way, the code looks less like spaghetti, and is easier to parse for external preprocessors. Maybe something along