Re: [libav-devel] [PATCH 1/3] ffv1: split decoder and encoder

2012-10-20 Thread Kostya Shishkov
On Fri, Oct 19, 2012 at 09:55:40PM +0200, Luca Barbato wrote: --- libavcodec/Makefile |4 +- libavcodec/ffv1.c| 1612 +- libavcodec/ffv1.h| 184 ++ libavcodec/ffv1dec.c | 636 libavcodec/ffv1enc.c |

Re: [libav-devel] [PATCH 1/3] ffv1: split decoder and encoder

2012-10-19 Thread Kostya Shishkov
On Fri, Oct 19, 2012 at 12:16:33PM +0200, Luca Barbato wrote: --- libavcodec/Makefile |4 +- libavcodec/ffv1.c| 1612 +- libavcodec/ffv1.h| 184 ++ libavcodec/ffv1dec.c | 636 libavcodec/ffv1enc.c |

Re: [libav-devel] [PATCH 1/3] ffv1: split decoder and encoder

2012-10-19 Thread Luca Barbato
On 10/19/2012 03:29 PM, Kostya Shishkov wrote: -static const int8_t quant5_10bit[256] = { +const int8_t quant5_10bit[256] = { don't we have to prefix such names? We hide everything not matching av_/avpriv_ lu ___ libav-devel mailing list

Re: [libav-devel] [PATCH 1/3] ffv1: split decoder and encoder

2012-10-19 Thread Måns Rullgård
Luca Barbato lu_z...@gentoo.org writes: On 10/19/2012 03:29 PM, Kostya Shishkov wrote: -static const int8_t quant5_10bit[256] = { +const int8_t quant5_10bit[256] = { don't we have to prefix such names? We hide everything not matching av_/avpriv_ That only works in shared libs. Add a