Re: [libav-devel] [PATCH 1/3 v2] avutil/spherical: add functions to retrieve and request projection names

2017-04-17 Thread Luca Barbato
On 10/04/2017 22:31, Vittorio Giovara wrote: > On Mon, Apr 10, 2017 at 1:43 PM, James Almer wrote: >>> Even so, what's the user going to do with knowing the fact that >>> the video contains spherical metadata it can't parse correctly/fully >>> support? So, I'm hesitant to add a

Re: [libav-devel] [PATCH 1/3 v2] avutil/spherical: add functions to retrieve and request projection names

2017-04-10 Thread Vittorio Giovara
On Mon, Apr 10, 2017 at 1:43 PM, James Almer wrote: >> Even so, what's the user going to do with knowing the fact that >> the video contains spherical metadata it can't parse correctly/fully >> support? So, I'm hesitant to add a new type for this uncertain >> behaviour,

Re: [libav-devel] [PATCH 1/3 v2] avutil/spherical: add functions to retrieve and request projection names

2017-04-10 Thread James Almer
On 4/10/2017 1:20 PM, Vittorio Giovara wrote: > On Mon, Apr 10, 2017 at 11:49 AM, James Almer wrote: >>> In my opinion it would be enough to return int and >>> just AVERROR(EINVAL) in case it's not found. James would you be ok >>> with that, or do you have any preference? >> >>

Re: [libav-devel] [PATCH 1/3 v2] avutil/spherical: add functions to retrieve and request projection names

2017-04-10 Thread Vittorio Giovara
On Mon, Apr 10, 2017 at 11:49 AM, James Almer wrote: >> In my opinion it would be enough to return int and >> just AVERROR(EINVAL) in case it's not found. James would you be ok >> with that, or do you have any preference? > > IMO, PROJECTION_UNKNOWN is an interesting addition.

Re: [libav-devel] [PATCH 1/3 v2] avutil/spherical: add functions to retrieve and request projection names

2017-04-10 Thread James Almer
On 4/10/2017 10:56 AM, Vittorio Giovara wrote: > On Fri, Apr 7, 2017 at 10:22 AM, Luca Barbato wrote: >> On 07/04/2017 16:09, James Almer wrote: >>> +int av_spherical_from_name(const char *name); >> >> It can directly output the enum now, it is fine both ways to me. > > Wait

Re: [libav-devel] [PATCH 1/3 v2] avutil/spherical: add functions to retrieve and request projection names

2017-04-10 Thread Luca Barbato
On 10/04/2017 15:56, Vittorio Giovara wrote: > On Fri, Apr 7, 2017 at 10:22 AM, Luca Barbato wrote: >> On 07/04/2017 16:09, James Almer wrote: >>> +int av_spherical_from_name(const char *name); >> >> It can directly output the enum now, it is fine both ways to me. > > Wait a

Re: [libav-devel] [PATCH 1/3 v2] avutil/spherical: add functions to retrieve and request projection names

2017-04-10 Thread Vittorio Giovara
On Fri, Apr 7, 2017 at 10:22 AM, Luca Barbato wrote: > On 07/04/2017 16:09, James Almer wrote: >> +int av_spherical_from_name(const char *name); > > It can directly output the enum now, it is fine both ways to me. Wait a minute, I don't think PROJECTION_UNKNOWN makes much

Re: [libav-devel] [PATCH 1/3 v2] avutil/spherical: add functions to retrieve and request projection names

2017-04-07 Thread Luca Barbato
On 07/04/2017 16:09, James Almer wrote: > +int av_spherical_from_name(const char *name); It can directly output the enum now, it is fine both ways to me. Thank you for amending it :) lu ___ libav-devel mailing list libav-devel@libav.org

[libav-devel] [PATCH 1/3 v2] avutil/spherical: add functions to retrieve and request projection names

2017-04-07 Thread James Almer
Signed-off-by: James Almer --- doc/APIchanges| 4 libavutil/spherical.c | 28 libavutil/spherical.h | 24 libavutil/version.h | 2 +- 4 files changed, 57 insertions(+), 1 deletion(-) diff --git