Re: [libav-devel] [PATCH 1/4] x86: ff_get_cpu_flags_x86(): Avoid a pointless variable indirection

2012-10-04 Thread Sean McGovern
On Thu, Oct 4, 2012 at 6:14 AM, Måns Rullgård wrote: > Diego Biurrun writes: > >> On Wed, Oct 03, 2012 at 10:11:37PM -0400, Sean McGovern wrote: >>> On Wed, Oct 3, 2012 at 7:06 PM, Diego Biurrun wrote: >>> > --- a/libavutil/x86/cpu.c >>> > +++ b/libavutil/x86/cpu.c >>> > @@ -108,10 +108,7 @@ int

Re: [libav-devel] [PATCH 1/4] x86: ff_get_cpu_flags_x86(): Avoid a pointless variable indirection

2012-10-04 Thread Måns Rullgård
Diego Biurrun writes: > On Wed, Oct 03, 2012 at 10:11:37PM -0400, Sean McGovern wrote: >> On Wed, Oct 3, 2012 at 7:06 PM, Diego Biurrun wrote: >> > --- a/libavutil/x86/cpu.c >> > +++ b/libavutil/x86/cpu.c >> > @@ -108,10 +108,7 @@ int ff_get_cpu_flags_x86(void) >> > >> > -cpuid(0, max_std_le

Re: [libav-devel] [PATCH 1/4] x86: ff_get_cpu_flags_x86(): Avoid a pointless variable indirection

2012-10-04 Thread Diego Biurrun
On Thu, Oct 04, 2012 at 12:44:12AM +0100, Måns Rullgård wrote: > Diego Biurrun writes: > > On Thu, Oct 04, 2012 at 12:27:09AM +0100, Måns Rullgård wrote: > >> Diego Biurrun writes: > >> > --- a/libavutil/x86/cpu.c > >> > +++ b/libavutil/x86/cpu.c > >> > @@ -108,10 +108,7 @@ int ff_get_cpu_flags_x

Re: [libav-devel] [PATCH 1/4] x86: ff_get_cpu_flags_x86(): Avoid a pointless variable indirection

2012-10-04 Thread Diego Biurrun
On Wed, Oct 03, 2012 at 10:11:37PM -0400, Sean McGovern wrote: > On Wed, Oct 3, 2012 at 7:06 PM, Diego Biurrun wrote: > > --- a/libavutil/x86/cpu.c > > +++ b/libavutil/x86/cpu.c > > @@ -108,10 +108,7 @@ int ff_get_cpu_flags_x86(void) > > > > -cpuid(0, max_std_level, ebx, ecx, edx); > > -ve

Re: [libav-devel] [PATCH 1/4] x86: ff_get_cpu_flags_x86(): Avoid a pointless variable indirection

2012-10-03 Thread Sean McGovern
On Wed, Oct 3, 2012 at 7:06 PM, Diego Biurrun wrote: > --- > libavutil/x86/cpu.c |5 + > 1 files changed, 1 insertions(+), 4 deletions(-) > > diff --git a/libavutil/x86/cpu.c b/libavutil/x86/cpu.c > index 9acc867..9cf68e4 100644 > --- a/libavutil/x86/cpu.c > +++ b/libavutil/x86/cpu.c > @@

Re: [libav-devel] [PATCH 1/4] x86: ff_get_cpu_flags_x86(): Avoid a pointless variable indirection

2012-10-03 Thread Måns Rullgård
Diego Biurrun writes: > On Thu, Oct 04, 2012 at 12:27:09AM +0100, Måns Rullgård wrote: >> Diego Biurrun writes: >> > --- a/libavutil/x86/cpu.c >> > +++ b/libavutil/x86/cpu.c >> > @@ -108,10 +108,7 @@ int ff_get_cpu_flags_x86(void) >> > >> > -cpuid(0, max_std_level, ebx, ecx, edx); >> > -

Re: [libav-devel] [PATCH 1/4] x86: ff_get_cpu_flags_x86(): Avoid a pointless variable indirection

2012-10-03 Thread Diego Biurrun
On Thu, Oct 04, 2012 at 12:27:09AM +0100, Måns Rullgård wrote: > Diego Biurrun writes: > > --- a/libavutil/x86/cpu.c > > +++ b/libavutil/x86/cpu.c > > @@ -108,10 +108,7 @@ int ff_get_cpu_flags_x86(void) > > > > -cpuid(0, max_std_level, ebx, ecx, edx); > > -vendor.i[0] = ebx; > > -vendo

Re: [libav-devel] [PATCH 1/4] x86: ff_get_cpu_flags_x86(): Avoid a pointless variable indirection

2012-10-03 Thread Måns Rullgård
Diego Biurrun writes: > --- > libavutil/x86/cpu.c |5 + > 1 files changed, 1 insertions(+), 4 deletions(-) > > diff --git a/libavutil/x86/cpu.c b/libavutil/x86/cpu.c > index 9acc867..9cf68e4 100644 > --- a/libavutil/x86/cpu.c > +++ b/libavutil/x86/cpu.c > @@ -108,10 +108,7 @@ int ff_get_

[libav-devel] [PATCH 1/4] x86: ff_get_cpu_flags_x86(): Avoid a pointless variable indirection

2012-10-03 Thread Diego Biurrun
--- libavutil/x86/cpu.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/libavutil/x86/cpu.c b/libavutil/x86/cpu.c index 9acc867..9cf68e4 100644 --- a/libavutil/x86/cpu.c +++ b/libavutil/x86/cpu.c @@ -108,10 +108,7 @@ int ff_get_cpu_flags_x86(void) return 0; /*