Re: [libav-devel] [PATCH 1/6] lavu: improve documentation of some AVFrame functions

2016-03-04 Thread Anton Khirnov
Quoting wm4 (2016-03-04 10:36:09) > On Fri, 04 Mar 2016 08:16:42 +0100 > Anton Khirnov wrote: > > > No important objections from me now. Since this is a rather large > > change, I'd wait until next week for more comments, then push it if > > there are none. > > I also have

Re: [libav-devel] [PATCH 1/6] lavu: improve documentation of some AVFrame functions

2016-03-04 Thread wm4
On Fri, 04 Mar 2016 08:16:42 +0100 Anton Khirnov wrote: > No important objections from me now. Since this is a rather large > change, I'd wait until next week for more comments, then push it if > there are none. I also have some follow up patches to make. But would be nice if

Re: [libav-devel] [PATCH 1/6] lavu: improve documentation of some AVFrame functions

2016-03-03 Thread Anton Khirnov
No important objections from me now. Since this is a rather large change, I'd wait until next week for more comments, then push it if there are none. Are you planning to convert any actual encoders/decoders to the new API? Also, what about deprecating the old one? -- Anton Khirnov

[libav-devel] [PATCH 1/6] lavu: improve documentation of some AVFrame functions

2016-02-29 Thread wm4
--- Changed some minor things that were pointed out. --- libavutil/frame.h | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/libavutil/frame.h b/libavutil/frame.h index 5a04177..a39a1ef 100644 --- a/libavutil/frame.h +++ b/libavutil/frame.h @@ -391,6 +391,10 @@

Re: [libav-devel] [PATCH 1/6] lavu: improve documentation of some AVFrame functions

2016-02-29 Thread wm4
On Sat, 27 Feb 2016 10:48:24 -0500 Vittorio Giovara wrote: > On Sat, Feb 27, 2016 at 9:15 AM, wm4 wrote: > > --- > > libavutil/frame.h | 14 +- > > 1 file changed, 13 insertions(+), 1 deletion(-) > > > > diff --git

Re: [libav-devel] [PATCH 1/6] lavu: improve documentation of some AVFrame functions

2016-02-27 Thread Luca Barbato
On 27/02/16 16:07, wm4 wrote: > On Sat, 27 Feb 2016 15:21:24 +0100 > Luca Barbato wrote: > >> On 27/02/16 15:15, wm4 wrote: >>> In addition, undefined behavior can occur in certain >>> + * cases. >> >> Would be better to list the cases. >> >> The rest looks fine.

Re: [libav-devel] [PATCH 1/6] lavu: improve documentation of some AVFrame functions

2016-02-27 Thread Vittorio Giovara
On Sat, Feb 27, 2016 at 9:15 AM, wm4 wrote: > --- > libavutil/frame.h | 14 +- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/libavutil/frame.h b/libavutil/frame.h > index 5a04177..6f5d733 100644 > --- a/libavutil/frame.h > +++

Re: [libav-devel] [PATCH 1/6] lavu: improve documentation of some AVFrame functions

2016-02-27 Thread wm4
On Sat, 27 Feb 2016 15:21:24 +0100 Luca Barbato wrote: > On 27/02/16 15:15, wm4 wrote: > > In addition, undefined behavior can occur in certain > > + * cases. > > Would be better to list the cases. > > The rest looks fine. The code of these functions is simply

Re: [libav-devel] [PATCH 1/6] lavu: improve documentation of some AVFrame functions

2016-02-27 Thread Luca Barbato
On 27/02/16 15:15, wm4 wrote: > In addition, undefined behavior can occur in certain > + * cases. Would be better to list the cases. The rest looks fine. lu ___ libav-devel mailing list libav-devel@libav.org

[libav-devel] [PATCH 1/6] lavu: improve documentation of some AVFrame functions

2016-02-27 Thread wm4
--- libavutil/frame.h | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/libavutil/frame.h b/libavutil/frame.h index 5a04177..6f5d733 100644 --- a/libavutil/frame.h +++ b/libavutil/frame.h @@ -391,6 +391,10 @@ void av_frame_free(AVFrame **frame); * If src is not