Hi,
On Thu, May 12, 2011 at 1:16 AM, Anton Khirnov wrote:
> Prefer parse_number_or_die() over atoi()/atol() parsing for the options:
> -pass, -top, -vc, and -qscale.
>
> Improve input validation.
>
> Signed-off-by: Stefano Sabatini
> Signed-off-by: Anton Khirnov
> ---
> ffmpeg.c | 39 +++
On Tue, 10 May 2011 09:29:47 +0200, Stefano Sabatini
wrote:
> On date Monday 2011-05-09 20:25:31 -0400, Ronald S. Bultje encoded:
> > Hi,
> >
> > On Mon, May 9, 2011 at 7:09 PM, Stefano Sabatini
> > wrote:
> > > On date Monday 2011-05-09 18:06:51 -0400, Ronald S. Bultje encoded:
> > >> Hi,
> >
On Mon, 9 May 2011 18:06:51 -0400, "Ronald S. Bultje"
wrote:
> Hi,
>
> On Mon, May 9, 2011 at 1:49 PM, Anton Khirnov wrote:
> > -static void opt_qscale(const char *arg)
> > +static int opt_qscale(const char *opt, const char *arg)
> > ??{
> > - ?? ??video_qscale = atof(arg);
> > - ?? ??if (video
On date Monday 2011-05-09 20:25:31 -0400, Ronald S. Bultje encoded:
> Hi,
>
> On Mon, May 9, 2011 at 7:09 PM, Stefano Sabatini
> wrote:
> > On date Monday 2011-05-09 18:06:51 -0400, Ronald S. Bultje encoded:
> >> Hi,
> >>
> >> On Mon, May 9, 2011 at 1:49 PM, Anton Khirnov wrote:
> >> > -static v
Hi,
On Mon, May 9, 2011 at 7:09 PM, Stefano Sabatini
wrote:
> On date Monday 2011-05-09 18:06:51 -0400, Ronald S. Bultje encoded:
>> Hi,
>>
>> On Mon, May 9, 2011 at 1:49 PM, Anton Khirnov wrote:
>> > -static void opt_qscale(const char *arg)
>> > +static int opt_qscale(const char *opt, const cha
On date Monday 2011-05-09 18:06:51 -0400, Ronald S. Bultje encoded:
> Hi,
>
> On Mon, May 9, 2011 at 1:49 PM, Anton Khirnov wrote:
> > -static void opt_qscale(const char *arg)
> > +static int opt_qscale(const char *opt, const char *arg)
> > {
> > - video_qscale = atof(arg);
> > - if (video
Hi,
On Mon, May 9, 2011 at 1:49 PM, Anton Khirnov wrote:
> -static void opt_qscale(const char *arg)
> +static int opt_qscale(const char *opt, const char *arg)
> {
> - video_qscale = atof(arg);
> - if (video_qscale <= 0 ||
> - video_qscale > 255) {
> + video_qscale = parse_number_
From: Stefano Sabatini
Prefer parse_number_or_die() over atoi()/atol() parsing for the options:
-pass, -top, -vc, and -qscale.
Improve input validation.
Signed-off-by: Stefano Sabatini
Signed-off-by: Anton Khirnov
---
ffmpeg.c | 39 ++-
1 files changed,
