Re: [libav-devel] [PATCH 2/4] avcodec/hap: move some per-stream setup into decoder init rather than per-frame

2015-07-20 Thread Vittorio Giovara
On Mon, Jul 20, 2015 at 2:34 PM, Tom Butterworth wrote: >> Is this change necessary? There are now two switches that carry out >> the same purpose and the condition above forces cases from both >> switches to perform the same operation. > > Define "necessary" :) > > Setting the tex_rat and tex_fun

Re: [libav-devel] [PATCH 2/4] avcodec/hap: move some per-stream setup into decoder init rather than per-frame

2015-07-20 Thread Tom Butterworth
Thanks for the detailed review to this patch set Vittorio. >> This change will reject frames with a texture type which doesn't match the >> stream description. > > Is this change required by the format specification or just as a > precaution for malformed streams? Just as a precaution for malfor

Re: [libav-devel] [PATCH 2/4] avcodec/hap: move some per-stream setup into decoder init rather than per-frame

2015-07-17 Thread Vittorio Giovara
Hi Tom, On Fri, Jul 17, 2015 at 1:11 PM, Tom Butterworth wrote: > This change will reject frames with a texture type which doesn't match the > stream description. Is this change required by the format specification or just as a precaution for malformed streams? > --- > libavcodec/hapdec.c | 2

Re: [libav-devel] [PATCH 2/4] avcodec/hap: move some per-stream setup into decoder init rather than per-frame

2015-07-17 Thread Luca Barbato
On 17/07/15 14:11, Tom Butterworth wrote: > This change will reject frames with a texture type which doesn't match the > stream description. > --- > libavcodec/hapdec.c | 27 +-- > 1 file changed, 21 insertions(+), 6 deletions(-) > I doubt somebody would generate a strea

[libav-devel] [PATCH 2/4] avcodec/hap: move some per-stream setup into decoder init rather than per-frame

2015-07-17 Thread Tom Butterworth
This change will reject frames with a texture type which doesn't match the stream description. --- libavcodec/hapdec.c | 27 +-- 1 file changed, 21 insertions(+), 6 deletions(-) diff --git a/libavcodec/hapdec.c b/libavcodec/hapdec.c index ca1c158..324a43a 100644 --- a/lib