Re: [libav-devel] [PATCH 2/5] VP8: Change mb memory layout for sliced threading.

2012-06-27 Thread Måns Rullgård
Jason Garrett-Glaser writes: > On Wed, Jun 27, 2012 at 12:29 PM, Daniel Kang wrote: >> Now, memory is allocated for each macroblock in the frame. >> >> Previously, there was an optimization to only need width+height*2+1 >> macroblocks allocated. That sounds like it could easily hurt cache perfo

Re: [libav-devel] [PATCH 2/5] VP8: Change mb memory layout for sliced threading.

2012-06-27 Thread Jason Garrett-Glaser
On Wed, Jun 27, 2012 at 1:24 PM, Jason Garrett-Glaser wrote: > On Wed, Jun 27, 2012 at 12:29 PM, Daniel Kang wrote: >> Now, memory is allocated for each macroblock in the frame. >> >> Previously, there was an optimization to only need width+height*2+1 >> macroblocks allocated. > > I strongly dis

Re: [libav-devel] [PATCH 2/5] VP8: Change mb memory layout for sliced threading.

2012-06-27 Thread Jason Garrett-Glaser
On Wed, Jun 27, 2012 at 12:29 PM, Daniel Kang wrote: > Now, memory is allocated for each macroblock in the frame. > > Previously, there was an optimization to only need width+height*2+1 > macroblocks allocated. I strongly dislike this patch. Can we implemented sliced threading -- a rarely-used

[libav-devel] [PATCH 2/5] VP8: Change mb memory layout for sliced threading.

2012-06-27 Thread Daniel Kang
Now, memory is allocated for each macroblock in the frame. Previously, there was an optimization to only need width+height*2+1 macroblocks allocated. --- libavcodec/vp8.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c ind

Re: [libav-devel] [PATCH 2/5] VP8: Change mb memory layout for sliced threading.

2012-06-22 Thread Luca Barbato
On 06/22/2012 04:19 AM, Daniel Kang wrote: > --- > libavcodec/vp8.c | 14 +++--- > 1 files changed, 7 insertions(+), 7 deletions(-) As before: - Cleanup the style to have enough space around operators - Would be nice explaining how the memory layout got changed, as is I can't tell why

[libav-devel] [PATCH 2/5] VP8: Change mb memory layout for sliced threading.

2012-06-21 Thread Daniel Kang
--- libavcodec/vp8.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c index 7a8a0c6..6ab4b26 100644 --- a/libavcodec/vp8.c +++ b/libavcodec/vp8.c @@ -121,7 +121,7 @@ static int update_dimensions(VP8Context *s, int width, int