Re: [libav-devel] [PATCH 2/7] vf_hqdn3d: simplify and optimize

2012-07-25 Thread Anton Khirnov
On Wed, 25 Jul 2012 02:45:35 +, Loren Merritt lor...@u.washington.edu wrote: 14% faster on penryn, 2% on sandybridge, 9% on bulldozer --- libavfilter/vf_hqdn3d.c | 166 +++--- 1 files changed, 54 insertions(+), 112 deletions(-) diff --git

Re: [libav-devel] [PATCH 2/7] vf_hqdn3d: simplify and optimize

2012-07-25 Thread Måns Rullgård
Ronald S. Bultje rsbul...@gmail.com writes: Hi, On Tue, Jul 24, 2012 at 7:45 PM, Loren Merritt lor...@u.washington.edu wrote: -long x, y; -uint32_t pixel; +uint32_t tmp; -for (y = 0; y h; y++) { -for (x = 0; x w; x++) { -pixel =

Re: [libav-devel] [PATCH 2/7] vf_hqdn3d: simplify and optimize

2012-07-25 Thread Uoti Urpala
On Wed, 2012-07-25 at 10:53 +0100, Måns Rullgård wrote: Ronald S. Bultje rsbul...@gmail.com writes: On Tue, Jul 24, 2012 at 7:45 PM, Loren Merritt lor...@u.washington.edu wrote: -long x, y; -uint32_t pixel; +uint32_t tmp; -for (y = 0; y h; y++) { -for (x

Re: [libav-devel] [PATCH 2/7] vf_hqdn3d: simplify and optimize

2012-07-25 Thread Måns Rullgård
Uoti Urpala uoti.urp...@pp1.inet.fi writes: On Wed, 2012-07-25 at 10:53 +0100, Måns Rullgård wrote: Ronald S. Bultje rsbul...@gmail.com writes: On Tue, Jul 24, 2012 at 7:45 PM, Loren Merritt lor...@u.washington.edu wrote: -long x, y; -uint32_t pixel; +uint32_t tmp; -

Re: [libav-devel] [PATCH 2/7] vf_hqdn3d: simplify and optimize

2012-07-25 Thread Diego Biurrun
On Wed, Jul 25, 2012 at 12:46:02PM +0100, Måns Rullgård wrote: Uoti Urpala uoti.urp...@pp1.inet.fi writes: [... flame ...] [... flame ...] Compiler trollwar incoming? Come on guys, save us all the spectacle... Diego ___ libav-devel mailing list

Re: [libav-devel] [PATCH 2/7] vf_hqdn3d: simplify and optimize

2012-07-25 Thread Uoti Urpala
On Wed, 2012-07-25 at 12:46 +0100, Måns Rullgård wrote: Uoti Urpala uoti.urp...@pp1.inet.fi writes: On Wed, 2012-07-25 at 10:53 +0100, Måns Rullgård wrote: Same goes for a number of other compilers. It's unfortunate, but a small price to pay for portability. What compilers are those

Re: [libav-devel] [PATCH 2/7] vf_hqdn3d: simplify and optimize

2012-07-25 Thread Luca Barbato
On 07/25/2012 12:33 PM, Uoti Urpala wrote: This kind of syntax issues could be automatically handled by a conversion wrapper for the deficient compilers. It is commonly accepted not to mix variable declaration and code and usually it helps readability and avoids shadowing variables in long/too

[libav-devel] [PATCH 2/7] vf_hqdn3d: simplify and optimize

2012-07-24 Thread Loren Merritt
14% faster on penryn, 2% on sandybridge, 9% on bulldozer --- libavfilter/vf_hqdn3d.c | 166 +++--- 1 files changed, 54 insertions(+), 112 deletions(-) diff --git a/libavfilter/vf_hqdn3d.c b/libavfilter/vf_hqdn3d.c index 8e2a6a2..fdb2ecb 100644 ---

Re: [libav-devel] [PATCH 2/7] vf_hqdn3d: simplify and optimize

2012-07-24 Thread Ronald S. Bultje
Hi, On Tue, Jul 24, 2012 at 7:45 PM, Loren Merritt lor...@u.washington.edu wrote: -long x, y; -uint32_t pixel; +uint32_t tmp; -for (y = 0; y h; y++) { -for (x = 0; x w; x++) { -pixel = lowpass(frame_ant[x]8, src[x]16, temporal); -