Re: [libav-devel] [PATCH 3/6] vorbisdec: Rename silly "class_" variable to plain "class".

2011-04-28 Thread Vladimir Pantelic
On 04/28/2011 06:41 PM, Kirill Gavrilov wrote: 2011/4/28 Alex Converse mailto:alex.conve...@gmail.com>> This code already won't compile in a C++ compiler because of the way it uses malloc(). I know a lot of things why LibAV sources couldn't be compiled with C++ compiler however I intere

Re: [libav-devel] [PATCH 3/6] vorbisdec: Rename silly "class_" variable to plain "class".

2011-04-28 Thread Kirill Gavrilov
2011/4/28 Alex Converse > This code already won't compile in a C++ compiler because of the way > it uses malloc(). > I know a lot of things why LibAV sources couldn't be compiled with C++ compiler however I interested what did you mean by malloc() usage? Usage without explicit typecast? Diego Bi

Re: [libav-devel] [PATCH 3/6] vorbisdec: Rename silly "class_" variable to plain "class".

2011-04-28 Thread Alex Converse
On Wed, Apr 27, 2011 at 9:35 PM, Kirill Gavrilov wrote: > Just notice. I don't think that usage of "class_" name is stupid. > "class" is a keyword in C++ and you can not use it as a name for variables. > However while this name appear in source file (.c, not a header, because > appearing in header

Re: [libav-devel] [PATCH 3/6] vorbisdec: Rename silly "class_" variable to plain "class".

2011-04-28 Thread Diego Biurrun
On Thu, Apr 28, 2011 at 08:35:46AM +0400, Kirill Gavrilov wrote: > Just notice. I don't think that usage of "class_" name is stupid. > "class" is a keyword in C++ and you can not use it as a name for variables. > However while this name appear in source file (.c, not a header, because > appearing i

Re: [libav-devel] [PATCH 3/6] vorbisdec: Rename silly "class_" variable to plain "class".

2011-04-27 Thread Kirill Gavrilov
Just notice. I don't think that usage of "class_" name is stupid. "class" is a keyword in C++ and you can not use it as a name for variables. However while this name appear in source file (.c, not a header, because appearing in header will broke API with C++) and this project probably will never be

Re: [libav-devel] [PATCH 3/6] vorbisdec: Rename silly "class_" variable to plain "class".

2011-04-27 Thread Måns Rullgård
Diego Biurrun writes: > --- > libavcodec/vorbisdec.c | 14 +++--- > 1 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/libavcodec/vorbisdec.c b/libavcodec/vorbisdec.c > index d42507d..a9ddc7d 100644 > --- a/libavcodec/vorbisdec.c > +++ b/libavcodec/vorbisdec.c > @@ -1136

[libav-devel] [PATCH 3/6] vorbisdec: Rename silly "class_" variable to plain "class".

2011-04-27 Thread Diego Biurrun
--- libavcodec/vorbisdec.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/libavcodec/vorbisdec.c b/libavcodec/vorbisdec.c index d42507d..a9ddc7d 100644 --- a/libavcodec/vorbisdec.c +++ b/libavcodec/vorbisdec.c @@ -1136,7 +1136,7 @@ static int vorbis_floor1_de