Re: [libav-devel] [PATCH 6/6] xcbgrab: xcb-based screen capture

2014-08-26 Thread Timothy Gu
On Aug 26, 2014 8:08 PM, "Luca Barbato" wrote: > Didn't benchmark, the code is cleaner and it _should_ address the > flickering issue reported with x11grab though. That's nice. > > > And also this commit needs a minor bump. > > Sure. Thx Timothy ___

Re: [libav-devel] [PATCH 6/6] xcbgrab: xcb-based screen capture

2014-08-26 Thread Luca Barbato
On 26/08/14 15:46, Timothy Gu wrote: > On Aug 24, 2014 5:18 AM, "Luca Barbato" wrote: >> >> Feature matching x11grab. >> --- >> configure| 11 + >> libavdevice/Makefile | 1 + >> libavdevice/alldevices.c | 1 + >> libavdevice/xcbgrab.c| 646 > +

Re: [libav-devel] [PATCH 6/6] xcbgrab: xcb-based screen capture

2014-08-26 Thread Luca Barbato
On 26/08/14 16:50, Rémi Denis-Courmont wrote: > Indeed, xcb-shm is only needed for MIT-SHM support (and makes no sense > on platforms without SysV SHM). Good point to keep it optional. > But xcb-xfixes is also optional, only > needed for pointer capture. However, given they all come from the same

Re: [libav-devel] [PATCH 6/6] xcbgrab: xcb-based screen capture

2014-08-26 Thread Rémi Denis-Courmont
Le 2014-08-26 16:38, Luca Barbato a écrit : On 26/08/14 14:11, Diego Biurrun wrote: On Sun, Aug 24, 2014 at 02:18:22PM +0200, Luca Barbato wrote: Feature matching x11grab. Matches the x11grab screen capture by features. IMO this thing should deprecate the x11grab screen capture. --- a/conf

Re: [libav-devel] [PATCH 6/6] xcbgrab: xcb-based screen capture

2014-08-26 Thread Timothy Gu
On Aug 24, 2014 5:18 AM, "Luca Barbato" wrote: > > Feature matching x11grab. > --- > configure| 11 + > libavdevice/Makefile | 1 + > libavdevice/alldevices.c | 1 + > libavdevice/xcbgrab.c| 646 +++ > 4 files changed, 659 i

Re: [libav-devel] [PATCH 6/6] xcbgrab: xcb-based screen capture

2014-08-26 Thread Luca Barbato
On 26/08/14 14:33, Rémi Denis-Courmont wrote: > Le 2014-08-24 15:18, Luca Barbato a écrit : >> Feature matching x11grab. >> --- >> configure| 11 + >> libavdevice/Makefile | 1 + >> libavdevice/alldevices.c | 1 + >> libavdevice/xcbgrab.c| 646 >> ++

Re: [libav-devel] [PATCH 6/6] xcbgrab: xcb-based screen capture

2014-08-26 Thread Luca Barbato
On 26/08/14 14:11, Diego Biurrun wrote: > On Sun, Aug 24, 2014 at 02:18:22PM +0200, Luca Barbato wrote: >> Feature matching x11grab. > > Matches the x11grab screen capture by features. > > IMO this thing should deprecate the x11grab screen capture. > >> --- a/configure >> +++ b/configure >> @@ -

Re: [libav-devel] [PATCH 6/6] xcbgrab: xcb-based screen capture

2014-08-26 Thread Rémi Denis-Courmont
Le 2014-08-24 15:18, Luca Barbato a écrit : Feature matching x11grab. --- configure| 11 + libavdevice/Makefile | 1 + libavdevice/alldevices.c | 1 + libavdevice/xcbgrab.c| 646 +++ 4 files changed, 659 insertions(+) crea

Re: [libav-devel] [PATCH 6/6] xcbgrab: xcb-based screen capture

2014-08-26 Thread Diego Biurrun
On Sun, Aug 24, 2014 at 02:18:22PM +0200, Luca Barbato wrote: > Feature matching x11grab. Matches the x11grab screen capture by features. IMO this thing should deprecate the x11grab screen capture. > --- a/configure > +++ b/configure > @@ -4257,6 +4261,13 @@ require Xext X11/extensions/XShm.h XS

[libav-devel] [PATCH 6/6] xcbgrab: xcb-based screen capture

2014-08-24 Thread Luca Barbato
Feature matching x11grab. --- configure| 11 + libavdevice/Makefile | 1 + libavdevice/alldevices.c | 1 + libavdevice/xcbgrab.c| 646 +++ 4 files changed, 659 insertions(+) create mode 100644 libavdevice/xcbgrab.c diff --g