Re: [libav-devel] [PATCH v2] avidec: fix signed overflow in avi_sync()

2011-10-10 Thread Janne Grunau
On Sun, Oct 09, 2011 at 01:07:09PM +0100, Mans Rullgard wrote: Keeping byte values read from the file as unsigned is consistent with how they are subsequently used and avoids an undefined left shift by 24 when bit 7 is set. Signed-off-by: Mans Rullgard m...@mansr.com ---

Re: [libav-devel] [PATCH v2] avidec: fix signed overflow in avi_sync()

2011-10-10 Thread Måns Rullgård
Diego Biurrun di...@biurrun.de writes: On Mon, Oct 10, 2011 at 12:23:04PM +0100, Måns Rullgård wrote: Janne Grunau janne-li...@jannau.net writes: On Sun, Oct 09, 2011 at 01:07:09PM +0100, Mans Rullgard wrote: Keeping byte values read from the file as unsigned is consistent with how they

Re: [libav-devel] [PATCH v2] avidec: fix signed overflow in avi_sync()

2011-10-10 Thread Alex Converse
On Sun, Oct 9, 2011 at 5:07 AM, Mans Rullgard m...@mansr.com wrote: Keeping byte values read from the file as unsigned is consistent with how they are subsequently used and avoids an undefined left shift by 24 when bit 7 is set. Looks good ___