Re: [libav-devel] [RFC] Changing AV_PIX_FMT_NONE from -1 to 0

2017-04-01 Thread Anton Khirnov
Quoting wm4 (2017-03-30 17:25:50) > On Thu, 30 Mar 2017 17:06:00 +0200 > Anton Khirnov wrote: > > > Quoting wm4 (2017-03-28 12:43:04) > > > I propose that AV_PIX_FMT_NONE is changed from -1 to 0. The reason is > > > that default-initializing an AVPixelFormat should set an

Re: [libav-devel] [RFC] Changing AV_PIX_FMT_NONE from -1 to 0

2017-03-30 Thread Luca Barbato
On 30/03/2017 17:25, wm4 wrote: > I wonder how you can make this argument, but the move towards removing > sizeof(AVPacket) from ABI is apparently ok. Code would stop compiling in that case so the change wouldn't be silent. As I said, if we move to non-enum format descriptor the whole issue

Re: [libav-devel] [RFC] Changing AV_PIX_FMT_NONE from -1 to 0

2017-03-30 Thread wm4
On Thu, 30 Mar 2017 17:06:00 +0200 Anton Khirnov wrote: > Quoting wm4 (2017-03-28 12:43:04) > > I propose that AV_PIX_FMT_NONE is changed from -1 to 0. The reason is > > that default-initializing an AVPixelFormat should set an invalid or > > neutral value, instead of a

Re: [libav-devel] [RFC] Changing AV_PIX_FMT_NONE from -1 to 0

2017-03-30 Thread Anton Khirnov
Quoting wm4 (2017-03-28 12:43:04) > I propose that AV_PIX_FMT_NONE is changed from -1 to 0. The reason is > that default-initializing an AVPixelFormat should set an invalid or > neutral value, instead of a "random" valid value. > > Currently, 0 means AV_PIX_FMT_YUV420P, which is confusing and can

Re: [libav-devel] [RFC] Changing AV_PIX_FMT_NONE from -1 to 0

2017-03-28 Thread Luca Barbato
On 28/03/2017 12:43, wm4 wrote: > I propose that AV_PIX_FMT_NONE is changed from -1 to 0. The reason is > that default-initializing an AVPixelFormat should set an invalid or > neutral value, instead of a "random" valid value. > > Currently, 0 means AV_PIX_FMT_YUV420P, which is confusing and can

Re: [libav-devel] [RFC] Changing AV_PIX_FMT_NONE from -1 to 0

2017-03-28 Thread Vittorio Giovara
On Tue, Mar 28, 2017 at 12:43 PM, wm4 wrote: > I propose that AV_PIX_FMT_NONE is changed from -1 to 0. The reason is > that default-initializing an AVPixelFormat should set an invalid or > neutral value, instead of a "random" valid value. > > Currently, 0 means

[libav-devel] [RFC] Changing AV_PIX_FMT_NONE from -1 to 0

2017-03-28 Thread wm4
I propose that AV_PIX_FMT_NONE is changed from -1 to 0. The reason is that default-initializing an AVPixelFormat should set an invalid or neutral value, instead of a "random" valid value. Currently, 0 means AV_PIX_FMT_YUV420P, which is confusing and can lead to errors, especially since almost all