Re: [libav-devel] [RFC] avconv: Use the input codec timebase for encoding

2014-02-22 Thread Tim Walker
On 22 Feb 2014, at 02:47, Luca Barbato lu_z...@gentoo.org wrote: On 22/02/14 02:20, Tim Walker wrote: On 21 Feb 2014, at 21:18, Luca Barbato lu_z...@gentoo.org wrote: Can you elaborate? currently avconv passes as codec timebase the filter timebase and it is usually 1/90k or such value.

Re: [libav-devel] [RFC] avconv: Use the input codec timebase for encoding

2014-02-22 Thread Luca Barbato
On 22/02/14 15:03, Tim Walker wrote: Are you setting FrameRateExtN and FrameRateExtD? Those aren't made for the timebase, only the frame rate. Yes, the frame-rate is at best a hint or unused, the problem is that it rejects bogus values. We have this problem and solving it doesn't start if not

[libav-devel] [RFC] avconv: Use the input codec timebase for encoding

2014-02-21 Thread Luca Barbato
The codec time_base is used as hint for some rate control algorithms and usually the filter time base matches poorly for such usage. --- Spun from the x265 patchset and the libmfx encoder patchset I'm working on. avconv.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [libav-devel] [RFC] avconv: Use the input codec timebase for encoding

2014-02-21 Thread Anton Khirnov
On Fri, 21 Feb 2014 18:52:09 +0100, Luca Barbato lu_z...@gentoo.org wrote: The codec time_base is used as hint for some rate control algorithms and usually the filter time base matches poorly for such usage. --- No, this will break more stuff than it fixes. Input codec timebase is just a

Re: [libav-devel] [RFC] avconv: Use the input codec timebase for encoding

2014-02-21 Thread Luca Barbato
On 21/02/14 21:16, Anton Khirnov wrote: On Fri, 21 Feb 2014 18:52:09 +0100, Luca Barbato lu_z...@gentoo.org wrote: The codec time_base is used as hint for some rate control algorithms and usually the filter time base matches poorly for such usage. --- No, this will break more stuff than

Re: [libav-devel] [RFC] avconv: Use the input codec timebase for encoding

2014-02-21 Thread Anton Khirnov
On Fri, 21 Feb 2014 21:18:54 +0100, Luca Barbato lu_z...@gentoo.org wrote: On 21/02/14 21:16, Anton Khirnov wrote: On Fri, 21 Feb 2014 18:52:09 +0100, Luca Barbato lu_z...@gentoo.org wrote: The codec time_base is used as hint for some rate control algorithms and usually the filter time

Re: [libav-devel] [RFC] avconv: Use the input codec timebase for encoding

2014-02-21 Thread Tim Walker
On 21 Feb 2014, at 21:18, Luca Barbato lu_z...@gentoo.org wrote: On 21/02/14 21:16, Anton Khirnov wrote: On Fri, 21 Feb 2014 18:52:09 +0100, Luca Barbato lu_z...@gentoo.org wrote: The codec time_base is used as hint for some rate control algorithms and usually the filter time base matches

Re: [libav-devel] [RFC] avconv: Use the input codec timebase for encoding

2014-02-21 Thread Luca Barbato
On 22/02/14 02:20, Tim Walker wrote: On 21 Feb 2014, at 21:18, Luca Barbato lu_z...@gentoo.org wrote: Can you elaborate? currently avconv passes as codec timebase the filter timebase and it is usually 1/90k or such value. mfx rejects it. lu ___