Re: [libav-devel] [libav-commits] x86: fft: convert sse inline asm to yasm

2012-07-26 Thread John Stebbins
On 07/25/2012 07:38 PM, John Stebbins wrote: On 07/25/2012 12:05 AM, Jason Garrett-Glaser wrote: On Tue, Jul 24, 2012 at 9:02 AM, John Stebbins stebb...@jetheaddev.com wrote: On 07/24/2012 05:53 PM, Jason Garrett-Glaser wrote: On Tue, Jul 24, 2012 at 8:34 AM, Måns Rullgård m...@mansr.com

Re: [libav-devel] [libav-commits] x86: fft: convert sse inline asm to yasm

2012-07-26 Thread Luca Barbato
On 07/26/2012 05:23 PM, John Stebbins wrote: Just confirming that the patch x86inc: automatically insert vzeroupper for YMM functions. solves this problem. Glad to know, thanks for reporting =) lu -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero

Re: [libav-devel] [libav-commits] x86: fft: convert sse inline asm to yasm

2012-07-25 Thread Luca Barbato
On 07/25/2012 07:40 AM, Jason Garrett-Glaser wrote: Do the x264 functions sign-extend all their integer arguments? Or put differently, does the problem occur for 32-bit builds also, or only for 64-bit builds? Yes they do, and such a problem wouldn't target solely _avx functions; that

Re: [libav-devel] [libav-commits] x86: fft: convert sse inline asm to yasm

2012-07-25 Thread Loren Merritt
On Wed, 25 Jul 2012, Luca Barbato wrote: On 07/25/2012 07:40 AM, Jason Garrett-Glaser wrote: Do the x264 functions sign-extend all their integer arguments? Or put differently, does the problem occur for 32-bit builds also, or only for 64-bit builds? Yes they do, and such a problem wouldn't

Re: [libav-devel] [libav-commits] x86: fft: convert sse inline asm to yasm

2012-07-25 Thread John Stebbins
On 07/25/2012 12:05 AM, Jason Garrett-Glaser wrote: On Tue, Jul 24, 2012 at 9:02 AM, John Stebbins stebb...@jetheaddev.com wrote: On 07/24/2012 05:53 PM, Jason Garrett-Glaser wrote: On Tue, Jul 24, 2012 at 8:34 AM, Måns Rullgård m...@mansr.com wrote: Jason Garrett-Glaser ja...@x264.com

Re: [libav-devel] [libav-commits] x86: fft: convert sse inline asm to yasm

2012-07-24 Thread John Stebbins
On 06/25/2012 02:42 PM, Mans Rullgard wrote: Module: libav Branch: master Commit: 82992604706144910f4a2f875d48cfc66c1b70d7 Author:Mans Rullgard m...@mansr.com Committer: Mans Rullgard m...@mansr.com Date: Sat Jun 23 19:08:11 2012 +0100 x86: fft: convert sse inline asm to yasm ---

Re: [libav-devel] [libav-commits] x86: fft: convert sse inline asm to yasm

2012-07-24 Thread Måns Rullgård
John Stebbins stebb...@jetheaddev.com writes: On 06/25/2012 02:42 PM, Mans Rullgard wrote: Module: libav Branch: master Commit: 82992604706144910f4a2f875d48cfc66c1b70d7 Author:Mans Rullgard m...@mansr.com Committer: Mans Rullgard m...@mansr.com Date: Sat Jun 23 19:08:11 2012

Re: [libav-devel] [libav-commits] x86: fft: convert sse inline asm to yasm

2012-07-24 Thread Jason Garrett-Glaser
On Tue, Jul 24, 2012 at 8:05 AM, John Stebbins stebb...@jetheaddev.com wrote: On 06/25/2012 02:42 PM, Mans Rullgard wrote: Module: libav Branch: master Commit: 82992604706144910f4a2f875d48cfc66c1b70d7 Author:Mans Rullgard m...@mansr.com Committer: Mans Rullgard m...@mansr.com Date:

Re: [libav-devel] [libav-commits] x86: fft: convert sse inline asm to yasm

2012-07-24 Thread Måns Rullgård
Jason Garrett-Glaser ja...@x264.com writes: On Tue, Jul 24, 2012 at 8:05 AM, John Stebbins stebb...@jetheaddev.com wrote: On 06/25/2012 02:42 PM, Mans Rullgard wrote: Module: libav Branch: master Commit: 82992604706144910f4a2f875d48cfc66c1b70d7 Author:Mans Rullgard m...@mansr.com

Re: [libav-devel] [libav-commits] x86: fft: convert sse inline asm to yasm

2012-07-24 Thread John Stebbins
On 07/24/2012 05:18 PM, Måns Rullgård wrote: John Stebbins stebb...@jetheaddev.com writes: On 06/25/2012 02:42 PM, Mans Rullgard wrote: Module: libav Branch: master Commit: 82992604706144910f4a2f875d48cfc66c1b70d7 Author:Mans Rullgard m...@mansr.com Committer: Mans Rullgard

Re: [libav-devel] [libav-commits] x86: fft: convert sse inline asm to yasm

2012-07-24 Thread Jason Garrett-Glaser
On Tue, Jul 24, 2012 at 8:34 AM, Måns Rullgård m...@mansr.com wrote: Jason Garrett-Glaser ja...@x264.com writes: On Tue, Jul 24, 2012 at 8:05 AM, John Stebbins stebb...@jetheaddev.com wrote: On 06/25/2012 02:42 PM, Mans Rullgard wrote: Module: libav Branch: master Commit:

Re: [libav-devel] [libav-commits] x86: fft: convert sse inline asm to yasm

2012-07-24 Thread John Stebbins
On 07/24/2012 05:53 PM, Jason Garrett-Glaser wrote: On Tue, Jul 24, 2012 at 8:34 AM, Måns Rullgård m...@mansr.com wrote: Jason Garrett-Glaser ja...@x264.com writes: On Tue, Jul 24, 2012 at 8:05 AM, John Stebbins stebb...@jetheaddev.com wrote: On 06/25/2012 02:42 PM, Mans Rullgard wrote:

Re: [libav-devel] [libav-commits] x86: fft: convert sse inline asm to yasm

2012-07-24 Thread Jason Garrett-Glaser
On Tue, Jul 24, 2012 at 9:02 AM, John Stebbins stebb...@jetheaddev.com wrote: On 07/24/2012 05:53 PM, Jason Garrett-Glaser wrote: On Tue, Jul 24, 2012 at 8:34 AM, Måns Rullgård m...@mansr.com wrote: Jason Garrett-Glaser ja...@x264.com writes: On Tue, Jul 24, 2012 at 8:05 AM, John Stebbins

Re: [libav-devel] [libav-commits] x86: fft: convert sse inline asm to yasm

2012-07-24 Thread Ronald S. Bultje
Hi, On Tue, Jul 24, 2012 at 3:05 PM, Jason Garrett-Glaser ja...@x264.com wrote: On Tue, Jul 24, 2012 at 9:02 AM, John Stebbins stebb...@jetheaddev.com wrote: On 07/24/2012 05:53 PM, Jason Garrett-Glaser wrote: On Tue, Jul 24, 2012 at 8:34 AM, Måns Rullgård m...@mansr.com wrote: Jason

Re: [libav-devel] [libav-commits] x86: fft: convert sse inline asm to yasm

2012-07-24 Thread Jason Garrett-Glaser
Do the x264 functions sign-extend all their integer arguments? Or put differently, does the problem occur for 32-bit builds also, or only for 64-bit builds? Yes they do, and such a problem wouldn't target solely _avx functions; that wouldn't make any sense. How about start by checking for a