On Thu, Dec 22, 2011 at 07:51:48PM +0200, KJT TOD wrote:
> Now is fixed. :)
>
> >From 42d1346b6e1c605243874437f7da0b255ef6cf08 Mon Sep 17 00:00:00 2001
> From: unknown
> Date: Mon, 5 Dec 2011 18:40:28 +0200
> Subject: [PATCH] Mpegvideo.c - 1000to2000line cleanup
Please fix your git setup to co
On Thu, Dec 22, 2011 at 07:59:38PM +0200, Felipe Contreras wrote:
> On Thu, Dec 22, 2011 at 7:08 PM, Ronald S. Bultje wrote:
> >> @@ -1086,75 +1248,93 @@ int MPV_frame_start(MpegEncContext *s,
> >> AVCodecContext *avctx)
> > [..]
> >> -/* av_log(s->avctx, AV_LOG_DEBUG, "L%p N%p C%p L%p N%p C%p
Hi,
On Thu, Dec 22, 2011 at 9:59 AM, Felipe Contreras
wrote:
> On Thu, Dec 22, 2011 at 7:08 PM, Ronald S. Bultje wrote:
>>> @@ -1086,75 +1248,93 @@ int MPV_frame_start(MpegEncContext *s,
>>> AVCodecContext *avctx)
>> [..]
>>> -/* av_log(s->avctx, AV_LOG_DEBUG, "L%p N%p C%p L%p N%p C%p type:%
Felipe Contreras writes:
> On Thu, Dec 22, 2011 at 7:51 PM, KJT TOD wrote:
>> Now is fixed. :)
>
> Isn't there some kind of guideline to send patches inlined?
There is, but it is largely ignored.
--
Måns Rullgård
m...@mansr.com
___
libav-devel maili
On Thu, Dec 22, 2011 at 7:51 PM, KJT TOD wrote:
> Now is fixed. :)
Isn't there some kind of guideline to send patches inlined?
--
Felipe Contreras
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
On Thu, Dec 22, 2011 at 7:08 PM, Ronald S. Bultje wrote:
>> @@ -1086,75 +1248,93 @@ int MPV_frame_start(MpegEncContext *s,
>> AVCodecContext *avctx)
> [..]
>> -/* av_log(s->avctx, AV_LOG_DEBUG, "L%p N%p C%p L%p N%p C%p type:%d
>> drop:%d\n", s->last_picture_ptr, s->next_picture_ptr,s->current
Hi,
On Thu, Dec 22, 2011 at 9:08 AM, Ronald S. Bultje wrote:
> On Thu, Dec 22, 2011 at 8:04 AM, KJT TOD wrote:
> [.. until hpel_motion_lowres ..]
and the rest...
> static inline int hpel_motion_lowres(MpegEncContext *s,
[..]
> +if ((unsigned)src_x > h_edge_pos - (!!sx) - w
> +
Hi,
On Thu, Dec 22, 2011 at 8:04 AM, KJT TOD wrote:
[.. until hpel_motion_lowres ..]
Hi,
> @@ -1012,31 +1161,35 @@ int ff_find_unused_picture(MpegEncContext *s, int
> shared){
[..]
> -for(i=0; i<64; i++){
> -s->dct_offset[intra][i]= (s->avctx->noise_reduction *
> s->dct_c
Hi,
On Mon, Dec 5, 2011 at 2:21 PM, KJT TOD wrote:
[..]
> diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c
> @@ -589,159 +677,205 @@ av_cold int MPV_common_init(MpegEncContext *s)
> threads = (s->encoding ||
> (HAVE_THREADS &&
> s->av
Hi,
On Mon, Dec 5, 2011 at 2:21 PM, KJT TOD wrote:
[..]
Just quickly note for Diego: don't review line 0-500, they were
already applied (in a slightly modified form). Only start at input
line 500. Or teach the student how to rebase.
Ronald
___
libav-d
0001-Code-cleanup-mpegvideo.c-0-1000lines.patch
Description: Binary data
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
Hi,
On Mon, Dec 5, 2011 at 8:45 AM, KJT TOD wrote:
[..]
> -if(!s1->first_field){
> -s->last_pict_type= s1->pict_type;
> -if (s1->current_picture_ptr) s->last_lambda_for[s1->pict_type] =
> s1->current_picture_ptr->f.quality;
> +if (!s1->first_field) {
> +s->last_pi
0001-Code-cleanup-mpegvideo.c-0-1000line.patch
Description: Binary data
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
On Mon, Dec 05, 2011 at 04:37:52PM +0200, KJT TOD wrote:
> --- a/libavcodec/mpegvideo.c
> +++ b/libavcodec/mpegvideo.c
> @@ -66,44 +66,66 @@ static void dct_unquantize_h263_inter_c(MpegEncContext *s,
>
>
> -static const uint8_t ff_default_chroma_qscale_table[32]={
> -// 0 1 2 3 4 5 6 7
0001-Code-cleanup-mpegvideo.c-0-1000line.patch
Description: Binary data
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
Оригинално писмо
От: "Ronald S. Bultje" rsbul...@gmail.com
Относно: Re: [libav-devel] Code cleanup - mpegvideo.c - first 500 lines -fix
До: libav development
Изпратено на: Събота, 2011, Декември 3 20:17:07 EET
Hi,
On Sat, Dec 3, 2011 at 6:36 A
Hi,
On Sat, Dec 3, 2011 at 6:36 AM, KJT TOD wrote:
> [..]
Patch is fine now, but you didn't provide an authorship for it. I can fix
that, but what email address/name do you want to have listed in the commit
log?
Ronald
___
libav-devel mailing list
l
0001-Code-cleanup-mpegvideo.c-first-500.patch
Description: Binary data
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
Also, if possible review the GCI task -
http://google-melange.appspot.com/gci/task/view/google/gci2011/7176259
0001-Code-cleanup-mpegvideo.c-first-500.patch
Description: Binary data
___
libav-devel mailing list
libav-devel@libav.org
https://lists.liba
On 01/12/11 12:50, KJT TOD wrote:
Using automated tools is fine as long you manage to get them working
properly.
The patch doesn't cleanup the code.
lu
--
Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero
___
libav-devel mailing list
li
20 matches
Mail list logo
