Re: [libav-devel] [PATCH] bfin: vp3: Separate VP3 initialization code

2013-01-28 Thread Diego Biurrun
On Thu, Jan 24, 2013 at 11:44:00AM +0100, Diego Biurrun wrote: On Wed, Jan 23, 2013 at 04:45:22PM +0100, Luca Barbato wrote: From: Diego Biurrun di...@biurrun.de Signed-off-by: Luca Barbato lu_z...@gentoo.org --- Rebased after the move to int16_t. En passant, adding the missing

Re: [libav-devel] [PATCH] bfin: vp3: Separate VP3 initialization code

2013-01-28 Thread Luca Barbato
On 28/01/13 20:00, Diego Biurrun wrote: On Thu, Jan 24, 2013 at 11:44:00AM +0100, Diego Biurrun wrote: On Wed, Jan 23, 2013 at 04:45:22PM +0100, Luca Barbato wrote: From: Diego Biurrun di...@biurrun.de Signed-off-by: Luca Barbato lu_z...@gentoo.org --- Rebased after the move to int16_t.

Re: [libav-devel] [PATCH] bfin: vp3: Separate VP3 initialization code

2013-01-28 Thread Ronald S. Bultje
Hi, On Mon, Jan 28, 2013 at 11:01 AM, Luca Barbato lu_z...@gentoo.org wrote: On 28/01/13 20:00, Diego Biurrun wrote: On Thu, Jan 24, 2013 at 11:44:00AM +0100, Diego Biurrun wrote: On Wed, Jan 23, 2013 at 04:45:22PM +0100, Luca Barbato wrote: From: Diego Biurrun di...@biurrun.de

Re: [libav-devel] [PATCH] bfin: vp3: Separate VP3 initialization code

2013-01-24 Thread Diego Biurrun
On Wed, Jan 23, 2013 at 04:45:22PM +0100, Luca Barbato wrote: From: Diego Biurrun di...@biurrun.de Signed-off-by: Luca Barbato lu_z...@gentoo.org --- Rebased after the move to int16_t. En passant, adding the missing memsets as pointed by Ronald. Please separate those, patch LGTM

Re: [libav-devel] [PATCH] bfin: vp3: Separate VP3 initialization code

2013-01-23 Thread Ronald S. Bultje
Hi, On Wed, Jan 23, 2013 at 7:45 AM, Luca Barbato lu_z...@gentoo.org wrote: From: Diego Biurrun di...@biurrun.de Signed-off-by: Luca Barbato lu_z...@gentoo.org --- Rebased after the move to int16_t. En passant, adding the missing memsets as pointed by Ronald. libavcodec/bfin/Makefile

Re: [libav-devel] [PATCH] bfin: vp3: Separate VP3 initialization code from general dsputil code

2013-01-21 Thread Ronald S. Bultje
Hi, On Mon, Jan 21, 2013 at 1:01 AM, Diego Biurrun di...@biurrun.de wrote: --- This is untested due to lack of a bfin cross-compilation environment. libavcodec/bfin/Makefile |4 ++-- libavcodec/bfin/dsputil_bfin.c |8 +--- libavcodec/bfin/vp3_bfin.c |6 ++

Re: [libav-devel] [PATCH] bfin: vp3: Separate VP3 initialization code

2013-01-21 Thread Luca Barbato
On 21/01/13 20:38, Luca Barbato wrote: +void ff_vp3dsp_init_bfin(VP3DSPContext *c, int flags) +{ +c-idct_add = ff_bfin_vp3_idct_add; +c-idct_put = ff_bfin_vp3_idct_put; c-idct missing. qemu-user is not really working for us sadly =\ lu

Re: [libav-devel] [PATCH] bfin: vp3: Separate VP3 initialization code

2013-01-21 Thread Luca Barbato
On 21/01/13 22:13, Luca Barbato wrote: On 21/01/13 20:38, Luca Barbato wrote: +void ff_vp3dsp_init_bfin(VP3DSPContext *c, int flags) +{ +c-idct_add = ff_bfin_vp3_idct_add; +c-idct_put = ff_bfin_vp3_idct_put; c-idct missing. Actually the idct_dc_add not sure if we can safely

Re: [libav-devel] [PATCH] bfin: vp3: Separate VP3 initialization code

2013-01-21 Thread Luca Barbato
On 21/01/13 22:43, Luca Barbato wrote: Actually the idct_dc_add not sure if we can safely mix and match them, probably we can. I'd push tomorrow the updated patch, idct_dc_add is compatible from what I can see. ___ libav-devel mailing list

Re: [libav-devel] [PATCH] bfin: vp3: Separate VP3 initialization code

2013-01-21 Thread Ronald S. Bultje
Hi, On Mon, Jan 21, 2013 at 1:13 PM, Luca Barbato lu_z...@gentoo.org wrote: On 21/01/13 20:38, Luca Barbato wrote: +void ff_vp3dsp_init_bfin(VP3DSPContext *c, int flags) +{ +c-idct_add = ff_bfin_vp3_idct_add; +c-idct_put = ff_bfin_vp3_idct_put; c-idct missing. vp3dsp has no

Re: [libav-devel] [PATCH] bfin: vp3: Separate VP3 initialization code

2013-01-21 Thread Ronald S. Bultje
Hi, On Mon, Jan 21, 2013 at 2:31 PM, Luca Barbato lu_z...@gentoo.org wrote: On 21/01/13 22:43, Luca Barbato wrote: Actually the idct_dc_add not sure if we can safely mix and match them, probably we can. I'd push tomorrow the updated patch, idct_dc_add is compatible from what I can see.