Re: [libav-devel] [PATCH 02/28] h264: move the block starting a new field out of slice_header_parse()

2016-06-17 Thread Janne Grunau
On 2016-06-09 10:29:48 +0200, Anton Khirnov wrote: > There is no bitstream parsing in that block and messing with > decoder-global state is not something that belongs into header parsing. > > Nothing else in this function depends on the value of current_slice, > except for two validity checks.

Re: [libav-devel] [PATCH 02/28] h264: move the block starting a new field out of slice_header_parse()

2016-06-11 Thread Anton Khirnov
Quoting Vittorio Giovara (2016-06-09 18:08:23) > On Thu, Jun 9, 2016 at 4:29 AM, Anton Khirnov wrote: > > There is no bitstream parsing in that block and messing with > > decoder-global state is not something that belongs into header parsing. > > > > Nothing else in this

Re: [libav-devel] [PATCH 02/28] h264: move the block starting a new field out of slice_header_parse()

2016-06-09 Thread Vittorio Giovara
On Thu, Jun 9, 2016 at 4:29 AM, Anton Khirnov wrote: > There is no bitstream parsing in that block and messing with > decoder-global state is not something that belongs into header parsing. > > Nothing else in this function depends on the value of current_slice, > except for