Re: [libav-devel] [PATCH 4/9] tools: do not use av_pix_fmt_descriptors directly.

2012-10-07 Thread Diego Biurrun
On Sat, Oct 06, 2012 at 09:44:03PM -0700, Ronald S. Bultje wrote: > On Sat, Oct 6, 2012 at 9:19 PM, Anton Khirnov wrote: > > On Sat, 6 Oct 2012 17:01:57 -0700, "Ronald S. Bultje" > > wrote: > >> On Sat, Oct 6, 2012 at 1:28 PM, Anton Khirnov wrote: > >> > And I hear there's some trouble with the

Re: [libav-devel] [PATCH 4/9] tools: do not use av_pix_fmt_descriptors directly.

2012-10-07 Thread Luca Barbato
On 10/07/2012 02:01 AM, Ronald S. Bultje wrote: > It often leads to smaller code. Instead of AVPixFmtDesc *d = > getter(pix_fmt); if (!d) return -1; printf("%d\n", d->something);, you > can just do printf("%d\n", array[pix_fmt].something);. Do we really > need to babysit our users? It can be _quit

Re: [libav-devel] [PATCH 4/9] tools: do not use av_pix_fmt_descriptors directly.

2012-10-06 Thread Derek Buitenhuis
On 07/10/2012 1:16 AM, Diego Elio Pettenò wrote: > As I said this patch makes the ABI more stable, and distributions love > ABI stability, so please do not discount it simply because your use > cases don't care about it. We already have a V8 with its own ABI problems. I have to agree with Diego an

Re: [libav-devel] [PATCH 4/9] tools: do not use av_pix_fmt_descriptors directly.

2012-10-06 Thread Diego Elio Pettenò
On 06/10/2012 22:11, Ronald S. Bultje wrote: >> > >> > The same way we can never have msvc support? > Right. > > Shall we move on to more practical patches? Sure, are we going to stop reviewing MSVC fixes? As I said this patch makes the ABI more stable, and distributions love ABI stability, so

Re: [libav-devel] [PATCH 4/9] tools: do not use av_pix_fmt_descriptors directly.

2012-10-06 Thread Ronald S. Bultje
Hi, On Sat, Oct 6, 2012 at 9:47 PM, Anton Khirnov wrote: > > On Sat, 6 Oct 2012 21:44:03 -0700, "Ronald S. Bultje" > wrote: >> Hi, >> >> On Sat, Oct 6, 2012 at 9:19 PM, Anton Khirnov wrote: >> > >> > On Sat, 6 Oct 2012 17:01:57 -0700, "Ronald S. Bultje" >> > wrote: >> >> Hi, >> >> >> >> On S

Re: [libav-devel] [PATCH 4/9] tools: do not use av_pix_fmt_descriptors directly.

2012-10-06 Thread Anton Khirnov
On Sat, 6 Oct 2012 21:44:03 -0700, "Ronald S. Bultje" wrote: > Hi, > > On Sat, Oct 6, 2012 at 9:19 PM, Anton Khirnov wrote: > > > > On Sat, 6 Oct 2012 17:01:57 -0700, "Ronald S. Bultje" > > wrote: > >> Hi, > >> > >> On Sat, Oct 6, 2012 at 1:28 PM, Anton Khirnov wrote: > >> > On Sat, 6 Oct 2

Re: [libav-devel] [PATCH 4/9] tools: do not use av_pix_fmt_descriptors directly.

2012-10-06 Thread Ronald S. Bultje
Hi, On Sat, Oct 6, 2012 at 9:19 PM, Anton Khirnov wrote: > > On Sat, 6 Oct 2012 17:01:57 -0700, "Ronald S. Bultje" > wrote: >> Hi, >> >> On Sat, Oct 6, 2012 at 1:28 PM, Anton Khirnov wrote: >> > On Sat, 6 Oct 2012 12:35:44 -0700, "Ronald S. Bultje" >> > wrote: >> >> On Sat, Oct 6, 2012 at 9:

Re: [libav-devel] [PATCH 4/9] tools: do not use av_pix_fmt_descriptors directly.

2012-10-06 Thread Anton Khirnov
On Sat, 6 Oct 2012 17:01:57 -0700, "Ronald S. Bultje" wrote: > Hi, > > On Sat, Oct 6, 2012 at 1:28 PM, Anton Khirnov wrote: > > On Sat, 6 Oct 2012 12:35:44 -0700, "Ronald S. Bultje" > > wrote: > >> On Sat, Oct 6, 2012 at 9:58 AM, Anton Khirnov wrote: > >> > --- > >> > avprobe.c |

Re: [libav-devel] [PATCH 4/9] tools: do not use av_pix_fmt_descriptors directly.

2012-10-06 Thread Diego Elio Pettenò
On 06/10/2012 17:01, Ronald S. Bultje wrote: >> > It prevents the caller from accessing all the descriptors when he's >> > using a newer library than the one he compiled against. > if (compile_ver > runtime_ver) error(); on app init. Likely, you want > to do that anyway. > Actually Anton is refer

Re: [libav-devel] [PATCH 4/9] tools: do not use av_pix_fmt_descriptors directly.

2012-10-06 Thread Ronald S. Bultje
Hi, On Sat, Oct 6, 2012 at 1:28 PM, Anton Khirnov wrote: > On Sat, 6 Oct 2012 12:35:44 -0700, "Ronald S. Bultje" > wrote: >> On Sat, Oct 6, 2012 at 9:58 AM, Anton Khirnov wrote: >> > --- >> > avprobe.c |6 +++--- >> > cmdutils.c| 16 +++- >> > tools/graph2dot

Re: [libav-devel] [PATCH 4/9] tools: do not use av_pix_fmt_descriptors directly.

2012-10-06 Thread Luca Barbato
On 10/06/2012 09:35 PM, Ronald S. Bultje wrote: > Hi, >> @@ -629,9 +630,8 @@ static void show_stream(AVFormatContext *fmt_ctx, int >> stream_idx) >>rational_string(val_str, sizeof(val_str), ":", >>&display_aspect_ratio)); >> } >>

Re: [libav-devel] [PATCH 4/9] tools: do not use av_pix_fmt_descriptors directly.

2012-10-06 Thread Luca Barbato
On 10/06/2012 06:58 PM, Anton Khirnov wrote: > --- > avprobe.c |6 +++--- > cmdutils.c| 16 +++- > tools/graph2dot.c |4 ++-- > 3 files changed, 16 insertions(+), 10 deletions(-) > Seems fine. lu ___ libav-devel

Re: [libav-devel] [PATCH 4/9] tools: do not use av_pix_fmt_descriptors directly.

2012-10-06 Thread Anton Khirnov
On Sat, 6 Oct 2012 12:35:44 -0700, "Ronald S. Bultje" wrote: > Hi, > > On Sat, Oct 6, 2012 at 9:58 AM, Anton Khirnov wrote: > > --- > > avprobe.c |6 +++--- > > cmdutils.c| 16 +++- > > tools/graph2dot.c |4 ++-- > > 3 files changed, 16 insertions(+), 10

Re: [libav-devel] [PATCH 4/9] tools: do not use av_pix_fmt_descriptors directly.

2012-10-06 Thread Ronald S. Bultje
Hi, On Sat, Oct 6, 2012 at 9:58 AM, Anton Khirnov wrote: > --- > avprobe.c |6 +++--- > cmdutils.c| 16 +++- > tools/graph2dot.c |4 ++-- > 3 files changed, 16 insertions(+), 10 deletions(-) > > diff --git a/avprobe.c b/avprobe.c > index 16a5d29..3a3ae0f 100