Re: [libav-devel] [PATCH] rtpdec_h264: Fix a crash by removing the definition of the pixel format

2012-08-26 Thread Martin Storsjö
On Sun, 26 Aug 2012, Luca Barbato wrote: On 8/26/12 5:35 PM, Samuel Pitoiset wrote: --- This patch fixes the following crash: Program received signal EXC_BAD_ACCESS, Could not access memory. Reason: KERN_INVALID_ADDRESS at address: 0x0018 [Switching to process 16366 thread 0x651b]

Re: [libav-devel] [PATCH] rtsp: Free the rtpdec context properly

2012-08-27 Thread Martin Storsjö
On Fri, 17 Aug 2012, Martin Storsjö wrote: The condition for calling the rtpdec cleanup was broken in df8cf076c86. --- libavformat/rtsp.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index ce18610..0390862 100644 --- a/libavformat

[libav-devel] [PATCH] vf_hqdn3d: Don't declare the loop variable within the for loop

2012-08-27 Thread Martin Storsjö
This C99 feature is generally not used in the libav codebase, since it breaks building with some fringe compilers (GCC 2.95, MSVC). --- libavfilter/vf_hqdn3d.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_hqdn3d.c b/libavfilter/vf_hqdn3d.c index 535657a..

[libav-devel] [PATCH] avprobe: Get rid of ugly casts in the options table

2012-08-27 Thread Martin Storsjö
This also makes sure the function pointers are stored via the same union member as they are accessed via. --- avprobe.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/avprobe.c b/avprobe.c index 00e0ad0..3059f5e 100644 --- a/avprobe.c +++ b/avpr

[libav-devel] [PATCH] vf_hqdn3d: Remove a duplicate inline declaration

2012-08-27 Thread Martin Storsjö
Compilation seems to fail on some GCC 3.4 instances due to this duplicate declaration. --- libavfilter/vf_hqdn3d.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_hqdn3d.c b/libavfilter/vf_hqdn3d.c index 5bb896c..71b670d 100644 --- a/libavfilter/vf_hqdn3d.c ++

[libav-devel] [PATCH] h264: Check that the codec isn't null before accessing it

2012-08-28 Thread Martin Storsjö
This fixes crashes introduced by 2e8f3cbcda5, the codec can be null when called from parsers. --- This fixes the issue pointed out by Uoti in http://lists.libav.org/pipermail/libav-devel/2012-August/033836.html and that Samuel tried to fix differently in http://patches.libav.org/patch/26549/. lib

[libav-devel] [PATCH] sdp: Include profile-level-id for H264

2012-08-28 Thread Martin Storsjö
This is required for playback with the Stagefright RTSP framework on Android. --- libavformat/sdp.c | 12 1 file changed, 12 insertions(+) diff --git a/libavformat/sdp.c b/libavformat/sdp.c index 2304a68..b89f4b7 100644 --- a/libavformat/sdp.c +++ b/libavformat/sdp.c @@ -155,8 +155

Re: [libav-devel] [PATCH 2/2] build: add separate setting for host linker

2012-08-28 Thread Martin Storsjö
On Tue, 28 Aug 2012, Diego Biurrun wrote: On Tue, Aug 28, 2012 at 01:03:29PM +0100, Mans Rullgard wrote: --- a/configure +++ b/configure @@ -2291,6 +2293,11 @@ add_ldflags $_flags $_ldflags +probe_cc hostld "$host_ld" +host_ldflags_filter=$_flags_filter +add_host_ldflags $_flags $_ldflags +HOS

Re: [libav-devel] [PATCH 2/2] build: add separate setting for host linker

2012-08-28 Thread Martin Storsjö
On Tue, 28 Aug 2012, Mans Rullgard wrote: This adds new HOSTLD and related settings for host linker allowing it to be different from HOSTCC. Signed-off-by: Mans Rullgard --- Makefile | 2 +- common.mak | 2 +- configure | 15 --- 3 files changed, 14 insertions(+), 5 deletions(-)

Re: [libav-devel] [PATCH] rtp: Depacketization of JPEG

2012-08-28 Thread Martin Storsjö
On Sat, 25 Aug 2012, Samuel Pitoiset wrote: --- You can test it by using the following link: rtsp://elmer.tapir.caltech.edu/Lecture6_tape1_web.mov However, the server seems a little weird because sometimes it fails the connection and lot of packets are missed... I tested that link with QuickTim

Re: [libav-devel] [PATCH] build: allow non-standard variations of linker -l/-L flags

2012-08-28 Thread Martin Storsjö
On Tue, 28 Aug 2012, Mans Rullgard wrote: This enables replacing the -l and -L flags used to specify the just-built libraries when linking the tools and shared libs with non-standard syntaxes. System library flags are already handled by the filtering mechanism in configure. Signed-off-by: Mans

[libav-devel] [PATCH] audio_frame_queue: Define af_queue_log_state before using it

2012-08-28 Thread Martin Storsjö
This fixes building with DEBUG defined after the function was made static and the prototype removed in d7f9786cbc. --- libavcodec/audio_frame_queue.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/libavcodec/audio_frame_queue.c b/libavcodec

Re: [libav-devel] [PATCH] sdp: Include profile-level-id for H264

2012-08-28 Thread Martin Storsjö
On Tue, 28 Aug 2012, Diego Elio Pettenò wrote: On 28/08/2012 04:59, Martin Storsjö wrote: const char *pset_string = "; sprop-parameter-sets="; +const char *profile_string = "; profile-level-id="; Any particular reasons why these are not `static const char name[

[libav-devel] [PATCH] sdp: Use static const char arrays instead of pointers to strings

2012-08-28 Thread Martin Storsjö
--- libavformat/sdp.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/sdp.c b/libavformat/sdp.c index 7413386..9bb4815 100644 --- a/libavformat/sdp.c +++ b/libavformat/sdp.c @@ -154,8 +154,8 @@ static char *extradata2psets(AVCodecContext *c) { char *pse

Re: [libav-devel] [PATCH v3] build: allow non-standard variations of linker -l/-L flags

2012-08-28 Thread Martin Storsjö
On Tue, 28 Aug 2012, Mans Rullgard wrote: This enables replacing the -l and -L flags used to specify the just-built libraries when linking the tools and shared libs with non-standard syntaxes. System library flags are already handled by the filtering mechanism in configure. Signed-off-by: Mans

[libav-devel] [PATCH 1/6] ismindex: Include direct.h for _mkdir on windows

2012-08-28 Thread Martin Storsjö
The Windows SDK in MSVC doesn't have mkdir, only _mkdir, and MSDN says one should include direct.h to use it. --- tools/ismindex.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/ismindex.c b/tools/ismindex.c index f6b0c6c..bf8c69d 100644 --- a/tools/ismindex.c +++

[libav-devel] [PATCH 2/6] qt-faststart: Use other seek/tell functions on MSVC than on mingw

2012-08-28 Thread Martin Storsjö
--- tools/qt-faststart.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/qt-faststart.c b/tools/qt-faststart.c index 8d2196c..f33d6fa 100644 --- a/tools/qt-faststart.c +++ b/tools/qt-faststart.c @@ -32,6 +32,9 @@ #ifdef __MINGW32__ #define fseeko(x, y, z) fseeko64(x, y, z) #defi

[libav-devel] [PATCH 3/6] testprogs: Remove unused includes

2012-08-28 Thread Martin Storsjö
--- libavcodec/motion-test.c |2 -- libswscale/colorspace-test.c |1 - 2 files changed, 3 deletions(-) diff --git a/libavcodec/motion-test.c b/libavcodec/motion-test.c index 4c80368..bc4f0da 100644 --- a/libavcodec/motion-test.c +++ b/libavcodec/motion-test.c @@ -26,8 +26,6 @@ #inclu

[libav-devel] [PATCH 4/6] tools: Include io.h for open/read/write/close if unistd.h doesn't exist

2012-08-28 Thread Martin Storsjö
--- tools/cws2fws.c |6 ++ tools/pktdumper.c |6 ++ 2 files changed, 12 insertions(+) diff --git a/tools/cws2fws.c b/tools/cws2fws.c index 68f7953..74588c1 100644 --- a/tools/cws2fws.c +++ b/tools/cws2fws.c @@ -6,11 +6,17 @@ * This utility converts compressed Macromedia Flash

[libav-devel] [PATCH 5/6] pktdumper: Add a fallback definition of PATH_MAX

2012-08-28 Thread Martin Storsjö
The MSVC headers don't define PATH_MAX by default, unless _POSIX_ is defined before including limits.h. Defining _POSIX_ makes the open/write/close function declarations go away though. --- tools/pktdumper.c |4 1 file changed, 4 insertions(+) diff --git a/tools/pktdumper.c b/tools/pktdu

[libav-devel] [PATCH 6/6] graph2dot: Use the fallback getopt implementation if needed

2012-08-28 Thread Martin Storsjö
--- tools/graph2dot.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/tools/graph2dot.c b/tools/graph2dot.c index 51a1ab1..e7f487d 100644 --- a/tools/graph2dot.c +++ b/tools/graph2dot.c @@ -18,7 +18,10 @@ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 US

Re: [libav-devel] [PATCH 1/6] ismindex: Include direct.h for _mkdir on windows

2012-08-28 Thread Martin Storsjö
On Tue, 28 Aug 2012, Måns Rullgård wrote: Martin Storsjö writes: The Windows SDK in MSVC doesn't have mkdir, only _mkdir, and MSDN says one should include direct.h to use it. --- tools/ismindex.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/isminde

Re: [libav-devel] [PATCH 5/6] pktdumper: Add a fallback definition of PATH_MAX

2012-08-29 Thread Martin Storsjö
On Tue, 28 Aug 2012, Måns Rullgård wrote: Martin Storsjö writes: The MSVC headers don't define PATH_MAX by default, unless _POSIX_ is defined before including limits.h. Defining _POSIX_ makes the open/write/close function declarations go away though. Why does this file not use stdio?

[libav-devel] [PATCH 1/3] pktdumper: Use sizeof(variable) instead of the direct buffer length

2012-08-30 Thread Martin Storsjö
Also change the snprintf size to use the full buffer, since snprintf always null-terminates the buffer. --- tools/pktdumper.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/pktdumper.c b/tools/pktdumper.c index 9243c93..fffeeeb 100644 --- a/tools/pktdumper.c +

[libav-devel] [PATCH 3/3] pktdumper: Use a custom define instead of PATH_MAX for buffers

2012-08-30 Thread Martin Storsjö
PATH_MAX is not necessarily available on all systems, e.g. it's normally not available on MSVC, and is not guaranteed to defined on a POSIX system either. --- tools/pktdumper.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/pktdumper.c b/tools/pktdumper.c index

[libav-devel] [PATCH 2/3] pktdumper: Make sure the fntemplate buffer is zero intialized

2012-08-30 Thread Martin Storsjö
The buffer is filled with a strncpy(foo, sizeof(buffer) - 1). If the size is insufficient, the last byte of the buffer needs to be zero initialized. --- tools/pktdumper.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/pktdumper.c b/tools/pktdumper.c index fffeeeb..4f1

[libav-devel] [PATCH 2/3] pktdumper: Use av_strlcpy instead of strncpy

2012-08-30 Thread Martin Storsjö
This takes care of null-terminating the buffer if it is too small, which wasn't handled properly before. --- tools/pktdumper.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/pktdumper.c b/tools/pktdumper.c index fffeeeb..f21a8e0 100644 --- a/tools/pktdumper.c +++

Re: [libav-devel] [PATCH 2/3] pktdumper: Use av_strlcpy instead of strncpy

2012-08-30 Thread Martin Storsjö
On Thu, 30 Aug 2012, Måns Rullgård wrote: Martin Storsjö writes: This takes care of null-terminating the buffer if it is too small, which wasn't handled properly before. --- tools/pktdumper.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/pktdumpe

Re: [libav-devel] [PATCH 2/3] pktdumper: Use av_strlcpy instead of strncpy

2012-08-30 Thread Martin Storsjö
On Thu, 30 Aug 2012, Martin Storsjö wrote: On Thu, 30 Aug 2012, Måns Rullgård wrote: Martin Storsjö writes: This takes care of null-terminating the buffer if it is too small, which wasn't handled properly before. --- tools/pktdumper.c |5 +++-- 1 file changed, 3 insertions(

[libav-devel] [PATCH] Rename missed cases of FF_OPT_TYPE_* to AV_OPT_TYPE_*

2012-08-31 Thread Martin Storsjö
--- libavfilter/vf_delogo.c| 14 +++--- libavfilter/vf_lut.c | 22 +++--- libavfilter/vsrc_testsrc.c | 12 ++-- 3 files changed, 24 insertions(+), 24 deletions(-) diff --git a/libavfilter/vf_delogo.c b/libavfilter/vf_delogo.c index 5e2cf48..2b4705b

[libav-devel] [PATCH] crypto: Remove a stray double space

2012-08-31 Thread Martin Storsjö
--- libavformat/crypto.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/crypto.c b/libavformat/crypto.c index 7095360..93c9f23 100644 --- a/libavformat/crypto.c +++ b/libavformat/crypto.c @@ -48,7 +48,7 @@ typedef struct { #define D AV_OPT_FLAG_DECODING_PARAM

Re: [libav-devel] [PATCH 3/3] x86: Simplify checks for CPU extensions and flags via convenience macros

2012-09-03 Thread Martin Storsjö
On Mon, 3 Sep 2012, Diego Biurrun wrote: --- No comment on the rest of the patch itself, but the comment is slightly incorrect - if you say "simplify", one would assume that it doesn't change behaviour, while afaik this is the fix for e.g. some of the fate failures (where HAVE_FMA4 == 1 but

[libav-devel] [PATCH 2/6] avopt: Store defaults for AV_OPT_TYPE_FLAGS in the i64 union member

2012-09-03 Thread Martin Storsjö
--- libavcodec/g722dec.c|2 +- libavcodec/libvpxenc.c |2 +- libavcodec/mpegvideo.h |2 +- libavcodec/options_table.h | 14 +++--- libavdevice/libcdio.c |2 +- libavfilter/vf_drawtext.c |2 +- libavformat/movenc.c|2 +- libavform

[libav-devel] [PATCH 4/6] avopt: Explicitly store float/double option defaults in .dbl

2012-09-03 Thread Martin Storsjö
--- libavcodec/ac3dec.c |2 +- libavcodec/libx264.c |8 libavfilter/af_amix.c|2 +- libavfilter/af_asyncts.c |2 +- libavresample/options.c |8 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/libavcodec/ac3dec.c b/libavcodec/ac3d

[libav-devel] [PATCH 5/6] avopt: Explicitly store rational option defaults in .dbl

2012-09-03 Thread Martin Storsjö
--- libavfilter/buffersrc.c|2 +- libavfilter/vsrc_testsrc.c |2 +- libavutil/opt.c|2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/buffersrc.c b/libavfilter/buffersrc.c index 62b9e99..8e344cb 100644 --- a/libavfilter/buffersrc.c +++ b/l

[libav-devel] [PATCH 6/6] avopt: Reorder the default_val struct, making i64 the first field

2012-09-03 Thread Martin Storsjö
--- libavutil/opt.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/opt.h b/libavutil/opt.h index 8f800fc..775267f 100644 --- a/libavutil/opt.h +++ b/libavutil/opt.h @@ -261,10 +261,10 @@ typedef struct AVOption { * the default value for scalar options

Re: [libav-devel] [PATCH 2/6] avopt: Store defaults for AV_OPT_TYPE_FLAGS in the i64 union member

2012-09-04 Thread Martin Storsjö
On Tue, 4 Sep 2012, Luca Barbato wrote: On 9/3/12 8:23 PM, Martin Storsjö wrote: --- libavcodec/g722dec.c|2 +- libavcodec/libvpxenc.c |2 +- libavcodec/mpegvideo.h |2 +- libavcodec/options_table.h | 14 +++--- libavdevice/libcdio.c |2

[libav-devel] [PATCH] adpcmenc: Calculate the IMA_QT predictor without overflow

2012-09-04 Thread Martin Storsjö
From: Michael Niedermayer Previously, the value given to put_bits was 10 bits long for positive predictors, even though 9 bits were to be written. The extra bit could in some cases overwrite existing bits in the bitstream writer cache. This fixes a failed assert in put_bits.h, when running a ver

[libav-devel] [PATCH] proresenc: Write the full value in one put_bits call

2012-09-04 Thread Martin Storsjö
Previously, the put_bits call writing the value wrote a value larger than the number of bits specified, failing asserts in debug mode. There was no actual bitstream writer corruption, since the overwritten bit already always was set to 1. --- libavcodec/proresenc.c |3 +-- 1 file changed, 1 in

[libav-devel] [PATCH] parser: Don't use pc as context for av_dlog

2012-09-04 Thread Martin Storsjö
The ParserContext class doesn't have an AVClass, required for using it as a logging class. --- libavcodec/parser.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/parser.c b/libavcodec/parser.c index 29904f9..dd2d836 100644 --- a/libavcodec/parser.c +++ b/

[libav-devel] [PATCH] proresenc: Don't free a buffer not owned by the codec

2012-09-04 Thread Martin Storsjö
The data in coded_frame isn't allocated using get_buffer, but is copied from the input frame to the encoder, so we should not try to free it ourselves. This fixes an assert failure when running in debug mode. --- libavcodec/proresenc.c |3 --- 1 file changed, 3 deletions(-) diff --git a/liba

Re: [libav-devel] [PATCH] proresenc: Don't free a buffer not owned by the codec

2012-09-04 Thread Martin Storsjö
On Tue, 4 Sep 2012, Derek Buitenhuis wrote: On 04/09/2012 7:59 AM, Martin Storsjö wrote: The data in coded_frame isn't allocated using get_buffer, but is copied from the input frame to the encoder, so we should not try to free it ourselves. This fixes an assert failure when running in

Re: [libav-devel] [PATCH] parser: Don't use pc as context for av_dlog

2012-09-04 Thread Martin Storsjö
On Tue, 4 Sep 2012, Derek Buitenhuis wrote: On 04/09/2012 7:48 AM, Martin Storsjö wrote: The ParserContext class doesn't have an AVClass, required for using it as a logging class. --- libavcodec/parser.c |8 1 file changed, 4 insertions(+), 4 deletions(-) Do we not

Re: [libav-devel] [PATCH] adpcmenc: Calculate the IMA_QT predictor without overflow

2012-09-04 Thread Martin Storsjö
On Tue, 4 Sep 2012, Kostya Shishkov wrote: On Tue, Sep 04, 2012 at 02:21:25PM +0300, Martin Storsjö wrote: From: Michael Niedermayer Previously, the value given to put_bits was 10 bits long for positive predictors, even though 9 bits were to be written. The extra bit could in some cases

Re: [libav-devel] [PATCH] proresenc: Write the full value in one put_bits call

2012-09-04 Thread Martin Storsjö
On Tue, 4 Sep 2012, Kostya Shishkov wrote: On Tue, Sep 04, 2012 at 02:36:34PM +0300, Martin Storsjö wrote: Previously, the put_bits call writing the value wrote a value larger than the number of bits specified, failing asserts in debug mode. There was no actual bitstream writer corruption

[libav-devel] [PATCH 1/5] elbg: Fix an assert

2012-09-04 Thread Martin Storsjö
From: Michael Niedermayer It seems the condition was flipped from what was intended. --- libavcodec/elbg.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/elbg.c b/libavcodec/elbg.c index 31195f3..0aa8e16 100644 --- a/libavcodec/elbg.c +++ b/libavcodec/elbg.c @@

[libav-devel] [PATCH 2/5] mpegvideo_enc: remove assert that has become obsolete with the new API

2012-09-04 Thread Martin Storsjö
From: Michael Niedermayer It now just checks uninitialized and unused data. --- libavcodec/mpegvideo_enc.c |1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index aeafb4d..77b0ab5 100644 --- a/libavcodec/mpegvideo_enc.c +++ b/libavcodec

[libav-devel] [PATCH 3/5] h264: disable assert on current_picture_ptr being null.

2012-09-04 Thread Martin Storsjö
From: Michael Niedermayer It is possible in various error pathes as well as gap handling that this has already been allocated. Its not clear why that would be a problem with the current code, thus disable the assert to avoid common assert failure when asserts are enabled. --- libavcodec/h264.c |

[libav-devel] [PATCH 4/5] mpegvideo: remove last_picture_ptr / h264 assert.

2012-09-04 Thread Martin Storsjö
From: Michael Niedermayer This assert is no longer true since h264 error concealment needs last_picture_ptr to be set. --- libavcodec/mpegvideo.c |3 --- 1 file changed, 3 deletions(-) diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c index e9aff3b..718df8b 100644 --- a/libavcode

[libav-devel] [PATCH 5/5] svq1enc: Set picture_structure correctly

2012-09-04 Thread Martin Storsjö
From: Michael Niedermayer This fixes assert failures when running in debug mode. --- libavcodec/svq1enc.c |1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/svq1enc.c b/libavcodec/svq1enc.c index 3d90558..d1a55bd 100644 --- a/libavcodec/svq1enc.c +++ b/libavcodec/svq1enc.c @@ -486

Re: [libav-devel] [PATCH 3/5] h264: disable assert on current_picture_ptr being null.

2012-09-04 Thread Martin Storsjö
On Tue, 4 Sep 2012, Benjamin Larsson wrote: On 09/04/2012 03:20 PM, Martin Storsjö wrote: From: Michael Niedermayer It is possible in various error pathes as well as gap handling that this has already been allocated. Its not clear why that would be a problem with the current code, thus

[libav-devel] [PATCH 3/5] h264: Remove an assert on current_picture_ptr being null

2012-09-04 Thread Martin Storsjö
From: Michael Niedermayer It is possible in various error paths as well as gap handling that this has already been allocated. It is not clear why that would be a problem with the current code, thus disable the assert to avoid a common assert failure when asserts are enabled. --- libavcodec/h264.

[libav-devel] [PATCH 1/4] configure: add section for libc-specific hacks

2012-09-04 Thread Martin Storsjö
From: Mans Rullgard --- configure | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/configure b/configure index c6c5c19..c2dc898 100755 --- a/configure +++ b/configure @@ -2709,9 +2709,6 @@ case $target_os in ranlib=: enable dos_path

[libav-devel] [PATCH 2/4] dsputil: workaround __VA_ARGS__ missing tokenization for MSVC

2012-09-04 Thread Martin Storsjö
From: Luca Barbato A second expansion forces the preprocessor to tokenize properly. --- libavcodec/dsputil.h | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/libavcodec/dsputil.h b/libavcodec/dsputil.h index e47cd2c..bb70428 100644 --- a/libavcodec/dsputil.h +++ b

[libav-devel] [PATCH 3/4] lavu: add snprintf(), vsnprint() and strtod() replacements for MS runtime.

2012-09-04 Thread Martin Storsjö
From: "Ronald S. Bultje" --- compat/msvcrt/snprintf.c | 63 +++ compat/strtod.c | 94 ++ configure|7 libavutil/Makefile |3 ++ 4 files changed, 167 insertions(+) create mode

[libav-devel] [PATCH 4/4] configure: Add support for MSVC cl.exe/link.exe

2012-09-04 Thread Martin Storsjö
From: "Ronald S. Bultje" Use with the following configure parameters: --cc='c99wrap cl' --ld='c99wrap link' --- These 4 patches (plus http://patches.libav.org/patch/26881/, which isn't strictly necessary but does help) are the only things that remain for using MSVC, using the new converter. ---

Re: [libav-devel] [PATCH 2/6] avopt: Store defaults for AV_OPT_TYPE_FLAGS in the i64 union member

2012-09-05 Thread Martin Storsjö
On Wed, 5 Sep 2012, Ronald S. Bultje wrote: Hi, On Mon, Sep 3, 2012 at 11:23 AM, Martin Storsjö wrote: --- libavcodec/g722dec.c|2 +- libavcodec/libvpxenc.c |2 +- libavcodec/mpegvideo.h |2 +- libavcodec/options_table.h | 14 +++--- libavdevice

Re: [libav-devel] [PATCH 4/4] configure: Add support for MSVC cl.exe/link.exe

2012-09-05 Thread Martin Storsjö
On Wed, 5 Sep 2012, Diego Biurrun wrote: On Tue, Sep 04, 2012 at 11:47:23PM +0300, Martin Storsjö wrote: From: "Ronald S. Bultje" Use with the following configure parameters: --cc='c99wrap cl' --ld='c99wrap link' This should be documented somewhere at some poi

Re: [libav-devel] [PATCH] avcodec: parser: Drop some broken av_dlog calls

2012-09-05 Thread Martin Storsjö
On Wed, 5 Sep 2012, Diego Biurrun wrote: --- With this patch applied the fate-vsynth1-mpeg2-ivlc-qprd passes even in debug mode, it was segfaulting before, and all of FATE passes with -DDEBUG in CFLAGS. The only thing broken about the av_dlog calls is the log context (which doesn't have an AV

Re: [libav-devel] [PATCH 3/5] h264: Remove an assert on current_picture_ptr being null

2012-09-05 Thread Martin Storsjö
On Tue, 4 Sep 2012, Martin Storsjö wrote: From: Michael Niedermayer It is possible in various error paths as well as gap handling that this has already been allocated. It is not clear why that would be a problem with the current code, thus disable the assert to avoid a common assert failure

[libav-devel] [PATCH] avopt: fix examples to match the same style about default values as the actual code.

2012-09-05 Thread Martin Storsjö
From: Michael Niedermayer --- libavutil/opt.h |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavutil/opt.h b/libavutil/opt.h index 775267f..ca13682 100644 --- a/libavutil/opt.h +++ b/libavutil/opt.h @@ -64,7 +64,7 @@ * * static const AVOption options[] = {

[libav-devel] [PATCH] fate: Allow setting the variable notest for build-only configurations

2012-09-05 Thread Martin Storsjö
--- tests/fate.sh |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate.sh b/tests/fate.sh index e04c871..c267182 100755 --- a/tests/fate.sh +++ b/tests/fate.sh @@ -107,6 +107,6 @@ mkdir -p ${build} configure >configure.log 2>&1 || fail $? "error configuring" compil

[libav-devel] [PATCH] configure: Disable some more warnings in MSVC

2012-09-05 Thread Martin Storsjö
This disables the following warnings: C4100: unreferenced formal parameter (1035 occurrances) C4214: nonstandard extension used : bit field types other than int (609 occurances) C4996: 'avpriv_snprintf': This function or variable may be unsafe. Consider using _snprintf_s instead. To disabl

[libav-devel] [PATCH] fate: Allow setting the ld parameter from the config file

2012-09-05 Thread Martin Storsjö
--- tests/fate.sh |1 + 1 file changed, 1 insertion(+) diff --git a/tests/fate.sh b/tests/fate.sh index b95b222..411fa28 100755 --- a/tests/fate.sh +++ b/tests/fate.sh @@ -49,6 +49,7 @@ configure()( ${cpu:+--cpu="$cpu"}\ ${cross_pr

Re: [libav-devel] [PATCH] mov_chan: Fix a crash in ff_mov_read_chan()

2012-09-06 Thread Martin Storsjö
On Wed, 5 Sep 2012, Samuel Pitoiset wrote: --- This patch fixes the following crash: Program received signal EXC_BAD_ACCESS, Could not access memory. Reason: KERN_INVALID_ADDRESS at address: 0x0018 [Switching to process 17337 thread 0x661b] avio_rb32 (s=0x0) at aviobuf.c:552 552 uns

Re: [libav-devel] [PATCH] rtp: Depacketization of JPEG

2012-09-06 Thread Martin Storsjö
On Wed, 5 Sep 2012, Samuel Pitoiset wrote: +/* JFIF header */ +put_marker(&pbc, APP0); +put_bits(&pbc, 16, 16); +ff_put_string(&pbc, "JFIF", 1); This uses libavcodec private symbols that can't be accessed from libavformat like this (try building with --enable-shared on linux,

Re: [libav-devel] [PATCH] fate: Allow setting the variable notest for build-only configurations

2012-09-06 Thread Martin Storsjö
On Wed, 5 Sep 2012, Diego Biurrun wrote: On Wed, Sep 05, 2012 at 08:43:46PM +0300, Martin Storsjö wrote: --- a/tests/fate.sh +++ b/tests/fate.sh @@ -107,6 +107,6 @@ mkdir -p ${build} configure >configure.log 2>&1 || fail $? "error configuring" compile >compile.log

[libav-devel] [PATCH] configure: Set the right cc_e flags for msvc

2012-09-06 Thread Martin Storsjö
The default ones work, but outputs the preprocessed file on stdout (into config.log). --- This requires an updated c99wrap (pushed to git master right now) that handles the -Fi parameter properly. --- configure |1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 25a5

Re: [libav-devel] [PATCH] mov_chan: Fix a crash in ff_mov_read_chan()

2012-09-06 Thread Martin Storsjö
On Thu, 6 Sep 2012, Samuel Pitoiset wrote: --- This patch fixes the following crash: Program received signal EXC_BAD_ACCESS, Could not access memory. Reason: KERN_INVALID_ADDRESS at address: 0x0018 [Switching to process 17337 thread 0x661b] avio_rb32 (s=0x0) at aviobuf.c:552 552 uns

Re: [libav-devel] [PATCH 2/2] rtp: Depacketization of JPEG (RFC 2435)

2012-09-06 Thread Martin Storsjö
On Thu, 6 Sep 2012, Samuel Pitoiset wrote: --- Changelog| 1 + libavformat/Makefile | 1 + libavformat/rtpdec.c | 1 + libavformat/rtpdec_formats.h | 1 + libavformat/rtpdec_jpeg.c| 330 +++ libavformat/version.h

Re: [libav-devel] [PATCH 2/2] rtp: Depacketization of JPEG (RFC 2435)

2012-09-06 Thread Martin Storsjö
On Thu, 6 Sep 2012, Samuel Pitoiset wrote: On Thu, Sep 6, 2012 at 3:00 PM, Martin Storsjö wrote: On Thu, 6 Sep 2012, Samuel Pitoiset wrote: --- Changelog| 1 + libavformat/Makefile | 1 + libavformat/rtpdec.c | 1 + libavformat/rtpdec_formats.h | 1

Re: [libav-devel] [PATCH 1/2] mjpeg: Rename some symbols to avpriv_* instead of ff_*

2012-09-06 Thread Martin Storsjö
On Thu, 6 Sep 2012, Samuel Pitoiset wrote: These symbols will be used from the RTP/JPEG depacketizer. --- libavcodec/mjpeg.c | 63 - libavcodec/mjpeg.h | 76 ++--- libavcodec/mjpeg2jpeg_bsf.c | 12 +++

[libav-devel] [PATCH 1/3] os_support: Handle the windows variant of mkdir

2012-09-06 Thread Martin Storsjö
--- libavformat/os_support.h |7 +++ 1 file changed, 7 insertions(+) diff --git a/libavformat/os_support.h b/libavformat/os_support.h index 8e2eb83..533b06b 100644 --- a/libavformat/os_support.h +++ b/libavformat/os_support.h @@ -38,6 +38,13 @@ # define fstat(f,s) _fstati64((f), (s)) #

[libav-devel] [PATCH 2/3] file: Don't set O_TRUNC when opening files in RW mode

2012-09-06 Thread Martin Storsjö
This allows opening an existing file for updating. Is combo used by anything already, which this breaks? --- libavformat/file.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/file.c b/libavformat/file.c index 0e3577d..c42dfe9 100644 --- a/libavformat/file.c +++

[libav-devel] [PATCH 3/3] Add a smooth streaming segmenter muxer

2012-09-06 Thread Martin Storsjö
This muxer splits the output from the ismv muxer into individual files, in realtime. The same can also be done by the standalone tool ismindex, but this muxer is needed for doing it in realtime (especially for live streams that need extra handling for updating the lookahead fields in the fragment

Re: [libav-devel] [PATCH 2/3] file: Don't set O_TRUNC when opening files in RW mode

2012-09-06 Thread Martin Storsjö
On Thu, 6 Sep 2012, Måns Rullgård wrote: Martin Storsjö writes: This allows opening an existing file for updating. Is combo used by anything already, which this breaks? --- libavformat/file.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/file.c b

Re: [libav-devel] [PATCH 1/3] os_support: Handle the windows variant of mkdir

2012-09-06 Thread Martin Storsjö
On Thu, 6 Sep 2012, Måns Rullgård wrote: Martin Storsjö writes: --- libavformat/os_support.h |7 +++ 1 file changed, 7 insertions(+) diff --git a/libavformat/os_support.h b/libavformat/os_support.h index 8e2eb83..533b06b 100644 --- a/libavformat/os_support.h +++ b/libavformat

Re: [libav-devel] [PATCH] mov_chan: Fix a crash in ff_mov_read_chan()

2012-09-07 Thread Martin Storsjö
On Thu, 6 Sep 2012, Martin Storsjö wrote: On Thu, 6 Sep 2012, Samuel Pitoiset wrote: --- This patch fixes the following crash: Program received signal EXC_BAD_ACCESS, Could not access memory. Reason: KERN_INVALID_ADDRESS at address: 0x0018 [Switching to process 17337 thread

[libav-devel] [PATCH 1/2] avconv: Get the default channel layout before deciding whether to reinit resampling

2012-09-07 Thread Martin Storsjö
For demuxers/decoders that reset the channel layout regularly (e.g. rtpdec_qt) to a default value of 0, we avoid reinitializing the resampling needlessly, since the call to guess_input_channel_layout within the resample_changed block would end up with the same channel layout anyway. Does this make

[libav-devel] [PATCH 2/2] avplay: Get the default channel layout before deciding whether to resample

2012-09-07 Thread Martin Storsjö
The default channel layout is guessed at startup, but this is required if the demuxer/decoder resets the channel layout back to 0/unknown regularly. --- avplay.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/avplay.c b/avplay.c index 0c642e0..6f8f2cb 100644 --- a/avplay.c +++ b/avplay.c

[libav-devel] [PATCH 1/2] mov_chan: Reindent an incorrectly indented line

2012-09-07 Thread Martin Storsjö
--- libavformat/mov_chan.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mov_chan.c b/libavformat/mov_chan.c index 800bb10..b1fa13f 100644 --- a/libavformat/mov_chan.c +++ b/libavformat/mov_chan.c @@ -580,7 +580,7 @@ int ff_mov_read_chan(AVFormatContext *s, AVI

[libav-devel] [PATCH 2/2] mov_chan: Only set the channel_layout if setting it to a nonzero value

2012-09-07 Thread Martin Storsjö
If regularly parsing new chan atoms (as in rtpdec_qt), but the chan atoms don't actually contain any channel layout, don't reset the value that the caller has filled in (by guessing). --- This is an alternative solution to the patches for avconv/avplay. --- libavformat/mov_chan.c |7 --- 1

Re: [libav-devel] [PATCH 1/3] os_support: Handle the windows variant of mkdir

2012-09-07 Thread Martin Storsjö
On Fri, 7 Sep 2012, Måns Rullgård wrote: Martin Storsjö writes: On Thu, 6 Sep 2012, Måns Rullgård wrote: Martin Storsjö writes: --- libavformat/os_support.h |7 +++ 1 file changed, 7 insertions(+) diff --git a/libavformat/os_support.h b/libavformat/os_support.h index 8e2eb83

Re: [libav-devel] [PATCH 2/3] file: Don't set O_TRUNC when opening files in RW mode

2012-09-07 Thread Martin Storsjö
On Fri, 7 Sep 2012, Måns Rullgård wrote: Martin Storsjö writes: On Thu, 6 Sep 2012, Måns Rullgård wrote: Martin Storsjö writes: This allows opening an existing file for updating. Is combo used by anything already, which this breaks? --- libavformat/file.c |2 +- 1 file changed, 1

Re: [libav-devel] [PATCH 1/2] mjpeg: Rename some symbols to avpriv_* instead of ff_*

2012-09-07 Thread Martin Storsjö
On Thu, 6 Sep 2012, Samuel Pitoiset wrote: These symbols will be used from the RTP/JPEG depacketizer. --- libavcodec/mjpeg.c | 14 +++--- libavcodec/mjpeg.h | 14 +++--- libavcodec/mjpeg2jpeg_bsf.c | 12 ++-- libavcodec/mjpegdec.c | 24 ---

Re: [libav-devel] [PATCH] [WIP] rtp: Packetization of JPEG (RFC 2435)

2012-09-07 Thread Martin Storsjö
On Thu, 6 Sep 2012, Samuel Pitoiset wrote: --- TODO: 1) Do not hardcoded video pixel dimensions (any ideas ?) s1->streams[0]->codec->width/height 2) QuickTimePlayer doesn't play the video --- Changelog | 1 + libavformat/Makefile | 1 + libavformat/rtpenc.c | 6 +++

Re: [libav-devel] [PATCH 2/2] mov_chan: Only set the channel_layout if setting it to a nonzero value

2012-09-07 Thread Martin Storsjö
On Fri, 7 Sep 2012, Diego Biurrun wrote: On Fri, Sep 07, 2012 at 10:59:26AM +0300, Martin Storsjö wrote: --- a/libavformat/mov_chan.c +++ b/libavformat/mov_chan.c @@ -579,9 +579,10 @@ int ff_mov_read_chan(AVFormatContext *s, AVIOContext *pb, AVStream *st, -if (layout_tag == 0

Re: [libav-devel] [PATCH 2/2] rtp: Depacketization of JPEG (RFC 2435)

2012-09-07 Thread Martin Storsjö
On Fri, 7 Sep 2012, Samuel Pitoiset wrote: --- Fix build with --disable-everything --enable-demuxer=rtsp --- Changelog| 1 + configure| 2 +- libavformat/Makefile | 1 + libavformat/rtpdec.c | 1 + libavformat/rtpdec_formats.h | 1 + l

Re: [libav-devel] [PATCH 1/2] x86: avcodec: Drop silly "_mmx" suffix from dsputil template names

2012-09-07 Thread Martin Storsjö
On Mon, 3 Sep 2012, Diego Biurrun wrote: --- ...l_mmx_avg_template.c => dsputil_avg_template.c} |0 libavcodec/x86/dsputil_mmx.c |8 ...l_mmx_qns_template.c => dsputil_qns_template.c} |0 ...l_mmx_rnd_template.c => dsputil_rnd_template.c} |0 libavcodec

Re: [libav-devel] [PATCH 1/2] avconv: Get the default channel layout before deciding whether to reinit resampling

2012-09-07 Thread Martin Storsjö
On Fri, 7 Sep 2012, Justin Ruggles wrote: On 09/07/2012 03:57 AM, Martin Storsjö wrote: For demuxers/decoders that reset the channel layout regularly (e.g. rtpdec_qt) to a default value of 0, we avoid reinitializing the resampling needlessly, since the call to guess_input_channel_layout within

Re: [libav-devel] [PATCH 1/2] configure: msvc: Always cause an error on implicit function declarations.

2012-09-08 Thread Martin Storsjö
On Sat, 8 Sep 2012, Måns Rullgård wrote: Hendrik Leppkes writes: On Sat, Sep 8, 2012 at 12:09 PM, Ronald S. Bultje wrote: This sounds like the wrong fix tbh. The first chunk looks OK but wouldn't other systems, eg old GCC versions, be similarly affected? Shouldn't the true fix live elsewhe

Re: [libav-devel] [PATCH 1/2] configure: msvc: Always cause an error on implicit function declarations.

2012-09-08 Thread Martin Storsjö
On Sat, 8 Sep 2012, Måns Rullgård wrote: Martin Storsjö writes: On Sat, 8 Sep 2012, Måns Rullgård wrote: Hendrik Leppkes writes: On Sat, Sep 8, 2012 at 12:09 PM, Ronald S. Bultje wrote: This sounds like the wrong fix tbh. The first chunk looks OK but wouldn't other systems, e

Re: [libav-devel] [PATCH 1/2] configure: msvc: Always cause an error on implicit function declarations.

2012-09-08 Thread Martin Storsjö
On Sat, 8 Sep 2012, Måns Rullgård wrote: Hendrik Leppkes writes: On Sat, Sep 8, 2012 at 1:40 PM, Martin Storsjö wrote: On Sat, 8 Sep 2012, Måns Rullgård wrote: Hendrik Leppkes writes: On Sat, Sep 8, 2012 at 12:09 PM, Ronald S. Bultje wrote: This sounds like the wrong fix tbh

Re: [libav-devel] [PATCH] configure: msvc: fix/simplify setting of flags for hostcc

2012-09-08 Thread Martin Storsjö
On Fri, 7 Sep 2012, Mans Rullgard wrote: Signed-off-by: Mans Rullgard --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 25a56e7..61d8012 100755 --- a/configure +++ b/configure @@ -2323,7 +2323,7 @@ probe_cc(){ _flags='-nologo'

[libav-devel] [PATCH] swscale: Provide the right alignment for external mmx asm

2012-09-08 Thread Martin Storsjö
This reverts parts of e0c6cce4472. There is external mmx asm that requires this alignment. This fixes crashes when using swscale in builds with external mmx, without inline assembly. --- libswscale/utils.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libswscale/uti

[libav-devel] [PATCH] Rename ff_put_string to avpriv_put_string

2012-09-09 Thread Martin Storsjö
This allows using it from libavformat as well. This will be used by the RTP/JPEG depacketizer. --- libavcodec/bitstream.c |2 +- libavcodec/mjpegenc.c |6 +++--- libavcodec/mpeg4videoenc.c |2 +- libavcodec/put_bits.h |4 ++-- 4 files changed, 7 insertions(+), 7 delet

Re: [libav-devel] [PATCH 2/2] rtp: Depacketization of JPEG (RFC 2435)

2012-09-09 Thread Martin Storsjö
On Fri, 7 Sep 2012, Samuel Pitoiset wrote: --- Changelog| 1 + libavcodec/Makefile | 1 + libavformat/Makefile | 1 + libavformat/rtpdec.c | 1 + libavformat/rtpdec_formats.h | 1 + libavformat/rtpdec_jpeg.c| 331 +

Re: [libav-devel] [PATCH 1/3] os_support: Handle the windows variant of mkdir

2012-09-09 Thread Martin Storsjö
On Fri, 7 Sep 2012, Martin Storsjö wrote: On Fri, 7 Sep 2012, Måns Rullgård wrote: Martin Storsjö writes: On Thu, 6 Sep 2012, Måns Rullgård wrote: Martin Storsjö writes: --- libavformat/os_support.h |7 +++ 1 file changed, 7 insertions(+) diff --git a/libavformat

Re: [libav-devel] [PATCH] Rename ff_put_string to avpriv_put_string

2012-09-09 Thread Martin Storsjö
On Sun, 9 Sep 2012, Martin Storsjö wrote: This allows using it from libavformat as well. This will be used by the RTP/JPEG depacketizer. --- libavcodec/bitstream.c |2 +- libavcodec/mjpegenc.c |6 +++--- libavcodec/mpeg4videoenc.c |2 +- libavcodec/put_bits.h |4

[libav-devel] [PATCH 1/4] file: Use a normal private context for storing the file descriptor

2012-09-09 Thread Martin Storsjö
Previously the file descriptor was stored in the priv_data pointer. --- libavformat/file.c | 33 + 1 file changed, 21 insertions(+), 12 deletions(-) diff --git a/libavformat/file.c b/libavformat/file.c index 0e3577d..3cfd28c 100644 --- a/libavformat/file.c +++ b/

  1   2   3   4   5   6   7   8   9   10   >