Re: [Libav-user] EXR channel support?

2014-02-15 Thread Paul B Mahol
On 2/16/14, Gonzalo Garramuno wrote: > On 15/02/14 20:02, Paul B Mahol wrote: >> I'm not clear enough: AVClass is missing in EXRContext struct. > Thanks for the explanation. Now it all works fine. What's the proper > way to submit a patch to get it added; this being my first contribution > to ff

Re: [Libav-user] EXR channel support?

2014-02-15 Thread Gonzalo Garramuno
On 15/02/14 20:02, Paul B Mahol wrote: I'm not clear enough: AVClass is missing in EXRContext struct. Thanks for the explanation. Now it all works fine. What's the proper way to submit a patch to get it added; this being my first contribution to ffmpeg. Should I send it here or at ffmpeg-dev

Re: [Libav-user] EXR channel support?

2014-02-15 Thread Paul B Mahol
On 2/15/14, Gonzalo Garramuno wrote: > Here's the final patch that works out the layers for exr. This patch > works fine if run under valgrind but segfaults otherwise if run > normally. The problem appears to be the parsing of options (and thus in > my options definition I guess). Commenting ou

Re: [Libav-user] EXR channel support?

2014-02-15 Thread Gonzalo Garramuno
Here's the final patch that works out the layers for exr. This patch works fine if run under valgrind but segfaults otherwise if run normally. The problem appears to be the parsing of options (and thus in my options definition I guess). Commenting out: priv_class = &exr_class, makes it work

Re: [Libav-user] EXR channel support?

2014-02-15 Thread Gonzalo Garramuno
On 15/02/14 18:09, Paul B Mahol wrote: On 2/15/14, Gonzalo Garramuno wrote: On 15/02/14 04:56, Paul B Mahol wrote: Also the layer option is not used at all Here's a patch with layer being printed that segfaults. It seems the field is never initialized nor parsed, even though command-lin

Re: [Libav-user] EXR channel support?

2014-02-15 Thread Paul B Mahol
On 2/15/14, Gonzalo Garramuno wrote: > On 15/02/14 04:56, Paul B Mahol wrote: >> Also the layer option is not used at all >> > > Here's a patch with layer being printed that segfaults. It seems the > field is never initialized nor parsed, even though command-line works. > AVClass is still mi

Re: [Libav-user] EXR channel support?

2014-02-15 Thread Gonzalo Garramuno
On 15/02/14 04:56, Paul B Mahol wrote: Also the layer option is not used at all Here's a patch with layer being printed that segfaults. It seems the field is never initialized nor parsed, even though command-line works. diff --git a/libavcodec/exr.c b/libavcodec/exr.c index f231b70..0d3a

Re: [Libav-user] EXR channel support?

2014-02-15 Thread Gonzalo Garramuno
On 15/02/14 04:56, Paul B Mahol wrote: On 2/15/14, Paul B Mahol wrote: Also the layer option is not used at all Yes, I know. I tried just printing it with av_log and it crashes with segfault. The layer option works fine command-line (it asks for a string), but the EXRContext->layer nev