[Libevent-users] patch to use different return value for event_base_loop()

2009-08-11 Thread Ka-Hing Cheung
Attached is a patch that makes event_base_loop() return 2 if it returns because of a prior call to event_base_loopexit() or event_base_loopbreak(). This is useful when the caller calls event_base_loop(base, EVLOOP_ONCE) repeatedly (to do stuff in between events) and need to know if it should exit.

Re: [Libevent-users] patch to use different return value for event_base_loop()

2009-08-12 Thread q6Yr7e0o nIJDVMjC
Hi, one general question, why do you use #defines instead of enums? ___ Libevent-users mailing list Libevent-users@monkey.org http://monkeymail.org/mailman/listinfo/libevent-users

Re: [Libevent-users] patch to use different return value for event_base_loop()

2009-08-12 Thread Ka-Hing Cheung
On Wed, 2009-08-12 at 02:50 -0700, q6Yr7e0o nIJDVMjC wrote: > Hi, > > > one general question, why do you use #defines instead of enums? Because the constants right above are also #defines, so I just follow the existing practice. -khc ___ Libevent-us

Re: [Libevent-users] patch to use different return value for event_base_loop()

2009-08-12 Thread William Ahern
On Wed, Aug 12, 2009 at 10:27:15AM -0700, Ka-Hing Cheung wrote: > On Wed, 2009-08-12 at 02:50 -0700, q6Yr7e0o nIJDVMjC wrote: > > Hi, > > > > > > one general question, why do you use #defines instead of enums? > > Because the constants right above are also #defines, so I just follow > the existi

Re: [Libevent-users] patch to use different return value for event_base_loop()

2009-08-12 Thread Ka-Hing Cheung
On Tue, 2009-08-11 at 16:25 -0700, Ka-Hing Cheung wrote: > Attached is a patch that makes event_base_loop() return 2 if it returns > because of a prior call to event_base_loopexit() or > event_base_loopbreak(). This is useful when the caller calls > event_base_loop(base, EVLOOP_ONCE) repeatedly (to

Re: [Libevent-users] patch to use different return value for event_base_loop()

2009-08-13 Thread Nick Mathewson
On Wed, Aug 12, 2009 at 11:42:47AM -0700, Ka-Hing Cheung wrote: [...] > I do realize that this breaks existing assumptions about return values. > What if instead of using a different return value, we don't reset > base->event_gotterm and base->event_break when triggered? We can reset > them at the

Re: [Libevent-users] patch to use different return value for event_base_loop()

2009-08-13 Thread Ka-Hing Cheung
On Thu, 2009-08-13 at 09:16 -0700, Nick Mathewson wrote: > On Wed, Aug 12, 2009 at 11:42:47AM -0700, Ka-Hing Cheung wrote: > [...] > > I do realize that this breaks existing assumptions about return values. > > What if instead of using a different return value, we don't reset > > base->event_gotte