[Libguestfs] [PATCH] Fix, simplify out-of-tree build/install for bash completions

2014-10-31 Thread Hilko Bengen
--- bash/Makefile.am | 54 +++--- 1 file changed, 15 insertions(+), 39 deletions(-) diff --git a/bash/Makefile.am b/bash/Makefile.am index 10f0861..780da64 100644 --- a/bash/Makefile.am +++ b/bash/Makefile.am @@ -21,6 +21,10 @@ scripts = \ g

Re: [Libguestfs] [PATCH] fish: fix dir completion on filesystems w/o dirent.d_type (RHBZ#1153844).

2014-10-31 Thread Pino Toscano
On Friday 31 October 2014 17:07:24 Richard W.M. Jones wrote: > On Fri, Oct 31, 2014 at 05:56:10PM +0100, Pino Toscano wrote: > > On filesystems whose dirent.d_type is DT_UNKNOWN or some unknown > > value, manually check whether an entry is a directory, thus > > completing in the proper way. > > Ha

[Libguestfs] [PATCH 3/3] autotools: add fish/test

2014-10-31 Thread mzatko
From: Maros Zatko --- Makefile.am | 1 + configure.ac | 1 + 2 files changed, 2 insertions(+) diff --git a/Makefile.am b/Makefile.am index d55d8d6..629b787 100644 --- a/Makefile.am +++ b/Makefile.am @@ -78,6 +78,7 @@ SUBDIRS += test-tool # Guestfish. SUBDIRS += fish +SUBDIRS += fish/test

[Libguestfs] [PATCH 1/3] fish: rl.{c, h} - escaping functions for readline

2014-10-31 Thread mzatko
From: Maros Zatko --- fish/rl.c | 158 ++ fish/rl.h | 32 + 2 files changed, 190 insertions(+) create mode 100644 fish/rl.c create mode 100644 fish/rl.h diff --git a/fish/rl.c b/fish/rl.c new file mode 100644 index 0

[Libguestfs] [PATCH 0/3] WIP readline escaping functions

2014-10-31 Thread mzatko
From: Maros Zatko Auxiliary functions for readline to support space character escaping in filenames in future. Escaping function is taken from fish.c (used to be parse_quoted_string) plus its un-escaping counterpart. There are a few tests for both. Maros Zatko (3): fish: rl.{c,h} - escaping f

[Libguestfs] [PATCH 2/3] fish: basic tests for readline escaping

2014-10-31 Thread mzatko
From: Maros Zatko --- fish/test/Makefile.am | 39 fish/test/testquoting.c | 120 2 files changed, 159 insertions(+) create mode 100644 fish/test/Makefile.am create mode 100644 fish/test/testquoting.c diff --git a/fish/test/M

Re: [Libguestfs] [PATCH] fish: fix dir completion on filesystems w/o dirent.d_type (RHBZ#1153844).

2014-10-31 Thread Richard W.M. Jones
On Fri, Oct 31, 2014 at 05:56:10PM +0100, Pino Toscano wrote: > On filesystems whose dirent.d_type is DT_UNKNOWN or some unknown value, > manually check whether an entry is a directory, thus completing in the > proper way. Happens on Windows (NTFS) too, and it's also annoying there ... > --- > f

Re: [Libguestfs] [PATCH] fish: complete symlink properly

2014-10-31 Thread Richard W.M. Jones
On Fri, Oct 31, 2014 at 05:56:11PM +0100, Pino Toscano wrote: > When an entry is a symlink, check whether it points to a directory, so > the entry for it can be completed correctly. > --- > fish/destpaths.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fish/destpaths.c b/fish/destpaths

[Libguestfs] [PATCH] fish: complete symlink properly

2014-10-31 Thread Pino Toscano
When an entry is a symlink, check whether it points to a directory, so the entry for it can be completed correctly. --- fish/destpaths.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fish/destpaths.c b/fish/destpaths.c index df1ec00..d39d6c0 100644 --- a/fish/destpaths.c +++ b/fish/destpaths

[Libguestfs] [PATCH] fish: fix dir completion on filesystems w/o dirent.d_type (RHBZ#1153844).

2014-10-31 Thread Pino Toscano
On filesystems whose dirent.d_type is DT_UNKNOWN or some unknown value, manually check whether an entry is a directory, thus completing in the proper way. --- fish/destpaths.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/fish/destpaths.c b/fish/destpaths.c index f2241

Re: [Libguestfs] [PATCH] builder: pass Sources.source objects directly

2014-10-31 Thread Richard W.M. Jones
On Fri, Oct 31, 2014 at 04:30:17PM +0100, Pino Toscano wrote: > -let get_index ~prog ~verbose ~downloader ~sigchecker ~proxy source = > +let get_index ~prog ~verbose ~downloader ~sigchecker { Sources.uri; proxy; } > = I have a feeling that 'proxy;' is a OCaml 4-ism, so it probably wouldn't work o

Re: [Libguestfs] [PATCH] builder: move the gpgkey_type type from Sigchecker to Utils

2014-10-31 Thread Richard W.M. Jones
On Fri, Oct 31, 2014 at 04:30:15PM +0100, Pino Toscano wrote: > No functional change, just code motion. > --- > builder/builder.ml | 6 +++--- > builder/list_entries.ml | 12 ++-- > builder/list_entries.mli | 2 +- > builder/sigchecker.ml| 5 - > builder/sigchecker.mli

[Libguestfs] [PATCH] v2v: -o libvirt: Get the right in the output XML (RHBZ#1159258).

2014-10-31 Thread Richard W.M. Jones
Implement what old virt-v2v did (from lib/Sys/VirtConvert/Connection/LibVirtTarget.pm) Thanks: Tingting Zheng, Matthew Booth --- v2v/output_libvirt.ml | 118 ++--- v2v/output_libvirt.mli | 2 +- v2v/output_local.ml| 13 +- v2v/test-v2v-i-ova

[Libguestfs] [PATCH] builder: pass Sources.source objects directly

2014-10-31 Thread Pino Toscano
Instead of passing the (uri, key, proxy) tuple around, pass the whole Sources.source record; this requires creating proper Sources.source also for uri+fingerprint passed via command line. No functional changes. --- builder/Makefile.am | 2 +- builder/builder.ml | 17 +

[Libguestfs] [PATCH] builder: move the gpgkey_type type from Sigchecker to Utils

2014-10-31 Thread Pino Toscano
No functional change, just code motion. --- builder/builder.ml | 6 +++--- builder/list_entries.ml | 12 ++-- builder/list_entries.mli | 2 +- builder/sigchecker.ml| 5 - builder/sigchecker.mli | 7 +-- builder/utils.ml | 5 + 6 files changed, 16 inser

[Libguestfs] [PATCH] builder: use gpgkey_type for the gpgkey field in sources

2014-10-31 Thread Pino Toscano
--- builder/builder.ml | 4 builder/sources.ml | 8 builder/sources.mli | 2 +- 3 files changed, 5 insertions(+), 9 deletions(-) diff --git a/builder/builder.ml b/builder/builder.ml index 9a77a23..af61538 100644 --- a/builder/builder.ml +++ b/builder/builder.ml @@ -152,10 +152,6 @

[Libguestfs] [PATCH v2] launch: libvirt: Implement drive secrets (RHBZ#1159016).

2014-10-31 Thread Richard W.M. Jones
Since v1: - Base64 decode the Ceph secret before passing it to libvirt. - Don't call virSecretFree (NULL) [libvirt bug?] - Small cleanups. ___ Libguestfs mailing list Libguestfs@redhat.com https://www.redhat.com/mailman/listinfo/libguestfs

[Libguestfs] [PATCH v2] launch: libvirt: Implement drive secrets (RHBZ#1159016).

2014-10-31 Thread Richard W.M. Jones
Implement the GUESTFS_ADD_DRIVE_OPTS_SECRET argument of guestfs_add_drive_opts. For libvirt we have to save the secret in libvirtd first, get a UUID, and then pass the UUID back through the domain XML. --- bootstrap| 1 + generator/actions.ml | 2 +- m4/.gitignore| 7 +-

Re: [Libguestfs] [PATCH] launch: libvirt: Implement drive secrets (RHBZ#1159016).

2014-10-31 Thread Daniel P. Berrange
On Fri, Oct 31, 2014 at 11:04:25AM +, Richard W.M. Jones wrote: > Implement the GUESTFS_ADD_DRIVE_OPTS_SECRET argument of > guestfs_add_drive_opts. For libvirt we have to save the secret in > libvirtd first, get a UUID, and then pass the UUID back through the > domain XML. > --- > src/launch-

[Libguestfs] [PATCH] launch: libvirt: Implement drive secrets (RHBZ#1159016).

2014-10-31 Thread Richard W.M. Jones
Implement the GUESTFS_ADD_DRIVE_OPTS_SECRET argument of guestfs_add_drive_opts. For libvirt we have to save the secret in libvirtd first, get a UUID, and then pass the UUID back through the domain XML. --- src/launch-libvirt.c | 227 ++- 1 file chan