Re: [Libguestfs] [PATCH 1/2] New API: btrfs_filesystem_show

2015-03-05 Thread Chen, Hanxiao
> -Original Message- > From: Richard W.M. Jones [mailto:rjo...@redhat.com] > Sent: Thursday, March 05, 2015 8:59 PM > To: Chen, Hanxiao/陈 晗霄 > Cc: libguestfs@redhat.com > Subject: Re: [Libguestfs] [PATCH 1/2] New API: btrfs_filesystem_show > > AFAICT this API doesn't work: > > $ ./run

Re: [Libguestfs] [PATCH 2/2] New API: btrfs_image_restore

2015-03-05 Thread Chen, Hanxiao
> -Original Message- > From: Richard W.M. Jones [mailto:rjo...@redhat.com] > Sent: Thursday, March 05, 2015 8:48 PM > To: Chen, Hanxiao/陈 晗霄 > Cc: libguestfs@redhat.com > Subject: Re: [Libguestfs] [PATCH 2/2] New API: btrfs_image_restore > > > I'm guessing that what users will actually

Re: [Libguestfs] [PATCH 1/2] New API: btrfs-image

2015-03-05 Thread Chen, Hanxiao
> -Original Message- > From: Richard W.M. Jones [mailto:rjo...@redhat.com] > Sent: Thursday, March 05, 2015 8:47 PM > To: Chen, Hanxiao/陈 晗霄 > Cc: libguestfs@redhat.com > Subject: Re: [Libguestfs] [PATCH 1/2] New API: btrfs-image > > On Tue, Mar 03, 2015 at 03:48:02AM -0500, Chen Hanxiao

[Libguestfs] [PATCH v3] fish: add journal-view command

2015-03-05 Thread Maros Zatko
Lets user view journald log from VM in a similar format as journalctl uses. Makes virt-log use the same code as guestfish for journal-view. Fixes RFE: journal reader in guestfish (RHBZ#988100) --- cat/Makefile.am | 1 + cat/log.c| 113 +--- fish/Mak

[Libguestfs] [PATCH v3] RFE: journal reader in guestfish

2015-03-05 Thread Maros Zatko
There seems to be a minor issue when user wants to run it through pager (more) and wants cancel it. User will end up with stuck guestfish until journal-view transfers all journal items. Output is now configurable, it's the same format as virt-log has, since both uses same code now. Maros Zatko (1

[Libguestfs] [PATCH v2] customize: add --truncate-recursive option

2015-03-05 Thread Maros Zatko
Allows user to recursively truncate all files in a directory. Related to RHBZ#119673 Maros Zatko (1): customize: add --truncate-recursive option builder/cmdline.ml | 3 ++- customize/customize_run.ml | 4 generator/customize.ml | 8 mllib/common_utils.ml | 8

[Libguestfs] [PATCH v2] customize: add --truncate-recursive option

2015-03-05 Thread Maros Zatko
Allows user to recursively truncate files in PATH. e.g.: virt-builder --truncate-recursive /var/log Relates to RHBZ#119673 --- builder/cmdline.ml | 3 ++- customize/customize_run.ml | 4 generator/customize.ml | 8 mllib/common_utils.ml | 8 mllib/common_ut

Re: [Libguestfs] [PATCH] customize: add --truncate-recursive option

2015-03-05 Thread Richard W.M. Jones
On Thu, Mar 05, 2015 at 01:01:23PM +, Richard W.M. Jones wrote: > On Thu, Mar 05, 2015 at 01:58:21PM +0100, Maros Zatko wrote: > > + let files = List.filter (fun f -> g#is_file (path ^ f)) maybefiles in > > I'm surprised that path ^ f works ... > > Suggest using the library function `rm_

Re: [Libguestfs] [PATCH] customize: add --truncate-recursive option

2015-03-05 Thread Richard W.M. Jones
On Thu, Mar 05, 2015 at 01:58:21PM +0100, Maros Zatko wrote: > + let files = List.filter (fun f -> g#is_file (path ^ f)) maybefiles in I'm surprised that path ^ f works ... Suggest using the library function `rm_rf_only_files' instead. Rich. -- Richard Jones, Virtualization Group, Red Hat

[Libguestfs] [PATCH] customize: add --truncate-recursive option

2015-03-05 Thread Maros Zatko
Allows user to recursively truncate all files in a directory. Related to RHBZ#119673 Maros Zatko (1): customize: add --truncate-recursive option builder/cmdline.ml | 3 ++- customize/customize_run.ml | 6 ++ generator/customize.ml | 8 3 files changed, 16 insertions(+)

Re: [Libguestfs] [PATCH 1/2] New API: btrfs_filesystem_show

2015-03-05 Thread Richard W.M. Jones
AFAICT this API doesn't work: $ ./run guestfish -N fs:btrfs btrfs-filesystem-show /dev/sda1 libguestfs: error: btrfs_filesystem_show: /dev/sda1: When I tried the btrfs-filesystem-show-all API, I see a lot of structure in the output: $ ./run guestfish -N fs:btrfs btrfs-filesystem-show-all

[Libguestfs] [PATCH] customize: add --truncate-recursive option

2015-03-05 Thread Maros Zatko
Allows user to recursively truncate files in PATH. e.g.: virt-builder --truncate-recursive /var/log Relates to RHBZ#119673 --- builder/cmdline.ml | 3 ++- customize/customize_run.ml | 6 ++ generator/customize.ml | 8 3 files changed, 16 insertions(+), 1 deletion(-) diff

Re: [Libguestfs] [PATCH 2/2] New API: btrfs_image_restore

2015-03-05 Thread Richard W.M. Jones
I'm guessing that what users will actually want to do is to download and upload these images, rather than having to write them to another part of the disk image first. I wonder if btrfs-image can do streaming? Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjon

Re: [Libguestfs] [PATCH 1/2] New API: btrfs-image

2015-03-05 Thread Richard W.M. Jones
On Tue, Mar 03, 2015 at 03:48:02AM -0500, Chen Hanxiao wrote: > Signed-off-by: Chen Hanxiao > + if (compresslevel >= 0) { > +snprintf (compresslevel_s, sizeof compresslevel_s, "%d", compresslevel); > +ADD_ARG (argv, i, "-c"); > +ADD_ARG (argv, i, compresslevel_s); > + } Because comp

Re: [Libguestfs] [PATCH v2] fish: add journal-view command

2015-03-05 Thread Richard W.M. Jones
On Tue, Mar 03, 2015 at 09:55:06PM +0100, Maros Zatko wrote: > Lets user view journald log from VM in a similar format as journalctl uses. > > Makes virt-log use the same code as guestfish for journal-view. > > Fixes RFE: journal reader in guestfish (RHBZ#988100) > --- > cat/Makefile.am |

Re: [Libguestfs] [PATCH] actions: improve man page links

2015-03-05 Thread Richard W.M. Jones
On Tue, Mar 03, 2015 at 03:39:13PM +0100, Pino Toscano wrote: > Switch from C<> to L<> for links to man pages, where wasn't done before. Thanks - pushed. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rw

Re: [Libguestfs] [PATCH] builder: add build script for PPC64 Fedora

2015-03-05 Thread Richard W.M. Jones
Thanks, I have pushed both the --truncate option and this ppc64 patch. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many po

Re: [Libguestfs] supermin on arm

2015-03-05 Thread Richard W.M. Jones
On Wed, Mar 04, 2015 at 10:18:28AM +, Richard W.M. Jones wrote: > On Tue, Mar 03, 2015 at 07:37:47PM -0600, Dennis Gilmore wrote: > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA1 > > > > Hi all, > > > > I was testing oz/imagefactory on 32 bit arm, you have to have > > kernel-lpae install