[Libguestfs] [PATCH] btrfs: fix leak in btrfs_scrub_status

2015-06-18 Thread Pino Toscano
Properly free the output buffer. --- daemon/btrfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/daemon/btrfs.c b/daemon/btrfs.c index 2f875ae..050bf18 100644 --- a/daemon/btrfs.c +++ b/daemon/btrfs.c @@ -1814,7 +1814,7 @@ do_btrfs_scrub_status (const char *path)

Re: [Libguestfs] [PATCH v4 2/3] do_btrfs_subvolume_list: fix a bad return value

2015-06-18 Thread Pino Toscano
Hi, On Thursday 18 June 2015 05:14:46 Chen, Hanxiao wrote: -Original Message- From: libguestfs-boun...@redhat.com [mailto:libguestfs-boun...@redhat.com] On Behalf Of Pino Toscano Sent: Wednesday, June 17, 2015 10:44 PM To: libguestfs@redhat.com Subject: Re: [Libguestfs]

Re: [Libguestfs] [PATCH] daemon: parted: Always use -s option even with -m.

2015-06-18 Thread Richard W.M. Jones
On Wed, Jun 17, 2015 at 07:50:11PM +0100, Richard W.M. Jones wrote: On Wed, Jun 17, 2015 at 05:23:53PM +0100, Richard W.M. Jones wrote: See: https://bugzilla.redhat.com/show_bug.cgi?id=1232241#c3 --- daemon/parted.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Libguestfs] [PATCH] error log: keep more calloc and its error messages match

2015-06-18 Thread Chen Hanxiao
Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- cat/cat.c | 4 ++-- cat/ls.c | 4 ++-- daemon/md.c | 2 +- daemon/stat.c | 2 +- daemon/xattr.c| 2 +- df/main.c | 4 ++-- edit/edit.c | 4 ++-- fish/fish.c

Re: [Libguestfs] [PATCH] New API: btrfs_device_stats

2015-06-18 Thread Pino Toscano
Hi, On Thursday 18 June 2015 11:01:37 Cao jin wrote: Speaking of this: you said that you have a colleague working on btrfs-progs? What about suggesting to create some machine-parseable output (csv, xml, yaml, json, whatever) so extracting the results of btrfs tools is a lot more easy?

Re: [Libguestfs] [PATCH] error log: keep more calloc and its error messages match

2015-06-18 Thread Richard W.M. Jones
Thanks - I will push this shortly. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net

[Libguestfs] [PATCH v2 3/3] v2v: Improve handling when one of the input disks is blank (RHBZ#1232192).

2015-06-18 Thread Richard W.M. Jones
In commit 4c73d1d4f142c6f6211c963beea68773e11fd3ef, I changed the behaviour of virt-v2v so it ignores all errors from the g#part_get_parttype method. However that would ignore I/O errors and similar. Only ignore the unrecognised disk label error from parted, by testing if the return code is

Re: [Libguestfs] [PATCH v4 2/3] do_btrfs_subvolume_list: fix a bad return value

2015-06-18 Thread Chen, Hanxiao
Hi, -Original Message- From: libguestfs-boun...@redhat.com [mailto:libguestfs-boun...@redhat.com] On Behalf Of Pino Toscano Sent: Thursday, June 18, 2015 4:32 PM To: libguestfs@redhat.com Subject: Re: [Libguestfs] [PATCH v4 2/3] do_btrfs_subvolume_list: fix a bad return value

[Libguestfs] [PATCH v2 1/3] daemon: parted: Always use -s option even with -m.

2015-06-18 Thread Richard W.M. Jones
See: https://bugzilla.redhat.com/show_bug.cgi?id=1232241#c3 However adding the -s parameter changes the error code returned by parted when it processes a blank disk (or other unrecognized partition table). Without -s it prints an error but returns a non-error exit code (0). With -s it prints an