Re: [Libguestfs] Issue with virt-builder on Ubuntu 14.04

2015-06-30 Thread Richard W.M. Jones
On Mon, Jun 29, 2015 at 08:49:26PM -0600, Shawn Greig wrote: [...] Thanks for the detailed bug report. The issue is indeed something strange with your host or KVM or your host kernel (3.13.0-55-generic). As you can see from the end of the messages: [0.371018] EXT4-fs (sdb): mounting ext2

[Libguestfs] Issue with virt-builder on Ubuntu 14.04

2015-06-30 Thread Shawn Greig
Hello, I am running into problems with virt-builder on my Ubuntu-14.04 install. Please find the checklist below: 1. What are you trying to achieve? I'm trying to build a standard Ubuntu 14.04 disk image. 2. What exact commands did you run? I ran virt-builder ubuntu-14.04 3. What was

Re: [Libguestfs] [PATCH v4 1/7] uuid: add support to change uuid of btrfs partition

2015-06-30 Thread Pino Toscano
In data martedì 30 giugno 2015 19:23:08, Chen Hanxiao ha scritto: btrfs-progs v4.1 add support to change uuid of btrfs fs. Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- [...] +# Setting btrfs UUID +eval { +$g-set_uuid (/dev/sda1, 12345678-1234-1234-1234-123456789012);

[Libguestfs] [PATCH] tests: fix two minor warnings

2015-06-30 Thread Chen Hanxiao
my variable $output masks earlier declaration in same scope at /home/libguestfs/tests/daemon/test-btrfs.pl line 66. my variable @r masks earlier declaration in same scope at /home/libguestfs/tests/daemon/test-btrfs.pl line 72. Also remove some redundant whitespace. Signed-off-by: Chen Hanxiao

Re: [Libguestfs] [PATCH v4 6/7] daemon: add functions for setting random uuid of fs

2015-06-30 Thread Pino Toscano
Hi, In data martedì 30 giugno 2015 19:23:13, Chen Hanxiao ha scritto: Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- daemon/btrfs.c | 21 + daemon/daemon.h | 4 daemon/ext2.c | 15 +++ daemon/swap.c | 13 + daemon/xfs.c

Re: [Libguestfs] [PATCH v4 1/7] uuid: add support to change uuid of btrfs partition

2015-06-30 Thread Pino Toscano
Hi, In data martedì 30 giugno 2015 19:23:08, Chen Hanxiao ha scritto: +int +btrfs_set_uuid (const char *device, const char *uuid) +{ + CLEANUP_FREE char *err = NULL; + int r; + int has_uuid_opts = test_btrfstune_uuid_opt (); + + if (has_uuid_opts = 0) { +reply_with_error_errno

Re: [Libguestfs] Issue with virt-builder on Ubuntu 14.04

2015-06-30 Thread Richard W.M. Jones
On Tue, Jun 30, 2015 at 09:07:25AM -0600, Shawn Greig wrote: - I tried forcing TCG and it gets to the same spot and stops. That excludes the possibility that it's a KVM or kernel bug (probably). - running make quickcheck passes the tests (see attached) - I tried a different kernel

Re: [Libguestfs] Plan for libguestfs 1.30

2015-06-30 Thread Luigi Toscano
On Tuesday 30 of June 2015 15:58:54 Richard W.M. Jones wrote: On Tue, Jun 30, 2015 at 04:49:13PM +0200, Luigi Toscano wrote: On Tuesday 30 of June 2015 15:22:27 Richard W.M. Jones wrote: It has been a ludicrously long time (over 8 months) since the last stable release of libguestfs. So

Re: [Libguestfs] Plan for libguestfs 1.30

2015-06-30 Thread Richard W.M. Jones
On Tue, Jun 30, 2015 at 04:49:13PM +0200, Luigi Toscano wrote: On Tuesday 30 of June 2015 15:22:27 Richard W.M. Jones wrote: It has been a ludicrously long time (over 8 months) since the last stable release of libguestfs. So I'd like to plan a new 1.30 release soon. Please follow-up

Re: [Libguestfs] [PATCH v4 7/7] New API: set_uuid_random

2015-06-30 Thread Pino Toscano
In data martedì 30 giugno 2015 19:23:14, Chen Hanxiao ha scritto: Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- daemon/uuids.c | 31 +++ generator/actions.ml | 16 src/MAX_PROC_NR| 2 +-

Re: [Libguestfs] Issue with virt-builder on Ubuntu 14.04

2015-06-30 Thread Richard W.M. Jones
On Tue, Jun 30, 2015 at 09:41:45AM -0600, Shawn Greig wrote: Rich you're right, I forgot to run make. I added 'set -x' and reran make and then ran 'virt-builder -v -x' and it seems to hang at dhclient (see attached log). + dhclient --version + dhclient /sbin/dhclient-script: line 31:

Re: [Libguestfs] [PATCH v4 0/7] uuid: add btrfs uuid change support and set_uuid_random

2015-06-30 Thread Pino Toscano
In data martedì 30 giugno 2015 19:23:07, Chen Hanxiao ha scritto: - Btrfs-progs v4.1 introduced new feature of changing uuid of btrfs partition. This patch add support of this. - Introduce set_uuid_random - uuids.c did a lot of deplicated work for changing uuid of fs. Use existing

Re: [Libguestfs] Plan for libguestfs 1.30

2015-06-30 Thread Luigi Toscano
On Tuesday 30 of June 2015 15:22:27 Richard W.M. Jones wrote: It has been a ludicrously long time (over 8 months) since the last stable release of libguestfs. So I'd like to plan a new 1.30 release soon. Please follow-up if there are features / blockers / bugs that need to be addressed for

[Libguestfs] Plan for libguestfs 1.30

2015-06-30 Thread Richard W.M. Jones
It has been a ludicrously long time (over 8 months) since the last stable release of libguestfs. So I'd like to plan a new 1.30 release soon. Please follow-up if there are features / blockers / bugs that need to be addressed for 1.30. As usual, bugs which have 1.30 (without quotes) in the Devel

Re: [Libguestfs] Plan for libguestfs 1.30

2015-06-30 Thread Pino Toscano
Hi, In data martedì 30 giugno 2015 15:22:27, Richard W.M. Jones ha scritto: It has been a ludicrously long time (over 8 months) since the last stable release of libguestfs. So I'd like to plan a new 1.30 release soon. Please follow-up if there are features / blockers / bugs that need to

Re: [Libguestfs] Issue with virt-builder on Ubuntu 14.04

2015-06-30 Thread Shawn Greig
Yeah, it's definitely an issue with dhclient. I patched the init script to use dhcpcd instead and everything is working as expected now. I've attached a log containing the strace of dhclient if that helps you or someone else in the future. Thanks for all your help Rich. Shawn On Tue, Jun 30,

Re: [Libguestfs] Issue with virt-builder on Ubuntu 14.04

2015-06-30 Thread Richard W.M. Jones
On Tue, Jun 30, 2015 at 11:50:57AM -0600, Shawn Greig wrote: Yeah, it's definitely an issue with dhclient. I patched the init script to use dhcpcd instead and everything is working as expected now. /sbin/dhclient-script: line 31: /etc/fstab: No such file or directory So it seems to actually

Re: [Libguestfs] [PATCH v4] RFC: New tool: virt-dib

2015-06-30 Thread Richard W.M. Jones
On Tue, Jun 16, 2015 at 12:15:22PM +0200, Pino Toscano wrote: [...] There is some trailing whitespace on one line. 'git show' should highlight it. diff --git a/appliance/packagelist.in b/appliance/packagelist.in index 76c7293..a4f814b 100644 --- a/appliance/packagelist.in +++

Re: [Libguestfs] [PATCH] tests: fix two minor warnings

2015-06-30 Thread Richard W.M. Jones
On Tue, Jun 30, 2015 at 05:45:14PM +0800, Chen Hanxiao wrote: my variable $output masks earlier declaration in same scope at /home/libguestfs/tests/daemon/test-btrfs.pl line 66. my variable @r masks earlier declaration in same scope at /home/libguestfs/tests/daemon/test-btrfs.pl line 72.

[Libguestfs] [PATCH v4 5/7] daemon: add get_random_uuid

2015-06-30 Thread Chen Hanxiao
Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- appliance/packagelist.in | 1 + daemon/daemon.h | 2 ++ daemon/guestfsd.c| 19 +++ 3 files changed, 22 insertions(+) diff --git a/appliance/packagelist.in b/appliance/packagelist.in index

[Libguestfs] [PATCH v4 3/7] uuid: use newly introduced xfs_set_uuid of xfs

2015-06-30 Thread Chen Hanxiao
Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- v3: rename do_xfs_admin_uuid to xfs_set_uuid daemon/daemon.h | 1 + daemon/uuids.c | 12 +--- daemon/xfs.c| 7 +++ 3 files changed, 9 insertions(+), 11 deletions(-) diff --git a/daemon/daemon.h b/daemon/daemon.h index

[Libguestfs] [PATCH v4 1/7] uuid: add support to change uuid of btrfs partition

2015-06-30 Thread Chen Hanxiao
btrfs-progs v4.1 add support to change uuid of btrfs fs. Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- v4: although btrfstune did not had '--help', pass it anyway improve testcases v3: set errno as ENOTSUP when btrfstune -u is not available v2: put btrfs operation back to

[Libguestfs] [PATCH v4 2/7] uuid: use existing function of ext2

2015-06-30 Thread Chen Hanxiao
Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- v3: improve commit log daemon/uuids.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/daemon/uuids.c b/daemon/uuids.c index f98d8e5..b8b820a 100644 --- a/daemon/uuids.c +++ b/daemon/uuids.c @@ -27,16

[Libguestfs] [PATCH v4 6/7] daemon: add functions for setting random uuid of fs

2015-06-30 Thread Chen Hanxiao
Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- daemon/btrfs.c | 21 + daemon/daemon.h | 4 daemon/ext2.c | 15 +++ daemon/swap.c | 13 + daemon/xfs.c| 7 +++ 5 files changed, 60 insertions(+) diff --git a/daemon/btrfs.c

[Libguestfs] [PATCH v4 0/7] uuid: add btrfs uuid change support and set_uuid_random

2015-06-30 Thread Chen Hanxiao
- Btrfs-progs v4.1 introduced new feature of changing uuid of btrfs partition. This patch add support of this. - Introduce set_uuid_random - uuids.c did a lot of deplicated work for changing uuid of fs. Use existing functions. v4: introduce get_random_uuid improve testcases squash

[Libguestfs] [PATCH v4 4/7] uuid: use newly introduced swap_set_uuid

2015-06-30 Thread Chen Hanxiao
Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- v3: move swapuuid to swap.c rename it as swap_set_uuid daemon/daemon.h | 3 +++ daemon/swap.c | 16 daemon/uuids.c | 18 +- 3 files changed, 20 insertions(+), 17 deletions(-) diff --git

[Libguestfs] [PATCH v4 7/7] New API: set_uuid_random

2015-06-30 Thread Chen Hanxiao
Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- daemon/uuids.c | 31 +++ generator/actions.ml | 16 src/MAX_PROC_NR| 2 +- tests/btrfs/test-btrfs-misc.pl | 15 +++ 4 files changed, 63