Re: [Libguestfs] [nbdkit PATCH v3 1/4] plugins: Don't use bogus errno from non-C plugins

2017-01-27 Thread Richard W.M. Jones
On Fri, Jan 27, 2017 at 08:01:17AM -0600, Eric Blake wrote: > On 01/27/2017 04:11 AM, Richard W.M. Jones wrote: > > > > Actually OCaml is a real compiled language, and the call from C to > > OCaml code (via caml_callback_exn) is a short piece of asm which > > preserves errno. > > Which shows my l

Re: [Libguestfs] [nbdkit PATCH v3 1/4] plugins: Don't use bogus errno from non-C plugins

2017-01-27 Thread Eric Blake
On 01/27/2017 04:11 AM, Richard W.M. Jones wrote: > > Actually OCaml is a real compiled language, and the call from C to > OCaml code (via caml_callback_exn) is a short piece of asm which > preserves errno. Which shows my lack of familiarity with OCaml; but I'm guessing that also means that OCaml

Re: [Libguestfs] [nbdkit PATCH v3 4/4] python: Support zero callback

2017-01-27 Thread Richard W.M. Jones
Patch 2, 3 & 4 look fine. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports

Re: [Libguestfs] [nbdkit PATCH v3 1/4] plugins: Don't use bogus errno from non-C plugins

2017-01-27 Thread Richard W.M. Jones
On Thu, Jan 26, 2017 at 08:58:34PM -0600, Eric Blake wrote: > diff --git a/plugins/ocaml/ocaml.c b/plugins/ocaml/ocaml.c > index e2b433e..5d7aeeb 100644 > --- a/plugins/ocaml/ocaml.c > +++ b/plugins/ocaml/ocaml.c > @@ -499,6 +499,17 @@ SET(pwrite) > SET(flush) > SET(trim) > > +/* We can't guaran