Re: [Libguestfs] [PATCH 2/2] python: unicode decode handler error scheme setter

2017-06-16 Thread Pino Toscano
On Sunday, 21 May 2017 18:29:03 CEST Matteo Cafasso wrote: > The set_decode_error_handler function allows the User to set the > decoding error scheme to be used when non UTF8 characters are > encountered in Python 3. s/User/user/, and s/UTF8/UTF-8/ > The function has no effect in Python 2. > > S

[Libguestfs] [PATCH] inspection: Deprecate APIs and remove support for inspecting installer CDs.

2017-06-16 Thread Richard W.M. Jones
This just duplicated libosinfo information, and because it was never tested it didn't work most of the time. --- docs/C_SOURCE_FILES| 2 - generator/actions_inspection.ml| 67 --- generator/actions_inspection_deprecated.ml | 61 +++ inspector/Makefile.am

Re: [Libguestfs] [PATCH v6 04/41] mllib: Split ‘Common_utils’ into ‘Std_utils’ + ‘Common_utils’.

2017-06-16 Thread Pino Toscano
On Thursday, 15 June 2017 19:05:54 CEST Richard W.M. Jones wrote: > The new module ‘Std_utils’ contains only functions which are pure > OCaml and depend only on the OCaml stdlib. Therefore these functions > may be used by the generator. Hm can we please use a better name than Std_utils? Otherwise

Re: [Libguestfs] [PATCH v6 05/41] utils: Split out cleanups into common/cleanups.

2017-06-16 Thread Pino Toscano
On Thursday, 15 June 2017 19:05:55 CEST Richard W.M. Jones wrote: > Those cleanups which only depend on libc, gnulib or libxml2 are split > out into a separate common/cleanups directory. > --- IMHO a single cleanups.c source should be enough, otherwise it's overly split... -- Pino Toscano signa

Re: [Libguestfs] [PATCH v6 10/41] mllib, v2v: Split out OCaml utils bindings ‘common/mlutils’.

2017-06-16 Thread Pino Toscano
On Thursday, 15 June 2017 19:06:00 CEST Richard W.M. Jones wrote: > Create a module ‘C_utils’ containing functions like ‘drive_name’ and > ‘shell_unquote’ which come from the C utilities. > > The new directory ‘common/mlutils’ also contains the ‘Unix_utils’ > wrappers around POSIX functions missin

Re: [Libguestfs] [PATCH v6 11/41] utils: Rename ‘guestfs-internal-frontend.h’ to ‘utils.h’.

2017-06-16 Thread Pino Toscano
NACK to utils.h -- in the past I've seen a couple of libraries installing public includes as utils.h. They have been fixed, but I'd like to avoid conflicts between an installed header and a project header. -- Pino Toscano signature.asc Description: This is a digitally signed message part. __

Re: [Libguestfs] [PATCH v6 05/41] utils: Split out cleanups into common/cleanups.

2017-06-16 Thread Richard W.M. Jones
On Fri, Jun 16, 2017 at 03:24:55PM +0200, Pino Toscano wrote: > On Thursday, 15 June 2017 19:05:55 CEST Richard W.M. Jones wrote: > > Those cleanups which only depend on libc, gnulib or libxml2 are split > > out into a separate common/cleanups directory. > > --- > > IMHO a single cleanups.c source

Re: [Libguestfs] [PATCH v6 10/41] mllib, v2v: Split out OCaml utils bindings ‘common/mlutils’.

2017-06-16 Thread Richard W.M. Jones
On Fri, Jun 16, 2017 at 03:38:35PM +0200, Pino Toscano wrote: > On Thursday, 15 June 2017 19:06:00 CEST Richard W.M. Jones wrote: > > Create a module ‘C_utils’ containing functions like ‘drive_name’ and > > ‘shell_unquote’ which come from the C utilities. > > > > The new directory ‘common/mlutils’

Re: [Libguestfs] [PATCH v6 11/41] utils: Rename ‘guestfs-internal-frontend.h’ to ‘utils.h’.

2017-06-16 Thread Richard W.M. Jones
On Fri, Jun 16, 2017 at 03:42:35PM +0200, Pino Toscano wrote: > NACK to utils.h -- in the past I've seen a couple of libraries > installing public includes as utils.h. They have been fixed, but > I'd like to avoid conflicts between an installed header and a project > header. Can we prevent incorre