[Libguestfs] [nbdkit PATCH 2/1] RFC: tests: Run tests that don't require libguestfs

2018-04-09 Thread Eric Blake
A bit of refactoring to the HAVE_LIBGUESTFS conditional, coupled with the addition of a LIBGUESTFS_TESTS intermediate list, allows us to run a few more tests on CentOS 6 (adding some tests of command-line behavior and filters that was previously completely skipped). For the two tests that we can't

[Libguestfs] [PATCH] Fix out-of-tree builds of OCaml components

2018-04-09 Thread Hilko Bengen
- Add $(srcdir), $(builddir) to Makefiles where required - Post-process ocamldep output - generate ocaml/.depends --- builder/Makefile.am | 7 --- common/mlgettext/Makefile.am | 2 +- common/mlpcre/Makefile.am | 2 +- common/mlprogress/Makefile.am | 2 +- common/mlstdutils/M

Re: [Libguestfs] [PATCH 2/3] daemon: use the structs from the Structs module

2018-04-09 Thread Richard W.M. Jones
ACK 1/3 and 2/3. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supporte

Re: [Libguestfs] [PATCH 3/3] daemon: autogenerate most of OCaml interfaces

2018-04-09 Thread Richard W.M. Jones
On Mon, Apr 09, 2018 at 04:06:32PM +0200, Pino Toscano wrote: > diff --git a/generator/daemon.ml b/generator/daemon.ml > index 7fb7052a0..03b191ac8 100644 > --- a/generator/daemon.ml > +++ b/generator/daemon.ml > @@ -490,6 +490,91 @@ let generate_daemon_caml_callbacks_ml () = >else > pr "l

[Libguestfs] [PATCH 1/3] daemon: directly use Optgroups

2018-04-09 Thread Pino Toscano
Avoid extra module variables, and just use Optgroups directly. --- daemon/ldm.ml| 2 -- daemon/ldm.mli | 2 -- daemon/listfs.ml | 4 ++-- daemon/lvm.ml| 2 -- daemon/lvm.mli | 2 -- 5 files changed, 2 insertions(+), 10 deletions(-) diff --git a/daemon/ldm.ml b/daemon/ldm.ml index c177

[Libguestfs] [PATCH 2/3] daemon: use the structs from the Structs module

2018-04-09 Thread Pino Toscano
No need to redeclare them again in few modules, just use them from the Structs module. --- daemon/btrfs.mli | 8 +--- daemon/inspect_fs_windows.ml | 4 ++-- daemon/listfs.ml | 4 ++-- daemon/parted.mli| 9 + daemon/statvfs.mli | 16 +---

[Libguestfs] [PATCH 0/3] daemon: generate almost all the API OCaml interfaces

2018-04-09 Thread Pino Toscano
Hi, as a followup for the signature fix for mount_vfs [1], here it is a patch series to generate automatically most of the OCaml interfaces of daemon actions. Only the Lvm and Mount modules are left with hand-written interfaces. [1] https://www.redhat.com/archives/libguestfs/2018-April/msg00059.

[Libguestfs] [PATCH 3/3] daemon: autogenerate most of OCaml interfaces

2018-04-09 Thread Pino Toscano
Add a way to generate OCaml interfaces for a whilelist of modules in the daemon that implement APIs: this makes sure that for them the interface of each function matches the actual API specified in the generator. Only the modules specified in a list are generated for now, although this coverts alm

Re: [Libguestfs] [nbdkit PATCH 2/2] python: Simplify calling into plugin

2018-04-09 Thread Eric Blake
On 04/06/2018 05:24 PM, Eric Blake wrote: > PyObject_CallObject is powerful, but awkward - we have to wrap > all arguments into a temporary tuple before using it. > > Let python do more of the work by using PyObject_CallFunction > anywhere that all arguments can be described by a Py_BuildValue() >

Re: [Libguestfs] Change in ovirt-imageio[master]: Document the random I/O APIs

2018-04-09 Thread Richard W.M. Jones
On Wed, Mar 28, 2018 at 04:10:28PM +, Daniel Erez wrote: > Hi Richard, > > We've added zero and flush functionality to imageio-daemon. > > You can download and test the latest build (for el7/fc) from: > - > http://jenkins.ovirt.org/job/ovirt-imageio_master_build-artifacts-el7-x86_64/200/artif

Re: [Libguestfs] [PATCH] daemon: Fix type signature of mount_vfs (RHBZ#1564983).

2018-04-09 Thread Pino Toscano
On Monday, 9 April 2018 09:54:51 CEST Richard W.M. Jones wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1564983 > > Because Mount.mount_vfs was declared with the wrong type signature it > could never be called correctly from outside the daemon. LGTM. > The root cause of this problem is tha

[Libguestfs] [PATCH] daemon: Fix type signature of mount_vfs (RHBZ#1564983).

2018-04-09 Thread Richard W.M. Jones
Reported-by: Yongkui Guo. Fixes commit 82bbd9c8a503661528289589976697d08cb41090. --- daemon/inspect_fs.ml | 6 ++ daemon/mount.ml | 18 +- daemon/mount.mli | 2 +- 3 files changed, 12 insertions(+), 14 deletions(-) diff --git a/daemon/inspect_fs.ml b/daemon/inspect

[Libguestfs] [PATCH] daemon: Fix type signature of mount_vfs (RHBZ#1564983).

2018-04-09 Thread Richard W.M. Jones
https://bugzilla.redhat.com/show_bug.cgi?id=1564983 Because Mount.mount_vfs was declared with the wrong type signature it could never be called correctly from outside the daemon. The root cause of this problem is that the generator doesn't generate the type signatures automatically (which it coul

Re: [Libguestfs] [PATCH v3 2/3] v2v: OVF: write ovirt:id attribute for the OS in OVirt flavour

2018-04-09 Thread Pino Toscano
On Friday, 6 April 2018 17:45:22 CEST Tomáš Golembiovský wrote: > On Thu, 5 Apr 2018 14:53:51 +0200 > Pino Toscano wrote: > > > @@ -383,8 +581,9 @@ let rec create_ovf source targets guestcaps inspect > > ] in > > (match ovf_flavour with > > | OVirt -> > > - e